Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0034077 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | minor | have not tried | 2016-09-24 13:56 | 2016-09-28 09:11 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR16Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 4a9084e1f26f | ||||
| Projection | none | ETA | none | Target Version | RR16Q4 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | Sandrahuguet | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0034077: Unnecessary set of json property with wrong value when saving cusotmer(address) | |||||||
| Description | There are several places in the customer address code where the json property is set in the wrong way and unnecessarily as it was already set correctly. | |||||||
| Steps To Reproduce | Put breakpoints in the changed locations and check what is being set in the object's json property | |||||||
| Proposed Solution | remove the unnecessary line or use JSON.stringify to correctly set the value | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0090226) hgbot (developer) 2016-09-25 11:49 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 4a9084e1f26fcbdaf885aefb77cb78fb6408de94 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Sun Sep 25 11:49:27 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4a9084e1f26fcbdaf885aefb77cb78fb6408de94 [^] Fixes issue 34077: Unnecessary set of json property with wrong value when saving cusotmer(address) Remove code which has no impact as it is set after saving the object and the logic is incorrect anyway --- M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js --- |
|
(0090324) Sandrahuguet (developer) 2016-09-28 09:11 |
Reviewed and tested |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-09-24 13:56 | mtaal | New Issue | |
| 2016-09-24 13:56 | mtaal | Assigned To | => mtaal |
| 2016-09-24 13:56 | mtaal | Triggers an Emergency Pack | => No |
| 2016-09-24 14:14 | mtaal | Summary | Json property should always be set using stringified json => Unnecessary set of json property with wrong value when saving cusotmer(address) |
| 2016-09-24 14:14 | mtaal | Description Updated | View Revisions |
| 2016-09-24 14:14 | mtaal | Steps to Reproduce Updated | View Revisions |
| 2016-09-24 14:14 | mtaal | Proposed Solution updated | |
| 2016-09-25 11:49 | hgbot | Checkin | |
| 2016-09-25 11:49 | hgbot | Note Added: 0090226 | |
| 2016-09-25 11:49 | hgbot | Status | new => resolved |
| 2016-09-25 11:49 | hgbot | Resolution | open => fixed |
| 2016-09-25 11:49 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4a9084e1f26fcbdaf885aefb77cb78fb6408de94 [^] |
| 2016-09-25 11:50 | mtaal | Review Assigned To | => Sandrahuguet |
| 2016-09-25 12:18 | mtaal | Relationship added | depends on 0034026 |
| 2016-09-28 09:11 | Sandrahuguet | Note Added: 0090324 | |
| 2016-09-28 09:11 | Sandrahuguet | Status | resolved => closed |
| 2016-09-28 09:11 | Sandrahuguet | Fixed in Version | => RR16Q4 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |