Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034077Retail ModulesWeb POSpublic2016-09-24 13:562016-09-28 09:11
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q4Fixed in VersionRR16Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034077: Unnecessary set of json property with wrong value when saving cusotmer(address)
DescriptionThere are several places in the customer address code where the json property is set in the wrong way and unnecessarily as it was already set correctly.

Steps To ReproducePut breakpoints in the changed locations and check what is being set in the object's json property
Proposed Solutionremove the unnecessary line or use JSON.stringify to correctly set the value
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0034026RR16Q3.2 closed mtaal JSON error unexpected token in remote BP data when saving address through customer - remove unnecessary json set 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-09-24 13:56mtaalNew Issue
2016-09-24 13:56mtaalAssigned To => mtaal
2016-09-24 13:56mtaalTriggers an Emergency Pack => No
2016-09-24 14:14mtaalSummaryJson property should always be set using stringified json => Unnecessary set of json property with wrong value when saving cusotmer(address)
2016-09-24 14:14mtaalDescription Updatedbug_revision_view_page.php?rev_id=13176#r13176
2016-09-24 14:14mtaalSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13178#r13178
2016-09-24 14:14mtaalProposed Solution updated
2016-09-25 11:49hgbotCheckin
2016-09-25 11:49hgbotNote Added: 0090226
2016-09-25 11:49hgbotStatusnew => resolved
2016-09-25 11:49hgbotResolutionopen => fixed
2016-09-25 11:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4a9084e1f26fcbdaf885aefb77cb78fb6408de94 [^]
2016-09-25 11:50mtaalReview Assigned To => Sandrahuguet
2016-09-25 12:18mtaalRelationship addeddepends on 0034026
2016-09-28 09:11SandrahuguetNote Added: 0090324
2016-09-28 09:11SandrahuguetStatusresolved => closed
2016-09-28 09:11SandrahuguetFixed in Version => RR16Q4

Notes
(0090226)
hgbot   
2016-09-25 11:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4a9084e1f26fcbdaf885aefb77cb78fb6408de94
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Sep 25 11:49:27 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4a9084e1f26fcbdaf885aefb77cb78fb6408de94 [^]

Fixes issue 34077: Unnecessary set of json property with wrong value when saving cusotmer(address)
Remove code which has no impact as it is set after saving the object and the logic is incorrect anyway

---
M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js
M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js
---
(0090324)
Sandrahuguet   
2016-09-28 09:11   
Reviewed and tested