Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033879
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 04. Warehouse managementmajoralways2016-09-02 08:342016-09-19 16:27
ReporterumartirenaView Statuspublic 
Assigned Tomarkmm82 
PrioritynormalResolutionfixedFixed in Version3.0PR16Q4
StatusclosedFix in branchFixed in SCM revision09f464ff5bde
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toaferraz
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033879: Close Reservation process fails

DescriptionClose Reservation process fails when trying to close a reservation from Stock Reservation window.
Steps To ReproduceIn Live Builds:
 * Activate "Enable Stock Reservations" preference.
 * Go to Sales Order window and create a new header:
  - BP: "Alimentos y supermercados"
 * Create a line:
  - Product: "Cerveza Ale 0.5L"
  - Quantity: 10
 * Book the order
 * Go to line and click on "Manage Reservation". Reserve fully the line.
 * Navigate to the created reservation.
 * In Stock Reservation select the created reservation and click on "Put on Hold". Select as Process Action "Closed".Click OK
 * See that the following error appears: "Error:
null value in column "quantity" violates not-null constraint"
Proposed SolutionI think the problem is that reservation stock lines are created with null value in Released Quantity. They should have 0 there.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0033752 closedmarkmm82 Cannot close an order if the stock was reserved and the associated goods shipment is voided 

-  Notes
(0089817)
markmm82 (developer)
2016-09-07 20:55
edited on: 2016-09-14 10:49

 Test Plan
 * Activate "Enable Stock Reservations" preference.
 * Go to Sales Order window and create a new header:
  - BP: "Alimentos y supermercados"
 * Create a line:
  - Product: "Cerveza Ale 0.5L"
  - Quantity: 10
  - Leave "Stock Reservation" field empty.
 * Book the order
 * Go to line and click on "Manage Reservation". Reserve fully the line.
 * Navigate to the created reservation.
 * In Stock Reservation select the created reservation and click on "Put on Hold". Select as Process Action "Closed".Click OK
 * Notice the process ends successfully.
(0089917)
psanjuan (manager)
2016-09-13 14:00

 Issue verified.
(0089940)
psanjuan (manager)
2016-09-14 10:51

 Test Plan above verified.

Repeat test above by changing Stock Reservation = Manual and Stock Reservation = Automatic. Verify that in all cases the "Stock Reservation" created shows "0" in the field "Released".
(0089944)
psanjuan (manager)
2016-09-14 10:52

 Issue can be code reviewed and closed.
(0090029)
hgbot (developer)
2016-09-16 09:54

 Repository: erp/devel/pi
Changeset: 09f464ff5bde4ed6fc27ddb60e77bb6202ab8547
Author: Mark <markmm82 <at> gmail.com>
Date: Tue Sep 13 11:43:16 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/09f464ff5bde4ed6fc27ddb60e77bb6202ab8547 [^]

Fixes issue 33879: Avoid error when closing reservation from Stock Reservation

Avoided exception when the quantity of reservation stock lines have null value.
When the ManageReservationActionHandler processed the stock reservation it stores the realesed quantity with ZERO value instead of null.

---
M src/org/openbravo/common/actionhandler/ManageReservationActionHandler.java
---
(0090030)
hgbot (developer)
2016-09-16 09:54

 Repository: erp/devel/pi
Changeset: 61036197bbae0d079f41de471f729e4835b76c2d
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Sep 15 14:04:47 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/61036197bbae0d079f41de471f729e4835b76c2d [^]

Related to issue 33879: Code review improvements

---
M src-db/database/model/functions/M_INOUT_POST.xml
M src/org/openbravo/common/actionhandler/ManagePrereservationActionHandler.java
M src/org/openbravo/common/actionhandler/ManageReservationActionHandler.java
---
(0090031)
hgbot (developer)
2016-09-16 09:57

 Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: cea6625cc34014526c3a1661b077ffa074fcd651
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Sep 16 09:56:40 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/cea6625cc34014526c3a1661b077ffa074fcd651 [^]

Related to issue 33879: Code review improvements in Picking module

---
M src/org/openbravo/warehouse/pickinglist/EditPickingListItemHandler.java
---
(0090033)
aferraz (manager)
2016-09-16 10:01

 Code review + Testing OK
(0090071)
hudsonbot (developer)
2016-09-19 16:27

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/17da7ad0ad62 [^]
Maturity status: Test
(0090072)
hudsonbot (developer)
2016-09-19 16:27

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/17da7ad0ad62 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-09-02 08:34 umartirena New Issue
2016-09-02 08:34 umartirena Assigned To => Triage Finance
2016-09-02 08:34 umartirena Modules => Core
2016-09-02 08:34 umartirena Triggers an Emergency Pack => No
2016-09-05 13:28 aferraz Relationship added related to 0033752
2016-09-07 18:43 aferraz Assigned To Triage Finance => markmm82
2016-09-07 20:55 markmm82 Status new => scheduled
2016-09-07 20:55 markmm82 Note Added: 0089817
2016-09-08 17:14 markmm82 Note Edited: 0089817 View Revisions
2016-09-13 14:00 psanjuan Note Added: 0089917
2016-09-14 10:49 psanjuan Note Edited: 0089817 View Revisions
2016-09-14 10:51 psanjuan Note Added: 0089940
2016-09-14 10:52 psanjuan Note Added: 0089944
2016-09-16 09:54 hgbot Checkin
2016-09-16 09:54 hgbot Note Added: 0090029
2016-09-16 09:54 hgbot Status scheduled => resolved
2016-09-16 09:54 hgbot Resolution open => fixed
2016-09-16 09:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/09f464ff5bde4ed6fc27ddb60e77bb6202ab8547 [^]
2016-09-16 09:54 hgbot Checkin
2016-09-16 09:54 hgbot Note Added: 0090030
2016-09-16 09:57 hgbot Checkin
2016-09-16 09:57 hgbot Note Added: 0090031
2016-09-16 10:01 aferraz Review Assigned To => aferraz
2016-09-16 10:01 aferraz Note Added: 0090033
2016-09-16 10:01 aferraz Status resolved => closed
2016-09-16 10:01 aferraz Fixed in Version => 3.0PR16Q4
2016-09-19 16:27 hudsonbot Checkin
2016-09-19 16:27 hudsonbot Note Added: 0090071
2016-09-19 16:27 hudsonbot Checkin
2016-09-19 16:27 hudsonbot Note Added: 0090072

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker