Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033879Openbravo ERP04. Warehouse managementpublic2016-09-02 08:342016-09-19 16:27
Reporterumartirena 
Assigned Tomarkmm82 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033879: Close Reservation process fails
DescriptionClose Reservation process fails when trying to close a reservation from Stock Reservation window.
Steps To ReproduceIn Live Builds:
 * Activate "Enable Stock Reservations" preference.
 * Go to Sales Order window and create a new header:
  - BP: "Alimentos y supermercados"
 * Create a line:
  - Product: "Cerveza Ale 0.5L"
  - Quantity: 10
 * Book the order
 * Go to line and click on "Manage Reservation". Reserve fully the line.
 * Navigate to the created reservation.
 * In Stock Reservation select the created reservation and click on "Put on Hold". Select as Process Action "Closed".Click OK
 * See that the following error appears: "Error:
null value in column "quantity" violates not-null constraint"
Proposed SolutionI think the problem is that reservation stock lines are created with null value in Released Quantity. They should have 0 there.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0033752 closed markmm82 Cannot close an order if the stock was reserved and the associated goods shipment is voided 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-09-02 08:34umartirenaNew Issue
2016-09-02 08:34umartirenaAssigned To => Triage Finance
2016-09-02 08:34umartirenaModules => Core
2016-09-02 08:34umartirenaTriggers an Emergency Pack => No
2016-09-05 13:28aferrazRelationship addedrelated to 0033752
2016-09-07 18:43aferrazAssigned ToTriage Finance => markmm82
2016-09-07 20:55markmm82Statusnew => scheduled
2016-09-07 20:55markmm82Note Added: 0089817
2016-09-08 17:14markmm82Note Edited: 0089817bug_revision_view_page.php?bugnote_id=0089817#r13082
2016-09-13 14:00psanjuanNote Added: 0089917
2016-09-14 10:49psanjuanNote Edited: 0089817bug_revision_view_page.php?bugnote_id=0089817#r13103
2016-09-14 10:51psanjuanNote Added: 0089940
2016-09-14 10:52psanjuanNote Added: 0089944
2016-09-16 09:54hgbotCheckin
2016-09-16 09:54hgbotNote Added: 0090029
2016-09-16 09:54hgbotStatusscheduled => resolved
2016-09-16 09:54hgbotResolutionopen => fixed
2016-09-16 09:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/09f464ff5bde4ed6fc27ddb60e77bb6202ab8547 [^]
2016-09-16 09:54hgbotCheckin
2016-09-16 09:54hgbotNote Added: 0090030
2016-09-16 09:57hgbotCheckin
2016-09-16 09:57hgbotNote Added: 0090031
2016-09-16 10:01aferrazReview Assigned To => aferraz
2016-09-16 10:01aferrazNote Added: 0090033
2016-09-16 10:01aferrazStatusresolved => closed
2016-09-16 10:01aferrazFixed in Version => 3.0PR16Q4
2016-09-19 16:27hudsonbotCheckin
2016-09-19 16:27hudsonbotNote Added: 0090071
2016-09-19 16:27hudsonbotCheckin
2016-09-19 16:27hudsonbotNote Added: 0090072

Notes
(0089817)
markmm82   
2016-09-07 20:55   
(edited on: 2016-09-14 10:49)
Test Plan
 * Activate "Enable Stock Reservations" preference.
 * Go to Sales Order window and create a new header:
  - BP: "Alimentos y supermercados"
 * Create a line:
  - Product: "Cerveza Ale 0.5L"
  - Quantity: 10
  - Leave "Stock Reservation" field empty.
 * Book the order
 * Go to line and click on "Manage Reservation". Reserve fully the line.
 * Navigate to the created reservation.
 * In Stock Reservation select the created reservation and click on "Put on Hold". Select as Process Action "Closed".Click OK
 * Notice the process ends successfully.
(0089917)
psanjuan   
2016-09-13 14:00   
Issue verified.
(0089940)
psanjuan   
2016-09-14 10:51   
Test Plan above verified.

Repeat test above by changing Stock Reservation = Manual and Stock Reservation = Automatic. Verify that in all cases the "Stock Reservation" created shows "0" in the field "Released".
(0089944)
psanjuan   
2016-09-14 10:52   
Issue can be code reviewed and closed.
(0090029)
hgbot   
2016-09-16 09:54   
Repository: erp/devel/pi
Changeset: 09f464ff5bde4ed6fc27ddb60e77bb6202ab8547
Author: Mark <markmm82 <at> gmail.com>
Date: Tue Sep 13 11:43:16 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/09f464ff5bde4ed6fc27ddb60e77bb6202ab8547 [^]

Fixes issue 33879: Avoid error when closing reservation from Stock Reservation

Avoided exception when the quantity of reservation stock lines have null value.
When the ManageReservationActionHandler processed the stock reservation it stores the realesed quantity with ZERO value instead of null.

---
M src/org/openbravo/common/actionhandler/ManageReservationActionHandler.java
---
(0090030)
hgbot   
2016-09-16 09:54   
Repository: erp/devel/pi
Changeset: 61036197bbae0d079f41de471f729e4835b76c2d
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Sep 15 14:04:47 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/61036197bbae0d079f41de471f729e4835b76c2d [^]

Related to issue 33879: Code review improvements

---
M src-db/database/model/functions/M_INOUT_POST.xml
M src/org/openbravo/common/actionhandler/ManagePrereservationActionHandler.java
M src/org/openbravo/common/actionhandler/ManageReservationActionHandler.java
---
(0090031)
hgbot   
2016-09-16 09:57   
Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: cea6625cc34014526c3a1661b077ffa074fcd651
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Sep 16 09:56:40 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/cea6625cc34014526c3a1661b077ffa074fcd651 [^]

Related to issue 33879: Code review improvements in Picking module

---
M src/org/openbravo/warehouse/pickinglist/EditPickingListItemHandler.java
---
(0090033)
aferraz   
2016-09-16 10:01   
Code review + Testing OK
(0090071)
hudsonbot   
2016-09-19 16:27   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/17da7ad0ad62 [^]
Maturity status: Test
(0090072)
hudsonbot   
2016-09-19 16:27   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/17da7ad0ad62 [^]
Maturity status: Test