Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033753
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Gift cards and gift vouchersminorhave not tried2016-08-19 16:222016-09-30 13:18
ReportermtaalView Statuspublic 
Assigned ToSandrahuguet 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision6de0ece83013
ProjectionnoneETAnoneTarget VersionRR16Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033753: In remote product mode 2 gift card requests are done when selecting a product

DescriptionWhen setting remote product mode then when selecting a product to be added to the ticket. A request is done to check if the product is a giftcard.

This request is done twice, it seems from this [1] line.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/file/8925341303dc/web/org.openbravo.retail.giftcards/js/components/lineproperties.js#l36 [^]
Steps To ReproduceInstall webpos with giftcards module
Set remote product pref to Y
Login and select products from search
See that when you select a product there are 2 requests to the gift card module
Proposed SolutionDo maximum one request to the server when selecting a product
TagsNo tags attached.
Attached Filespng file icon Selection_094.png [^] (197,336 bytes) 2016-08-19 16:22

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by defect 0033648 closedSandrahuguet Remote for product preference should be added to giftcard model 

-  Notes
(0089963)
hgbot (developer)
2016-09-15 09:19

 Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: f35a1a3f2647f15895cf417b23a01f8320356188
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Sep 15 09:17:45 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/f35a1a3f2647f15895cf417b23a01f8320356188 [^]

Fixed issue 33753 2 gift card requests are done when selecting a product

Added a new column(giftcard type) to product model to prevent 2 request
when selecting a product.

---
M src/org/openbravo/retail/giftcards/GCNVComponentProvider.java
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
A src/org/openbravo/retail/giftcards/master/GiftCardProductProperties.java
A web/org.openbravo.retail.giftcards/js/model/giftcardproductproperty.js
---
(0089979)
Sandrahuguet (viewer)
2016-09-15 12:58

 Backed out changeset f35a1a3f2647

https://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/186a12a917d9 [^]
(0090007)
hgbot (developer)
2016-09-16 08:18

 Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 1a09201a556b76c8a3bde19d974b8c6858db6b26
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Sep 15 17:19:42 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/1a09201a556b76c8a3bde19d974b8c6858db6b26 [^]

Fixed issue 33753 2 gift card requests are done when selecting a product

Added a new column(giftcard type) to product model to prevent 2 request
when selecting a product.

---
M src/org/openbravo/retail/giftcards/GCNVComponentProvider.java
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
A src/org/openbravo/retail/giftcards/master/GiftCardProductProperties.java
A web/org.openbravo.retail.giftcards/js/model/giftcardproductproperty.js
---
(0090066)
Sandrahuguet (viewer)
2016-09-19 16:13

 Backed out changeset 1a09201a556b

https://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/026ee833fdc6 [^]
(0090100)
hgbot (developer)
2016-09-20 08:41

 Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 6de0ece8301334b1a67f19567bdcc772b536705f
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon Sep 19 16:10:35 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/6de0ece8301334b1a67f19567bdcc772b536705f [^]

Fixed issue 33753 2 gift card requests are done when selecting a product

Added a new column(giftcard type) to product model to prevent 2 request
when selecting a product.

---
M src/org/openbravo/retail/giftcards/GCNVComponentProvider.java
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
A src/org/openbravo/retail/giftcards/master/GiftCardProductProperties.java
A web/org.openbravo.retail.giftcards/js/model/giftcardproductproperty.js
---
(0090187)
hgbot (developer)
2016-09-23 09:39

 Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 6db2fc9045d9094f7b07f5320138c5a7e3c64e2a
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Sep 22 17:57:08 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/6db2fc9045d9094f7b07f5320138c5a7e3c64e2a [^]

related to issue 33753 not necesary coalesce function

---
M src/org/openbravo/retail/giftcards/master/GiftCardProductProperties.java
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
---

- Issue History
Date Modified Username Field Change
2016-08-19 16:22 mtaal New Issue
2016-08-19 16:22 mtaal Assigned To => Sandrahuguet
2016-08-19 16:22 mtaal File Added: Selection_094.png
2016-08-19 16:22 mtaal OBNetwork customer => No
2016-08-19 16:22 mtaal Triggers an Emergency Pack => No
2016-08-19 16:23 mtaal Relationship added caused by 0033648
2016-09-14 10:34 shuehner Issue Monitored: shuehner
2016-09-14 13:15 Sandrahuguet Status new => scheduled
2016-09-15 09:19 hgbot Checkin
2016-09-15 09:19 hgbot Note Added: 0089963
2016-09-15 09:19 hgbot Status scheduled => resolved
2016-09-15 09:19 hgbot Resolution open => fixed
2016-09-15 09:19 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/f35a1a3f2647f15895cf417b23a01f8320356188 [^]
2016-09-15 09:23 Sandrahuguet Review Assigned To => marvintm
2016-09-15 09:37 Sandrahuguet Category StoreServer => Gift cards and gift vouchers
2016-09-15 12:58 Sandrahuguet Note Added: 0089979
2016-09-15 17:18 Sandrahuguet Status resolved => new
2016-09-15 17:18 Sandrahuguet Resolution fixed => open
2016-09-15 17:18 Sandrahuguet Status new => scheduled
2016-09-16 08:18 hgbot Checkin
2016-09-16 08:18 hgbot Note Added: 0090007
2016-09-16 08:18 hgbot Status scheduled => resolved
2016-09-16 08:18 hgbot Resolution open => fixed
2016-09-16 08:18 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/f35a1a3f2647f15895cf417b23a01f8320356188 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/1a09201a556b76c8a3bde19d974b8c6858db6b26 [^]
2016-09-19 09:21 Sandrahuguet Status resolved => new
2016-09-19 09:21 Sandrahuguet Resolution fixed => open
2016-09-19 16:13 Sandrahuguet Note Added: 0090066
2016-09-19 16:24 Sandrahuguet Status new => scheduled
2016-09-20 08:41 hgbot Checkin
2016-09-20 08:41 hgbot Note Added: 0090100
2016-09-20 08:41 hgbot Status scheduled => resolved
2016-09-20 08:41 hgbot Resolution open => fixed
2016-09-20 08:41 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/1a09201a556b76c8a3bde19d974b8c6858db6b26 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/6de0ece8301334b1a67f19567bdcc772b536705f [^]
2016-09-23 09:39 hgbot Checkin
2016-09-23 09:39 hgbot Note Added: 0090187
2016-09-30 13:18 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker