Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033753Retail ModulesGift cards and gift voucherspublic2016-08-19 16:222016-09-30 13:18
Reportermtaal 
Assigned ToSandrahuguet 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q4Fixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033753: In remote product mode 2 gift card requests are done when selecting a product
DescriptionWhen setting remote product mode then when selecting a product to be added to the ticket. A request is done to check if the product is a giftcard.

This request is done twice, it seems from this [1] line.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/file/8925341303dc/web/org.openbravo.retail.giftcards/js/components/lineproperties.js#l36 [^]
Steps To ReproduceInstall webpos with giftcards module
Set remote product pref to Y
Login and select products from search
See that when you select a product there are 2 requests to the gift card module
Proposed SolutionDo maximum one request to the server when selecting a product
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0033648 closed Sandrahuguet Remote for product preference should be added to giftcard model 
Attached Filespng Selection_094.png (197,336) 2016-08-19 16:22
https://issues.openbravo.com/file_download.php?file_id=9735&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2016-08-19 16:22mtaalNew Issue
2016-08-19 16:22mtaalAssigned To => Sandrahuguet
2016-08-19 16:22mtaalFile Added: Selection_094.png
2016-08-19 16:22mtaalOBNetwork customer => No
2016-08-19 16:22mtaalTriggers an Emergency Pack => No
2016-08-19 16:23mtaalRelationship addedcaused by 0033648
2016-09-14 10:34shuehnerIssue Monitored: shuehner
2016-09-14 13:15SandrahuguetStatusnew => scheduled
2016-09-15 09:19hgbotCheckin
2016-09-15 09:19hgbotNote Added: 0089963
2016-09-15 09:19hgbotStatusscheduled => resolved
2016-09-15 09:19hgbotResolutionopen => fixed
2016-09-15 09:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/f35a1a3f2647f15895cf417b23a01f8320356188 [^]
2016-09-15 09:23SandrahuguetReview Assigned To => marvintm
2016-09-15 09:37SandrahuguetCategoryStoreServer => Gift cards and gift vouchers
2016-09-15 12:58SandrahuguetNote Added: 0089979
2016-09-15 17:18SandrahuguetStatusresolved => new
2016-09-15 17:18SandrahuguetResolutionfixed => open
2016-09-15 17:18SandrahuguetStatusnew => scheduled
2016-09-16 08:18hgbotCheckin
2016-09-16 08:18hgbotNote Added: 0090007
2016-09-16 08:18hgbotStatusscheduled => resolved
2016-09-16 08:18hgbotResolutionopen => fixed
2016-09-16 08:18hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/f35a1a3f2647f15895cf417b23a01f8320356188 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/1a09201a556b76c8a3bde19d974b8c6858db6b26 [^]
2016-09-19 09:21SandrahuguetStatusresolved => new
2016-09-19 09:21SandrahuguetResolutionfixed => open
2016-09-19 16:13SandrahuguetNote Added: 0090066
2016-09-19 16:24SandrahuguetStatusnew => scheduled
2016-09-20 08:41hgbotCheckin
2016-09-20 08:41hgbotNote Added: 0090100
2016-09-20 08:41hgbotStatusscheduled => resolved
2016-09-20 08:41hgbotResolutionopen => fixed
2016-09-20 08:41hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/1a09201a556b76c8a3bde19d974b8c6858db6b26 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/6de0ece8301334b1a67f19567bdcc772b536705f [^]
2016-09-23 09:39hgbotCheckin
2016-09-23 09:39hgbotNote Added: 0090187
2016-09-30 13:18marvintmStatusresolved => closed

Notes
(0089963)
hgbot   
2016-09-15 09:19   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: f35a1a3f2647f15895cf417b23a01f8320356188
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Sep 15 09:17:45 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/f35a1a3f2647f15895cf417b23a01f8320356188 [^]

Fixed issue 33753 2 gift card requests are done when selecting a product

Added a new column(giftcard type) to product model to prevent 2 request
when selecting a product.

---
M src/org/openbravo/retail/giftcards/GCNVComponentProvider.java
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
A src/org/openbravo/retail/giftcards/master/GiftCardProductProperties.java
A web/org.openbravo.retail.giftcards/js/model/giftcardproductproperty.js
---
(0089979)
Sandrahuguet   
2016-09-15 12:58   
Backed out changeset f35a1a3f2647

https://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/186a12a917d9 [^]
(0090007)
hgbot   
2016-09-16 08:18   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 1a09201a556b76c8a3bde19d974b8c6858db6b26
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Sep 15 17:19:42 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/1a09201a556b76c8a3bde19d974b8c6858db6b26 [^]

Fixed issue 33753 2 gift card requests are done when selecting a product

Added a new column(giftcard type) to product model to prevent 2 request
when selecting a product.

---
M src/org/openbravo/retail/giftcards/GCNVComponentProvider.java
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
A src/org/openbravo/retail/giftcards/master/GiftCardProductProperties.java
A web/org.openbravo.retail.giftcards/js/model/giftcardproductproperty.js
---
(0090066)
Sandrahuguet   
2016-09-19 16:13   
Backed out changeset 1a09201a556b

https://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/026ee833fdc6 [^]
(0090100)
hgbot   
2016-09-20 08:41   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 6de0ece8301334b1a67f19567bdcc772b536705f
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon Sep 19 16:10:35 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/6de0ece8301334b1a67f19567bdcc772b536705f [^]

Fixed issue 33753 2 gift card requests are done when selecting a product

Added a new column(giftcard type) to product model to prevent 2 request
when selecting a product.

---
M src/org/openbravo/retail/giftcards/GCNVComponentProvider.java
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
A src/org/openbravo/retail/giftcards/master/GiftCardProductProperties.java
A web/org.openbravo.retail.giftcards/js/model/giftcardproductproperty.js
---
(0090187)
hgbot   
2016-09-23 09:39   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 6db2fc9045d9094f7b07f5320138c5a7e3c64e2a
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Sep 22 17:57:08 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/6db2fc9045d9094f7b07f5320138c5a7e3c64e2a [^]

related to issue 33753 not necesary coalesce function

---
M src/org/openbravo/retail/giftcards/master/GiftCardProductProperties.java
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
---