Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0033738

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2016-08-18 12:49

2016-08-31 11:27

Reporter

aaroncalero

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

high

Resolution

fixed

Fixed in Version

RR16Q4

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

guilleaer

OBNetwork customer

OBPS

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0033738: [SERQA 1604] Priorities are ignored when selecting a storage bin to deposit returned goods.

Description

When a return is created in web pos, the returned goods are placed in the warehouse set on the returned line.
The storage bin in which these goods are placed is selected as follows:
If the warehouse has a Return Bin defined, the goods are placed on that bin.
If not, then a random bin is selected to place the goods.

Steps To Reproduce

Verify that the function in charge of selecting the bin for returns:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/b160aade8e75/src/org/openbravo/retail/posterminal/POSUtils.java#l643 [^]
Gets the first bin it retrieves, without sorting:

[...]
       // We haven't found a warehouse with a return bin
       // We are going to select the bin with greater priority
       // of the warehouse of greater priority

       List<Locator> lstLocators = lstWarehouses.get(0).getLocatorList();
       if (lstLocators.size() > 0) {
         return lstLocators.get(0);
       } else {
         throw new OBException("Warehouse" + lstWarehouses.get(0) + " doesn't have bins");
       }
[...]

Proposed Solution

As the comment on the code states, it should be taking into account the bin priorities to select the fin for returns.
Instead of listing and retrieving the first bin directly, an OBCriteria should be done to sort the bins.

Tags

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

closed

ranjith_qualiantech_com

Sometimes, Returned goods are shipped to an inactive locator

Notes
(0089291) hgbot (developer) 2016-08-23 07:29	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 51660f59cd892e33e55fa2eb5b631d0f4d0c6694 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Tue Aug 23 10:59:19 2016 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/51660f59cd892e33e55fa2eb5b631d0f4d0c6694 [^] Fixes issue 33738 : Adding Criteria for return bin selection based on priority --- M src/org/openbravo/retail/posterminal/POSUtils.java ---

Issue History
Date Modified	Username	Field	Change
2016-08-18 12:49	aaroncalero	New Issue
2016-08-18 12:49	aaroncalero	Assigned To	=> Retail
2016-08-18 12:49	aaroncalero	OBNetwork customer	=> Yes
2016-08-18 12:49	aaroncalero	Resolution time	=> 1472680800
2016-08-18 12:49	aaroncalero	Triggers an Emergency Pack	=> No
2016-08-18 12:49	aaroncalero	Tag Attached: SER-QA
2016-08-22 10:39	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2016-08-22 10:39	ranjith_qualiantech_com	Status	new => scheduled
2016-08-23 07:29	hgbot	Checkin
2016-08-23 07:29	hgbot	Note Added: 0089291
2016-08-23 07:29	hgbot	Status	scheduled => resolved
2016-08-23 07:29	hgbot	Resolution	open => fixed
2016-08-23 07:29	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/51660f59cd892e33e55fa2eb5b631d0f4d0c6694 [^]
2016-08-23 13:48	ranjith_qualiantech_com	Relationship added	related to 0033755
2016-08-31 11:27	guilleaer	Review Assigned To	=> guilleaer
2016-08-31 11:27	guilleaer	Status	resolved => closed
2016-08-31 11:27	guilleaer	Fixed in Version	=> RR16Q4

Copyright © 2000 - 2009 MantisBT Group