0033738: [SERQA 1604] Priorities are ignored when selecting a storage bin to deposit returned goods.

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0033738

Retail Modules

Web POS

public

2016-08-18 12:49

2016-08-31 11:27

Reporter

aaroncalero

Assigned To

ranjith_qualiantech_com

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR16Q4

Merge Request Status

Review Assigned To

guilleaer

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0033738: [SERQA 1604] Priorities are ignored when selecting a storage bin to deposit returned goods.

Description

When a return is created in web pos, the returned goods are placed in the warehouse set on the returned line.
The storage bin in which these goods are placed is selected as follows:
If the warehouse has a Return Bin defined, the goods are placed on that bin.
If not, then a random bin is selected to place the goods.

Steps To Reproduce

Verify that the function in charge of selecting the bin for returns:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/b160aade8e75/src/org/openbravo/retail/posterminal/POSUtils.java#l643 [^]
Gets the first bin it retrieves, without sorting:

[...]
       // We haven't found a warehouse with a return bin
       // We are going to select the bin with greater priority
       // of the warehouse of greater priority

       List<Locator> lstLocators = lstWarehouses.get(0).getLocatorList();
       if (lstLocators.size() > 0) {
         return lstLocators.get(0);
       } else {
         throw new OBException("Warehouse" + lstWarehouses.get(0) + " doesn't have bins");
       }
[...]

Proposed Solution

As the comment on the code states, it should be taking into account the bin priorities to select the fin for returns.
Instead of listing and retrieving the first bin directly, an OBCriteria should be done to sort the bins.

Additional Information