Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033631
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-08-05 10:572016-09-01 09:57
ReportermarvintmView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision019979911040
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033631: Translation of date-picker related messages can break the Web POS login

DescriptionThere are two messages in the Web POS related to date-picker configuration, which can be translated although they contain configuration information. If they are translated to some values which are not valid, then the Web POS login stops working.
Steps To Reproduce- Translate the messages OBMOBC_Date_enyo_date_order or OBMOBC_Date_enyo_time_order to another system language.
- Log in the Web POS. Change the language to this language.
- Verify that the login doesn't work anymore.
Proposed SolutionThese messages should never have been created, as the information they contain is configuration information, and it doesn't make sense to translate them.

They can be modified so that in the case of the date, we compute the date format from the current OB.Format information, and in the case of the time, we hardcode to "hma" as this format is valid across the board always.
TagsNo tags attached.
Attached Filesdiff file icon date.diff [^] (4,276 bytes) 2016-08-05 10:57 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0089062)
hgbot (developer)
2016-08-12 06:59

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: e356310970749d73154ab325db6363e57527e946
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Aug 12 10:28:34 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e356310970749d73154ab325db6363e57527e946 [^]

Fixes issue 33631 : Removed AD Message used in date-time configuration

- Date-time Configuration value added in ad-message. Its inappropriate to put it under ad-message

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.mobile.core/source/component/ob-dateformat.js
---
(0089297)
Orekaria (viewer)
2016-08-23 13:43
edited on: 2016-08-25 09:39

 the 100 value:
- I guess is just a big random number to pass the first condition. I would add a message saying so (or whatever reason is it to be a 100)
- If the above is the reason, the value should be dateformat.length + 1

Tried some formats. At least is failing in this case:
- in a terminal, execute:
  OB.Format.date = "mm/yydd"
  new enyo.g11n.Fmts().getDateFieldOrder()

  result: "mdy" (correct answer should be myd)

The issue is missing any test
(0089389)
hgbot (developer)
2016-08-25 12:02

 Repository: tools/automation/pi-mobile
Changeset: b99b5a93b84a3ec77eed20290930b08a7e94f6ff
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Aug 25 15:32:04 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b99b5a93b84a3ec77eed20290930b08a7e94f6ff [^]

Verifies issue 33631 : Added automated test 'I33631_VerifyEnyoDateFieldOrder'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I33631_VerifyEnyoDateFieldOrder.java
---
(0089390)
hgbot (developer)
2016-08-25 12:02

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0199799110404c4f9f20c8bfd391f1ea1f55e890
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Aug 25 15:31:57 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0199799110404c4f9f20c8bfd391f1ea1f55e890 [^]

Fixes issue 33631 : Changed getDateFieldOrder in order to get enyo date format in ordered manner

---
M web/org.openbravo.mobile.core/source/component/ob-dateformat.js
---
(0089635)
migueldejuana (viewer)
2016-09-01 09:57

 Tested and reviewed

- Issue History
Date Modified Username Field Change
2016-08-05 10:57 marvintm New Issue
2016-08-05 10:57 marvintm Assigned To => Retail
2016-08-05 10:57 marvintm OBNetwork customer => No
2016-08-05 10:57 marvintm Triggers an Emergency Pack => No
2016-08-05 10:57 marvintm File Added: date.diff
2016-08-05 12:43 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2016-08-05 12:43 ranjith_qualiantech_com Status new => scheduled
2016-08-12 06:59 hgbot Checkin
2016-08-12 06:59 hgbot Note Added: 0089062
2016-08-12 06:59 hgbot Status scheduled => resolved
2016-08-12 06:59 hgbot Resolution open => fixed
2016-08-12 06:59 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e356310970749d73154ab325db6363e57527e946 [^]
2016-08-23 13:43 Orekaria Note Added: 0089297
2016-08-23 13:43 Orekaria Status resolved => new
2016-08-23 13:43 Orekaria Resolution fixed => open
2016-08-24 13:44 ranjith_qualiantech_com Status new => scheduled
2016-08-25 09:39 Orekaria Note Edited: 0089297 View Revisions
2016-08-25 12:02 hgbot Checkin
2016-08-25 12:02 hgbot Note Added: 0089389
2016-08-25 12:02 hgbot Checkin
2016-08-25 12:02 hgbot Note Added: 0089390
2016-08-25 12:02 hgbot Status scheduled => resolved
2016-08-25 12:02 hgbot Resolution open => fixed
2016-08-25 12:02 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e356310970749d73154ab325db6363e57527e946 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0199799110404c4f9f20c8bfd391f1ea1f55e890 [^]
2016-09-01 09:57 migueldejuana Review Assigned To => migueldejuana
2016-09-01 09:57 migueldejuana Note Added: 0089635
2016-09-01 09:57 migueldejuana Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker