Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033631Retail ModulesWeb POSpublic2016-08-05 10:572016-09-01 09:57
Reportermarvintm 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033631: Translation of date-picker related messages can break the Web POS login
DescriptionThere are two messages in the Web POS related to date-picker configuration, which can be translated although they contain configuration information. If they are translated to some values which are not valid, then the Web POS login stops working.
Steps To Reproduce- Translate the messages OBMOBC_Date_enyo_date_order or OBMOBC_Date_enyo_time_order to another system language.
- Log in the Web POS. Change the language to this language.
- Verify that the login doesn't work anymore.
Proposed SolutionThese messages should never have been created, as the information they contain is configuration information, and it doesn't make sense to translate them.

They can be modified so that in the case of the date, we compute the date format from the current OB.Format information, and in the case of the time, we hardcode to "hma" as this format is valid across the board always.
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff date.diff (4,276) 2016-08-05 10:57
https://issues.openbravo.com/file_download.php?file_id=9680&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-08-05 10:57marvintmNew Issue
2016-08-05 10:57marvintmAssigned To => Retail
2016-08-05 10:57marvintmOBNetwork customer => No
2016-08-05 10:57marvintmTriggers an Emergency Pack => No
2016-08-05 10:57marvintmFile Added: date.diff
2016-08-05 12:43ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-08-05 12:43ranjith_qualiantech_comStatusnew => scheduled
2016-08-12 06:59hgbotCheckin
2016-08-12 06:59hgbotNote Added: 0089062
2016-08-12 06:59hgbotStatusscheduled => resolved
2016-08-12 06:59hgbotResolutionopen => fixed
2016-08-12 06:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e356310970749d73154ab325db6363e57527e946 [^]
2016-08-23 13:43OrekariaNote Added: 0089297
2016-08-23 13:43OrekariaStatusresolved => new
2016-08-23 13:43OrekariaResolutionfixed => open
2016-08-24 13:44ranjith_qualiantech_comStatusnew => scheduled
2016-08-25 09:39OrekariaNote Edited: 0089297bug_revision_view_page.php?bugnote_id=0089297#r12904
2016-08-25 12:02hgbotCheckin
2016-08-25 12:02hgbotNote Added: 0089389
2016-08-25 12:02hgbotCheckin
2016-08-25 12:02hgbotNote Added: 0089390
2016-08-25 12:02hgbotStatusscheduled => resolved
2016-08-25 12:02hgbotResolutionopen => fixed
2016-08-25 12:02hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e356310970749d73154ab325db6363e57527e946 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0199799110404c4f9f20c8bfd391f1ea1f55e890 [^]
2016-09-01 09:57migueldejuanaReview Assigned To => migueldejuana
2016-09-01 09:57migueldejuanaNote Added: 0089635
2016-09-01 09:57migueldejuanaStatusresolved => closed

Notes
(0089062)
hgbot   
2016-08-12 06:59   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: e356310970749d73154ab325db6363e57527e946
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Aug 12 10:28:34 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e356310970749d73154ab325db6363e57527e946 [^]

Fixes issue 33631 : Removed AD Message used in date-time configuration

- Date-time Configuration value added in ad-message. Its inappropriate to put it under ad-message

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.mobile.core/source/component/ob-dateformat.js
---
(0089297)
Orekaria   
2016-08-23 13:43   
(edited on: 2016-08-25 09:39)
the 100 value:
- I guess is just a big random number to pass the first condition. I would add a message saying so (or whatever reason is it to be a 100)
- If the above is the reason, the value should be dateformat.length + 1

Tried some formats. At least is failing in this case:
- in a terminal, execute:
  OB.Format.date = "mm/yydd"
  new enyo.g11n.Fmts().getDateFieldOrder()

  result: "mdy" (correct answer should be myd)

The issue is missing any test
(0089389)
hgbot   
2016-08-25 12:02   
Repository: tools/automation/pi-mobile
Changeset: b99b5a93b84a3ec77eed20290930b08a7e94f6ff
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Aug 25 15:32:04 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b99b5a93b84a3ec77eed20290930b08a7e94f6ff [^]

Verifies issue 33631 : Added automated test 'I33631_VerifyEnyoDateFieldOrder'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I33631_VerifyEnyoDateFieldOrder.java
---
(0089390)
hgbot   
2016-08-25 12:02   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0199799110404c4f9f20c8bfd391f1ea1f55e890
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Aug 25 15:31:57 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0199799110404c4f9f20c8bfd391f1ea1f55e890 [^]

Fixes issue 33631 : Changed getDateFieldOrder in order to get enyo date format in ordered manner

---
M web/org.openbravo.mobile.core/source/component/ob-dateformat.js
---
(0089635)
migueldejuana   
2016-09-01 09:57   
Tested and reviewed