Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0033422 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | trivial | have not tried | 2016-07-05 10:20 | 2016-08-11 18:40 | |||
| Reporter | Sanjota | View Status | public | |||||
| Assigned To | Sanjota | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR16Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 9b517e1b61bc | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | vmromanos | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0033422: Static code analysis: triggers | |||||||
| Description | There are quite in pl-functions & -triggers which are never used. Those should be cleaned up. Note: found using static analysis using plpgsql_check https://github.com/okbob/plpgsql_check [^] | |||||||
| Steps To Reproduce | Run plpgsql_check_function on all functions + trigger And review output. | |||||||
| Proposed Solution | Delete the unused variables. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  remainingPLIssueList [^] (1,183 bytes) 2016-07-05 13:37 [Show Content]
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0088210) Sanjota (developer) 2016-07-05 13:36 |
Test Plan: - Run static analysis tool - plpgsql_check - Check for records and it's message. - Perform actions as per messages of each record. - Perform same above steps till no records exists.(Can exclude false positive records) Note: There were few false positive records. List for the same are as follows. 1. ad_get_preference_value() 2. ad_org_chk_doc_payments() 3. ad_org_chk_documents() 4. c_commission_process() 5. m_pricelist_create() Please find the attachment(remainingPLIssueList) for details |
|
(0088232) hgbot (developer) 2016-07-06 12:04 |
Repository: erp/devel/pi Changeset: 9b517e1b61bc45c6a8eec55c7c742404f775774f Author: Sanjota <sanjota.nelagi <at> promantia.com> Date: Tue Jul 05 16:02:56 2016 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/9b517e1b61bc45c6a8eec55c7c742404f775774f [^] Fixes issue 33422: Cleanup unused variables in pl-functions & triggers There are quite a few variables declared in in pl-functions & triggers which are never used, found using static analysis using plpgsql_check. Clean those variables --- M src-db/database/model/prescript-PostgreSql.sql M src-db/database/model/triggers/C_ACTIVITY_TRG.xml M src-db/database/model/triggers/C_BANKSTATEMENTLINE_TRG.xml M src-db/database/model/triggers/C_CASHLINE_TRG.xml M src-db/database/model/triggers/C_ELEMENTVALUE_TRG.xml M src-db/database/model/triggers/C_INVOICELINETAX_TRG.xml M src-db/database/model/triggers/C_INVOICELINE_BEFORE_TRG.xml M src-db/database/model/triggers/C_INVOICELINE_TRG.xml M src-db/database/model/triggers/C_INVOICE_REVERSE_TRG.xml M src-db/database/model/triggers/C_ORDERLINE_TRG.xml M src-db/database/model/triggers/C_ORDERTAX_TRG.xml M src-db/database/model/triggers/C_ORDER_CHK_RESTRINCTIONS_TRG.xml M src-db/database/model/triggers/C_PERIOD_TRG2.xml M src-db/database/model/triggers/C_REMITTANCELINE_TRG.xml M src-db/database/model/triggers/C_TAX_REPORT_TRG.xml M src-db/database/model/triggers/GL_JL_CHK_RESTRICTIONS_TRG.xml M src-db/database/model/triggers/M_ATTRIBUTEVALUE_TRG.xml M src-db/database/model/triggers/M_CH_VALUE_TRG.xml M src-db/database/model/triggers/M_CH_VALUE_TRG2.xml M src-db/database/model/triggers/M_COSTING_TRG.xml M src-db/database/model/triggers/M_PRODUCT_TRG.xml M src-db/database/model/triggers/M_RESERVATION_TRG.xml M src-db/database/model/triggers/M_TRANSACTION_TRG.xml M src-db/database/model/triggers/M_TRANSACTION_TRG2.xml M src-db/database/model/triggers/S_TIMEEXPENSE_TRG.xml --- |
|
(0088233) vmromanos (manager) 2016-07-06 12:07 |
Code review OK |
|
(0088991) hudsonbot (developer) 2016-08-11 18:40 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-07-05 10:20 | Sanjota | New Issue | |
| 2016-07-05 10:20 | Sanjota | Assigned To | => Sanjota |
| 2016-07-05 10:20 | Sanjota | Modules | => Core |
| 2016-07-05 10:20 | Sanjota | Triggers an Emergency Pack | => No |
| 2016-07-05 10:21 | Sanjota | Relationship added | related to 0027432 |
| 2016-07-05 12:41 | Sanjota | Status | new => scheduled |
| 2016-07-05 13:27 | Sanjota | Proposed Solution updated | |
| 2016-07-05 13:36 | Sanjota | Note Added: 0088210 | |
| 2016-07-05 13:37 | Sanjota | File Added: remainingPLIssueList | |
| 2016-07-06 12:04 | hgbot | Checkin | |
| 2016-07-06 12:04 | hgbot | Note Added: 0088232 | |
| 2016-07-06 12:04 | hgbot | Status | scheduled => resolved |
| 2016-07-06 12:04 | hgbot | Resolution | open => fixed |
| 2016-07-06 12:04 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/9b517e1b61bc45c6a8eec55c7c742404f775774f [^] |
| 2016-07-06 12:07 | vmromanos | Review Assigned To | => vmromanos |
| 2016-07-06 12:07 | vmromanos | Note Added: 0088233 | |
| 2016-07-06 12:07 | vmromanos | Status | resolved => closed |
| 2016-07-06 12:07 | vmromanos | Relationship added | related to 0030720 |
| 2016-07-06 12:08 | vmromanos | Fixed in Version | => 3.0PR16Q4 |
| 2016-08-11 18:40 | hudsonbot | Checkin | |
| 2016-08-11 18:40 | hudsonbot | Note Added: 0088991 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |