Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033422Openbravo ERPA. Platformpublic2016-07-05 10:202016-08-11 18:40
ReporterSanjota 
Assigned ToSanjota 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033422: Static code analysis: triggers
DescriptionThere are quite in pl-functions & -triggers which are never used.

Those should be cleaned up.

Note: found using static analysis using plpgsql_check
https://github.com/okbob/plpgsql_check [^]
Steps To ReproduceRun plpgsql_check_function on all functions + trigger
And review output.
Proposed SolutionDelete the unused variables.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0027432 closed Sanjota Cleanup unused variables in pl-functions & triggers 
related to defect 0030720 closed shuehner Cleanup unused variables in pl-functions & triggers (platform part) 
Attached Files? remainingPLIssueList (1,183) 2016-07-05 13:37
https://issues.openbravo.com/file_download.php?file_id=9611&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-07-05 10:20SanjotaNew Issue
2016-07-05 10:20SanjotaAssigned To => Sanjota
2016-07-05 10:20SanjotaModules => Core
2016-07-05 10:20SanjotaTriggers an Emergency Pack => No
2016-07-05 10:21SanjotaRelationship addedrelated to 0027432
2016-07-05 12:41SanjotaStatusnew => scheduled
2016-07-05 13:27SanjotaProposed Solution updated
2016-07-05 13:36SanjotaNote Added: 0088210
2016-07-05 13:37SanjotaFile Added: remainingPLIssueList
2016-07-06 12:04hgbotCheckin
2016-07-06 12:04hgbotNote Added: 0088232
2016-07-06 12:04hgbotStatusscheduled => resolved
2016-07-06 12:04hgbotResolutionopen => fixed
2016-07-06 12:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9b517e1b61bc45c6a8eec55c7c742404f775774f [^]
2016-07-06 12:07vmromanosReview Assigned To => vmromanos
2016-07-06 12:07vmromanosNote Added: 0088233
2016-07-06 12:07vmromanosStatusresolved => closed
2016-07-06 12:07vmromanosRelationship addedrelated to 0030720
2016-07-06 12:08vmromanosFixed in Version => 3.0PR16Q4
2016-08-11 18:40hudsonbotCheckin
2016-08-11 18:40hudsonbotNote Added: 0088991

Notes
(0088210)
Sanjota   
2016-07-05 13:36   
Test Plan:
- Run static analysis tool - plpgsql_check
- Check for records and it's message.
- Perform actions as per messages of each record.
- Perform same above steps till no records exists.(Can exclude false positive records)

Note: There were few false positive records. List for the same are as follows.
1. ad_get_preference_value()
2. ad_org_chk_doc_payments()
3. ad_org_chk_documents()
4. c_commission_process()
5. m_pricelist_create()
Please find the attachment(remainingPLIssueList) for details
(0088232)
hgbot   
2016-07-06 12:04   
Repository: erp/devel/pi
Changeset: 9b517e1b61bc45c6a8eec55c7c742404f775774f
Author: Sanjota <sanjota.nelagi <at> promantia.com>
Date: Tue Jul 05 16:02:56 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9b517e1b61bc45c6a8eec55c7c742404f775774f [^]

Fixes issue 33422: Cleanup unused variables in pl-functions & triggers

There are quite a few variables declared in in pl-functions & triggers which are never used, found using static analysis
using plpgsql_check. Clean those variables

---
M src-db/database/model/prescript-PostgreSql.sql
M src-db/database/model/triggers/C_ACTIVITY_TRG.xml
M src-db/database/model/triggers/C_BANKSTATEMENTLINE_TRG.xml
M src-db/database/model/triggers/C_CASHLINE_TRG.xml
M src-db/database/model/triggers/C_ELEMENTVALUE_TRG.xml
M src-db/database/model/triggers/C_INVOICELINETAX_TRG.xml
M src-db/database/model/triggers/C_INVOICELINE_BEFORE_TRG.xml
M src-db/database/model/triggers/C_INVOICELINE_TRG.xml
M src-db/database/model/triggers/C_INVOICE_REVERSE_TRG.xml
M src-db/database/model/triggers/C_ORDERLINE_TRG.xml
M src-db/database/model/triggers/C_ORDERTAX_TRG.xml
M src-db/database/model/triggers/C_ORDER_CHK_RESTRINCTIONS_TRG.xml
M src-db/database/model/triggers/C_PERIOD_TRG2.xml
M src-db/database/model/triggers/C_REMITTANCELINE_TRG.xml
M src-db/database/model/triggers/C_TAX_REPORT_TRG.xml
M src-db/database/model/triggers/GL_JL_CHK_RESTRICTIONS_TRG.xml
M src-db/database/model/triggers/M_ATTRIBUTEVALUE_TRG.xml
M src-db/database/model/triggers/M_CH_VALUE_TRG.xml
M src-db/database/model/triggers/M_CH_VALUE_TRG2.xml
M src-db/database/model/triggers/M_COSTING_TRG.xml
M src-db/database/model/triggers/M_PRODUCT_TRG.xml
M src-db/database/model/triggers/M_RESERVATION_TRG.xml
M src-db/database/model/triggers/M_TRANSACTION_TRG.xml
M src-db/database/model/triggers/M_TRANSACTION_TRG2.xml
M src-db/database/model/triggers/S_TIMEEXPENSE_TRG.xml
---
(0088233)
vmromanos   
2016-07-06 12:07   
Code review OK
(0088991)
hudsonbot   
2016-08-11 18:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test