Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0033219 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2016-06-10 18:01 | 2016-06-20 13:11 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR16Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 7b9f6cdbce15 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0033219: Avoid unnecessary cast from String to String in SqlC generated code | |||||||
| Description | When SqlC generates code to run callable statements it produces some extra casts which are not needed. Example: org.openbravo.erpCommon.ad_forms.AccountData method: GetValidAccountCombination Vector<String> vecTotal = new Vector<String>(); try { vecTotal = RDBMSIndependent.getCallableResult(conn, connectionProvider, strSql, parametersData, parametersTypes, 1); objectRespuestaCS.CValidCombinationId = (String) vecTotal.elementAt(0); as vecTotal is a Vector of String that cast to String is not needed. Searching all SqlC.java file for 'vecTotal' shows the definition to be always like that so the extra cast can be safely removed. | |||||||
| Steps To Reproduce | I.e. enable optional eclipse warnings 'unnecessary casts'. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0087180) hgbot (developer) 2016-06-10 19:03 |
Repository: erp/devel/pi Changeset: 7b9f6cdbce15830656b9e94636afd31a3dd9222a Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Fri Jun 10 19:02:58 2016 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/7b9f6cdbce15830656b9e94636afd31a3dd9222a [^] Fixed 33219. Avoid unnecessary cast in SqlC generated code. --- M src-core/src/org/openbravo/data/Sqlc.java --- |
|
(0087671) alostale (manager) 2016-06-20 13:11 |
code reviewed: the only modifications in generated sqlc code is the removal of these unnecessary castings. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-06-10 18:01 | shuehner | New Issue | |
| 2016-06-10 18:01 | shuehner | Assigned To | => shuehner |
| 2016-06-10 18:01 | shuehner | Modules | => Core |
| 2016-06-10 18:01 | shuehner | Triggers an Emergency Pack | => No |
| 2016-06-10 19:03 | hgbot | Checkin | |
| 2016-06-10 19:03 | hgbot | Note Added: 0087180 | |
| 2016-06-10 19:03 | hgbot | Status | new => resolved |
| 2016-06-10 19:03 | hgbot | Resolution | open => fixed |
| 2016-06-10 19:03 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/7b9f6cdbce15830656b9e94636afd31a3dd9222a [^] |
| 2016-06-10 19:04 | shuehner | Review Assigned To | => alostale |
| 2016-06-20 13:11 | alostale | Note Added: 0087671 | |
| 2016-06-20 13:11 | alostale | Status | resolved => closed |
| 2016-06-20 13:11 | alostale | Fixed in Version | => 3.0PR16Q3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |