Openbravo Issue Tracking System - Openbravo ERP | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0033219 | Openbravo ERP | A. Platform | public | 2016-06-10 18:01 | 2016-06-20 13:11 |
| Reporter | shuehner | ||||
| Assigned To | shuehner | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Platform | OS | 5 | OS Version | ||
| Product Version | |||||
| Target Version | Fixed in Version | 3.0PR16Q3 | |||
| Merge Request Status | |||||
| Review Assigned To | alostale | ||||
| OBNetwork customer | No | ||||
| Web browser | |||||
| Modules | Core | ||||
| Support ticket | |||||
| Regression level | |||||
| Regression date | |||||
| Regression introduced in release | |||||
| Regression introduced by commit | |||||
| Triggers an Emergency Pack | No | ||||
| Summary | 0033219: Avoid unnecessary cast from String to String in SqlC generated code | ||||
| Description | When SqlC generates code to run callable statements it produces some extra casts which are not needed. Example: org.openbravo.erpCommon.ad_forms.AccountData method: GetValidAccountCombination Vector<String> vecTotal = new Vector<String>(); try { vecTotal = RDBMSIndependent.getCallableResult(conn, connectionProvider, strSql, parametersData, parametersTypes, 1); objectRespuestaCS.CValidCombinationId = (String) vecTotal.elementAt(0); as vecTotal is a Vector of String that cast to String is not needed. Searching all SqlC.java file for 'vecTotal' shows the definition to be always like that so the extra cast can be safely removed. | ||||
| Steps To Reproduce | I.e. enable optional eclipse warnings 'unnecessary casts'. | ||||
| Proposed Solution | |||||
| Additional Information | |||||
| Tags | No tags attached. | ||||
| Relationships | |||||
| Attached Files | |||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2016-06-10 18:01 | shuehner | New Issue | |||
| 2016-06-10 18:01 | shuehner | Assigned To | => shuehner | ||
| 2016-06-10 18:01 | shuehner | OBNetwork customer | => No | ||
| 2016-06-10 18:01 | shuehner | Modules | => Core | ||
| 2016-06-10 18:01 | shuehner | Triggers an Emergency Pack | => No | ||
| 2016-06-10 19:03 | hgbot | Checkin | |||
| 2016-06-10 19:03 | hgbot | Note Added: 0087180 | |||
| 2016-06-10 19:03 | hgbot | Status | new => resolved | ||
| 2016-06-10 19:03 | hgbot | Resolution | open => fixed | ||
| 2016-06-10 19:03 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/7b9f6cdbce15830656b9e94636afd31a3dd9222a [^] | ||
| 2016-06-10 19:04 | shuehner | Review Assigned To | => alostale | ||
| 2016-06-20 13:11 | alostale | Note Added: 0087671 | |||
| 2016-06-20 13:11 | alostale | Status | resolved => closed | ||
| 2016-06-20 13:11 | alostale | Fixed in Version | => 3.0PR16Q3 | ||
| Notes | |||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||