Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0033210 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| design defect | [Openbravo ERP] 02. Master data management | minor | have not tried | 2016-06-09 17:45 | 2016-09-05 20:59 | |||
| Reporter | gorkaion | View Status | public | |||||
| Assigned To | gorkaion | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR16Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 992caa87c40b | ||||
| Projection | none | ETA | none | Target Version | pi | |||
| OS | Linux 32 bit | Database | Oracle | Java version | 1.5.0_15 | |||
| OS Version | Gentoo | Database version | 11g | Ant version | 1.7.0 | |||
| Product Version | SCM revision | |||||||
| Review Assigned To | aferraz | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0033210: VariantChDescUpdateProcess executed using ImportEntries instead of ProcessBundle | |||||||
| Description | When a characteristic value is updated or assigned to a product an EventHandler is executing the VariantChDescUpdateProcess to update the characteristic description field of the product. The event handler is using ProcessBundle and OBScheduler. These classes have some performance issues. Change the event handler to use Import Entries instead which perform better. | |||||||
| Steps To Reproduce | Create a product with some characteristics. Assign values and check that OBScheduler and ProcessBundle is used. | |||||||
| Proposed Solution | Use import entry and check that execution times improve. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||||||||||||||||
|
||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0089691) hgbot (developer) 2016-09-02 08:49 |
Repository: erp/devel/pi Changeset: 992caa87c40b1a96d5fb5bd39711e928b608b061 Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com> Date: Wed Aug 31 15:02:29 2016 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/992caa87c40b1a96d5fb5bd39711e928b608b061 [^] Fixed issue 33210.Related to issue 32950. Use import entry instead of ProcessBundle Performance fixes on EventHandler. - Use import entry instead of ProcessBundle. --- M src-db/database/sourcedata/AD_REF_LIST.xml M src/org/openbravo/event/ProductCharacteristicValueEventHandler.java A src/org/openbravo/materialmgmt/VariantChDescUpdateProcessor.java --- |
|
(0089709) hudsonbot (developer) 2016-09-02 14:28 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f7167eecae1 [^] Maturity status: Test |
|
(0089744) hgbot (developer) 2016-09-05 12:37 |
Repository: erp/devel/pi Changeset: 6c462af756e85df385b7a164d1b368563c0adb0a Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com> Date: Mon Sep 05 12:36:52 2016 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/6c462af756e85df385b7a164d1b368563c0adb0a [^] Related to issue 33210.Do not commit import entry creation. If the ImportEntry commits and close the session the AddProducts handler fails with a NPE when trying to close the session again. --- M src/org/openbravo/event/ProductCharacteristicValueEventHandler.java --- |
|
(0089754) aferraz (manager) 2016-09-05 13:21 |
Code review OK |
|
(0089764) hudsonbot (developer) 2016-09-05 20:59 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/87094da4670c [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-06-09 17:45 | gorkaion | New Issue | |
| 2016-06-09 17:45 | gorkaion | Assigned To | => gorkaion |
| 2016-06-09 17:45 | gorkaion | Modules | => Core |
| 2016-06-09 17:45 | gorkaion | Triggers an Emergency Pack | => No |
| 2016-08-19 12:19 | gorkaion | Relationship added | related to 0033750 |
| 2016-08-19 12:30 | gorkaion | Relationship deleted | related to 0033750 |
| 2016-08-19 12:30 | gorkaion | Relationship added | depends on 0033750 |
| 2016-08-31 13:21 | gorkaion | Relationship added | related to 0032950 |
| 2016-09-02 08:49 | hgbot | Checkin | |
| 2016-09-02 08:49 | hgbot | Note Added: 0089691 | |
| 2016-09-02 08:49 | hgbot | Status | new => resolved |
| 2016-09-02 08:49 | hgbot | Resolution | open => fixed |
| 2016-09-02 08:49 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/992caa87c40b1a96d5fb5bd39711e928b608b061 [^] |
| 2016-09-02 08:49 | gorkaion | Review Assigned To | => aferraz |
| 2016-09-02 14:28 | hudsonbot | Checkin | |
| 2016-09-02 14:28 | hudsonbot | Note Added: 0089709 | |
| 2016-09-05 12:37 | hgbot | Checkin | |
| 2016-09-05 12:37 | hgbot | Note Added: 0089744 | |
| 2016-09-05 13:21 | aferraz | Note Added: 0089754 | |
| 2016-09-05 13:21 | aferraz | Status | resolved => closed |
| 2016-09-05 13:21 | aferraz | Fixed in Version | => 3.0PR16Q4 |
| 2016-09-05 20:59 | hudsonbot | Checkin | |
| 2016-09-05 20:59 | hudsonbot | Note Added: 0089764 | |
| 2022-06-16 13:50 | igor_trebol | Relationship added | related to 0049524 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |