Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033210Openbravo ERP02. Master data managementpublic2016-06-09 17:452016-09-05 20:59
Reportergorkaion 
Assigned Togorkaion 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS20OS VersionGentoo
Product Version 
Target VersionpiFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033210: VariantChDescUpdateProcess executed using ImportEntries instead of ProcessBundle
DescriptionWhen a characteristic value is updated or assigned to a product an EventHandler is executing the VariantChDescUpdateProcess to update the characteristic description field of the product.

The event handler is using ProcessBundle and OBScheduler. These classes have some performance issues.

Change the event handler to use Import Entries instead which perform better.
Steps To ReproduceCreate a product with some characteristics. Assign values and check that OBScheduler and ProcessBundle is used.
Proposed SolutionUse import entry and check that execution times improve.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0032950pi closed gorkaion VariantChDescUpdateProcess executed several times for the same product 
depends on feature request 0033750 closed gorkaion Add API in SessionHandler to create new Transactions on active Session 
related to defect 0049524 closed igor_trebol ProductCharacteristicValueEventHandler creates and hold a lock on 100 products 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-09 17:45gorkaionNew Issue
2016-06-09 17:45gorkaionAssigned To => gorkaion
2016-06-09 17:45gorkaionModules => Core
2016-06-09 17:45gorkaionTriggers an Emergency Pack => No
2016-08-19 12:19gorkaionRelationship addedrelated to 0033750
2016-08-19 12:30gorkaionRelationship deletedrelated to 0033750
2016-08-19 12:30gorkaionRelationship addeddepends on 0033750
2016-08-31 13:21gorkaionRelationship addedrelated to 0032950
2016-09-02 08:49hgbotCheckin
2016-09-02 08:49hgbotNote Added: 0089691
2016-09-02 08:49hgbotStatusnew => resolved
2016-09-02 08:49hgbotResolutionopen => fixed
2016-09-02 08:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/992caa87c40b1a96d5fb5bd39711e928b608b061 [^]
2016-09-02 08:49gorkaionReview Assigned To => aferraz
2016-09-02 14:28hudsonbotCheckin
2016-09-02 14:28hudsonbotNote Added: 0089709
2016-09-05 12:37hgbotCheckin
2016-09-05 12:37hgbotNote Added: 0089744
2016-09-05 13:21aferrazNote Added: 0089754
2016-09-05 13:21aferrazStatusresolved => closed
2016-09-05 13:21aferrazFixed in Version => 3.0PR16Q4
2016-09-05 20:59hudsonbotCheckin
2016-09-05 20:59hudsonbotNote Added: 0089764
2022-06-16 13:50igor_trebolRelationship addedrelated to 0049524

Notes
(0089691)
hgbot   
2016-09-02 08:49   
Repository: erp/devel/pi
Changeset: 992caa87c40b1a96d5fb5bd39711e928b608b061
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Wed Aug 31 15:02:29 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/992caa87c40b1a96d5fb5bd39711e928b608b061 [^]

Fixed issue 33210.Related to issue 32950. Use import entry instead of ProcessBundle

Performance fixes on EventHandler.
- Use import entry instead of ProcessBundle.

---
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/event/ProductCharacteristicValueEventHandler.java
A src/org/openbravo/materialmgmt/VariantChDescUpdateProcessor.java
---
(0089709)
hudsonbot   
2016-09-02 14:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f7167eecae1 [^]
Maturity status: Test
(0089744)
hgbot   
2016-09-05 12:37   
Repository: erp/devel/pi
Changeset: 6c462af756e85df385b7a164d1b368563c0adb0a
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Mon Sep 05 12:36:52 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6c462af756e85df385b7a164d1b368563c0adb0a [^]

Related to issue 33210.Do not commit import entry creation.

If the ImportEntry commits and close the session the AddProducts handler fails
with a NPE when trying to close the session again.

---
M src/org/openbravo/event/ProductCharacteristicValueEventHandler.java
---
(0089754)
aferraz   
2016-09-05 13:21   
Code review OK
(0089764)
hudsonbot   
2016-09-05 20:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/87094da4670c [^]
Maturity status: Test