Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0033188 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Retail Modules] Web POS | minor | have not tried | 2016-06-08 08:49 | 2016-06-20 10:44 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 2d6801952b0b | ||||
| Projection | none | ETA | none | Target Version | RR16Q3 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | AugustoMauch | |||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0033188: Make default behavior of MobileKeyAuthenticationManager extendable | |||||||
| Description | The MobileKeyAuthenticationManager calls the super class if there are no token credentials included in the url: https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/89ae499ba562/src/org/openbravo/mobile/core/authenticate/MobileKeyAuthenticationManager.java#l54 [^] This call to the super class should be overrideable by subclass | |||||||
| Steps To Reproduce | See code here: https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/89ae499ba562/src/org/openbravo/mobile/core/authenticate/MobileKeyAuthenticationManager.java#l54 [^] | |||||||
| Proposed Solution | put the call to the super class in a separate protected method. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0087103) hgbot (developer) 2016-06-08 23:11 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 2d6801952b0b826c5e862d96b9f661f7ecd7fe6a Author: Martin Taal <martin.taal <at> openbravo.com> Date: Wed Jun 08 23:04:21 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2d6801952b0b826c5e862d96b9f661f7ecd7fe6a [^] Fixes issue 33188: Make default behavior of MobileKeyAuthenticationManager extendable Move super call to overrideable method --- M src/org/openbravo/mobile/core/authenticate/MobileKeyAuthenticationManager.java --- |
|
(0087654) AugustoMauch (administrator) 2016-06-20 10:44 |
Code reviewed and verified in [1]@2d6801952b0b [1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-06-08 08:49 | mtaal | New Issue | |
| 2016-06-08 08:49 | mtaal | Assigned To | => mtaal |
| 2016-06-08 08:49 | mtaal | OBNetwork customer | => No |
| 2016-06-08 08:49 | mtaal | Triggers an Emergency Pack | => No |
| 2016-06-08 23:11 | hgbot | Checkin | |
| 2016-06-08 23:11 | hgbot | Note Added: 0087103 | |
| 2016-06-08 23:11 | hgbot | Status | new => resolved |
| 2016-06-08 23:11 | hgbot | Resolution | open => fixed |
| 2016-06-08 23:11 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2d6801952b0b826c5e862d96b9f661f7ecd7fe6a [^] |
| 2016-06-13 14:06 | mtaal | Relationship added | blocks 0032251 |
| 2016-06-13 16:51 | mtaal | Review Assigned To | => AugustoMauch |
| 2016-06-20 10:44 | AugustoMauch | Note Added: 0087654 | |
| 2016-06-20 10:44 | AugustoMauch | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |