Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033188Retail ModulesWeb POSpublic2016-06-08 08:492016-06-20 10:44
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q3Fixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033188: Make default behavior of MobileKeyAuthenticationManager extendable
DescriptionThe MobileKeyAuthenticationManager calls the super class if there are no token credentials included in the url:
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/89ae499ba562/src/org/openbravo/mobile/core/authenticate/MobileKeyAuthenticationManager.java#l54 [^]

This call to the super class should be overrideable by subclass
Steps To ReproduceSee code here:
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/89ae499ba562/src/org/openbravo/mobile/core/authenticate/MobileKeyAuthenticationManager.java#l54 [^]
Proposed Solutionput the call to the super class in a separate protected method.
Additional Information
TagsNo tags attached.
Relationships
blocks feature request 0032251RR16Q4 closed mtaal Add Linux PAM Authentication Logic to Store Server Authentication 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-08 08:49mtaalNew Issue
2016-06-08 08:49mtaalAssigned To => mtaal
2016-06-08 08:49mtaalOBNetwork customer => No
2016-06-08 08:49mtaalTriggers an Emergency Pack => No
2016-06-08 23:11hgbotCheckin
2016-06-08 23:11hgbotNote Added: 0087103
2016-06-08 23:11hgbotStatusnew => resolved
2016-06-08 23:11hgbotResolutionopen => fixed
2016-06-08 23:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2d6801952b0b826c5e862d96b9f661f7ecd7fe6a [^]
2016-06-13 14:06mtaalRelationship addedblocks 0032251
2016-06-13 16:51mtaalReview Assigned To => AugustoMauch
2016-06-20 10:44AugustoMauchNote Added: 0087654
2016-06-20 10:44AugustoMauchStatusresolved => closed

Notes
(0087103)
hgbot   
2016-06-08 23:11   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 2d6801952b0b826c5e862d96b9f661f7ecd7fe6a
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jun 08 23:04:21 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2d6801952b0b826c5e862d96b9f661f7ecd7fe6a [^]

Fixes issue 33188: Make default behavior of MobileKeyAuthenticationManager extendable
Move super call to overrideable method

---
M src/org/openbravo/mobile/core/authenticate/MobileKeyAuthenticationManager.java
---
(0087654)
AugustoMauch   
2016-06-20 10:44   
Code reviewed and verified in [1]@2d6801952b0b

[1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core [^]