Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0033185 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | minor | have not tried | 2016-06-07 19:36 | 2016-06-20 10:31 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | f25be1d69dba | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | AugustoMauch | |||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0033185: Missing OBDal.getInstance().getProxy usage in new mobile.core.servercontroller code | |||||||
| Description | Some examples where Proxy should be used to not do extra db roundtrip for nothing 1.) MobileServerController.java importEntry.setOrganization(OBDal.getInstance().get(Organization.class, "0")); importEntry.setRole(OBDal.getInstance().get(Role.class, OBContext.getOBContext().getRole().getId())); 2* times in both sendMessage functions 2.) MobileServerRequestExecutor servers.setNamedParameter("org", OBDal.getInstance().get(Organization.class, parameters.getString("organization"))); | |||||||
| Steps To Reproduce | - | |||||||
| Proposed Solution | use getProxy( instead of just .get( to avoid initializing the object with a db read which is not required here. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0087171) hgbot (developer) 2016-06-10 15:43 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: f25be1d69dba8fa3d839af4bd2e4d088ad613e68 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Fri Jun 10 15:38:26 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f25be1d69dba8fa3d839af4bd2e4d088ad613e68 [^] Fixes issue 33185: Missing OBDal.getInstance().getProxy usage in new mobile.core.servercontroller code Use getProxy were relevant --- M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java --- |
|
(0087652) AugustoMauch (administrator) 2016-06-20 10:31 |
Code review and verified in [1]@f25be1d69dba [1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/ [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-06-07 19:36 | shuehner | New Issue | |
| 2016-06-07 19:36 | shuehner | Assigned To | => Retail |
| 2016-06-07 19:36 | shuehner | OBNetwork customer | => No |
| 2016-06-07 19:36 | shuehner | Triggers an Emergency Pack | => No |
| 2016-06-07 20:29 | shuehner | Summary | Missing Proxy usage in new mobile.core.servercontroller code => Missing OBDal.getInstance().getProxy usage in new mobile.core.servercontroller code |
| 2016-06-10 15:37 | mtaal | Assigned To | Retail => mtaal |
| 2016-06-10 15:38 | mtaal | Review Assigned To | => AugustoMauch |
| 2016-06-10 15:43 | hgbot | Checkin | |
| 2016-06-10 15:43 | hgbot | Note Added: 0087171 | |
| 2016-06-10 15:43 | hgbot | Status | new => resolved |
| 2016-06-10 15:43 | hgbot | Resolution | open => fixed |
| 2016-06-10 15:43 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f25be1d69dba8fa3d839af4bd2e4d088ad613e68 [^] |
| 2016-06-20 10:31 | AugustoMauch | Note Added: 0087652 | |
| 2016-06-20 10:31 | AugustoMauch | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |