Openbravo Issue Tracking System - Retail Modules | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0033185 | Retail Modules | Web POS | public | 2016-06-07 19:36 | 2016-06-20 10:31 |
| Reporter | shuehner | ||||
| Assigned To | mtaal | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Platform | OS | 5 | OS Version | ||
| Product Version | |||||
| Target Version | Fixed in Version | ||||
| Merge Request Status | |||||
| Review Assigned To | AugustoMauch | ||||
| OBNetwork customer | |||||
| Support ticket | |||||
| Regression level | |||||
| Regression date | |||||
| Regression introduced in release | |||||
| Regression introduced by commit | |||||
| Triggers an Emergency Pack | No | ||||
| Summary | 0033185: Missing OBDal.getInstance().getProxy usage in new mobile.core.servercontroller code | ||||
| Description | Some examples where Proxy should be used to not do extra db roundtrip for nothing 1.) MobileServerController.java importEntry.setOrganization(OBDal.getInstance().get(Organization.class, "0")); importEntry.setRole(OBDal.getInstance().get(Role.class, OBContext.getOBContext().getRole().getId())); 2* times in both sendMessage functions 2.) MobileServerRequestExecutor servers.setNamedParameter("org", OBDal.getInstance().get(Organization.class, parameters.getString("organization"))); | ||||
| Steps To Reproduce | - | ||||
| Proposed Solution | use getProxy( instead of just .get( to avoid initializing the object with a db read which is not required here. | ||||
| Additional Information | |||||
| Tags | No tags attached. | ||||
| Relationships | |||||
| Attached Files | |||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2016-06-07 19:36 | shuehner | New Issue | |||
| 2016-06-07 19:36 | shuehner | Assigned To | => Retail | ||
| 2016-06-07 19:36 | shuehner | Triggers an Emergency Pack | => No | ||
| 2016-06-07 20:29 | shuehner | Summary | Missing Proxy usage in new mobile.core.servercontroller code => Missing OBDal.getInstance().getProxy usage in new mobile.core.servercontroller code | ||
| 2016-06-10 15:37 | mtaal | Assigned To | Retail => mtaal | ||
| 2016-06-10 15:38 | mtaal | Review Assigned To | => AugustoMauch | ||
| 2016-06-10 15:43 | hgbot | Checkin | |||
| 2016-06-10 15:43 | hgbot | Note Added: 0087171 | |||
| 2016-06-10 15:43 | hgbot | Status | new => resolved | ||
| 2016-06-10 15:43 | hgbot | Resolution | open => fixed | ||
| 2016-06-10 15:43 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f25be1d69dba8fa3d839af4bd2e4d088ad613e68 [^] | ||
| 2016-06-20 10:31 | AugustoMauch | Note Added: 0087652 | |||
| 2016-06-20 10:31 | AugustoMauch | Status | resolved => closed | ||
| Notes | |||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||