0033180: OrderLoader.createShipment lines trigger read to m_product which should be avoided if possible

Description

              boolean useSingleBin = foundSingleBin != null && orderLine.getAttributeSetValue() == null
          && orderLine.getProduct().getAttributeSet() == null
          && orderLine.getWarehouseRule() == null
          && (DalUtil.getId(order.getWarehouse()).equals(DalUtil.getId(warehouse)));

This code triggers read of m_product via:
orderLine.getProduct().getAttributeSet()

That should be optimized away if that is possible.

a.) Move to end of the if-condition to only be used when all other previous parts evaluate to true
b.) Recheck if that condition is really required functionally.

Steps To Reproduce

Tags

Performance

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0102830) hgbot (developer) 2018-02-26 08:40	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 6810b8999be9cdcfc6fd9eee6803d8c6b9ade462 Author: Sandra Huguet <sandra.huguet <at> openbravo.com> Date: Wed Feb 07 17:51:53 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6810b8999be9cdcfc6fd9eee6803d8c6b9ade462 [^] Fixed issue 33180 Move getProduct().getAttributeSet() to last condition --- M src/org/openbravo/retail/posterminal/OrderLoader.java ---

Issue History
Date Modified	Username	Field	Change
2016-06-07 18:16	shuehner	New Issue
2016-06-07 18:16	shuehner	Assigned To	=> Retail
2016-06-07 18:16	shuehner	OBNetwork customer	=> No
2016-06-07 18:16	shuehner	Triggers an Emergency Pack	=> No
2016-06-07 18:16	shuehner	Tag Attached: Performance
2018-02-26 08:33	Sandrahuguet	Assigned To	Retail => Sandrahuguet
2018-02-26 08:40	hgbot	Checkin
2018-02-26 08:40	hgbot	Note Added: 0102830
2018-02-26 08:40	hgbot	Status	new => resolved
2018-02-26 08:40	hgbot	Resolution	open => fixed
2018-02-26 08:40	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6810b8999be9cdcfc6fd9eee6803d8c6b9ade462 [^]
2018-02-27 16:11	Sandrahuguet	Review Assigned To	=> marvintm
2018-02-28 18:23	marvintm	Status	resolved => closed
2018-02-28 18:23	marvintm	Fixed in Version	=> RR18Q2