Openbravo Issue Tracking System - Retail Modules | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0033180 | Retail Modules | Web POS | public | 2016-06-07 18:16 | 2018-02-28 18:23 |
| Reporter | shuehner | ||||
| Assigned To | Sandrahuguet | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Platform | OS | 5 | OS Version | ||
| Product Version | |||||
| Target Version | Fixed in Version | RR18Q2 | |||
| Merge Request Status | |||||
| Review Assigned To | marvintm | ||||
| OBNetwork customer | No | ||||
| Support ticket | |||||
| Regression level | |||||
| Regression date | |||||
| Regression introduced in release | |||||
| Regression introduced by commit | |||||
| Triggers an Emergency Pack | No | ||||
| Summary | 0033180: OrderLoader.createShipment lines trigger read to m_product which should be avoided if possible | ||||
| Description | boolean useSingleBin = foundSingleBin != null && orderLine.getAttributeSetValue() == null && orderLine.getProduct().getAttributeSet() == null && orderLine.getWarehouseRule() == null && (DalUtil.getId(order.getWarehouse()).equals(DalUtil.getId(warehouse))); This code triggers read of m_product via: orderLine.getProduct().getAttributeSet() That should be optimized away if that is possible. a.) Move to end of the if-condition to only be used when all other previous parts evaluate to true b.) Recheck if that condition is really required functionally. | ||||
| Steps To Reproduce | - | ||||
| Proposed Solution | |||||
| Additional Information | |||||
| Tags | Performance | ||||
| Relationships | |||||
| Attached Files | |||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2016-06-07 18:16 | shuehner | New Issue | |||
| 2016-06-07 18:16 | shuehner | Assigned To | => Retail | ||
| 2016-06-07 18:16 | shuehner | OBNetwork customer | => No | ||
| 2016-06-07 18:16 | shuehner | Triggers an Emergency Pack | => No | ||
| 2016-06-07 18:16 | shuehner | Tag Attached: Performance | |||
| 2018-02-26 08:33 | Sandrahuguet | Assigned To | Retail => Sandrahuguet | ||
| 2018-02-26 08:40 | hgbot | Checkin | |||
| 2018-02-26 08:40 | hgbot | Note Added: 0102830 | |||
| 2018-02-26 08:40 | hgbot | Status | new => resolved | ||
| 2018-02-26 08:40 | hgbot | Resolution | open => fixed | ||
| 2018-02-26 08:40 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6810b8999be9cdcfc6fd9eee6803d8c6b9ade462 [^] | ||
| 2018-02-27 16:11 | Sandrahuguet | Review Assigned To | => marvintm | ||
| 2018-02-28 18:23 | marvintm | Status | resolved => closed | ||
| 2018-02-28 18:23 | marvintm | Fixed in Version | => RR18Q2 | ||
| Notes | |||||
|
|
|||||
|
|
||||