Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033179
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2016-06-07 18:122017-11-30 09:46
ReportershuehnerView Statuspublic 
Assigned ToSandrahuguet 
PrioritynormalResolutionfixedFixed in VersionRR16Q4
StatusclosedFix in branchFixed in SCM revisionf5a8ef57d836
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033179: OrderLoader.getInvoicesRelatedToOrder skip this function if known that no invoices can exist

DescriptionThis function searches for invoices related to the order being processed.

that can only happen in very specific flow (i.e. layaways).
So some checks should be added before calling this function to avoid the SQL select if it is not required.
Steps To Reproduce-
TagsPerformance
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0031471 closedguilleaer Issue when paying in WEB POS a layaway that was invoiced in backend. The sales order is invoiced again. 

-  Notes
(0087074)
shuehner (administrator)
2016-06-07 18:14

 Also that function + its caller has several todo's + inefficient handling related to multiple invoices present.
That should be reviewed and fixed also.
(0089898)
hgbot (developer)
2016-09-12 13:40

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f5a8ef57d836dbb62b412ec746d4279a771dbabf
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed Sep 07 16:20:57 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f5a8ef57d836dbb62b412ec746d4279a771dbabf [^]

Fixed issue 33179 skip getInvoicesRelatedToOrder if not layaway

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---

- Issue History
Date Modified Username Field Change
2016-06-07 18:12 shuehner New Issue
2016-06-07 18:12 shuehner Assigned To => Retail
2016-06-07 18:12 shuehner OBNetwork customer => No
2016-06-07 18:12 shuehner Triggers an Emergency Pack => No
2016-06-07 18:12 shuehner Tag Attached: Performance
2016-06-07 18:13 shuehner Relationship added related to 0031471
2016-06-07 18:14 shuehner Note Added: 0087074
2016-08-18 10:37 shivum039 Assigned To Retail => shivum039
2016-08-18 10:37 shivum039 Status new => scheduled
2016-09-02 10:43 Orekaria Assigned To shivum039 => Retail
2016-09-02 13:03 Sandrahuguet Assigned To Retail => Sandrahuguet
2016-09-07 16:27 Sandrahuguet Review Assigned To => marvintm
2016-09-12 13:40 hgbot Checkin
2016-09-12 13:40 hgbot Note Added: 0089898
2016-09-12 13:40 hgbot Status scheduled => resolved
2016-09-12 13:40 hgbot Resolution open => fixed
2016-09-12 13:40 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f5a8ef57d836dbb62b412ec746d4279a771dbabf [^]
2016-09-29 13:24 marvintm Status resolved => closed
2017-11-30 09:46 shuehner Fixed in Version => RR16Q4

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker