Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033179Retail ModulesWeb POSpublic2016-06-07 18:122017-11-30 09:46
Reportershuehner 
Assigned ToSandrahuguet 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033179: OrderLoader.getInvoicesRelatedToOrder skip this function if known that no invoices can exist
DescriptionThis function searches for invoices related to the order being processed.

that can only happen in very specific flow (i.e. layaways).
So some checks should be added before calling this function to avoid the SQL select if it is not required.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 0031471 closed guilleaer Issue when paying in WEB POS a layaway that was invoiced in backend. The sales order is invoiced again. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-07 18:12shuehnerNew Issue
2016-06-07 18:12shuehnerAssigned To => Retail
2016-06-07 18:12shuehnerOBNetwork customer => No
2016-06-07 18:12shuehnerTriggers an Emergency Pack => No
2016-06-07 18:12shuehnerTag Attached: Performance
2016-06-07 18:13shuehnerRelationship addedrelated to 0031471
2016-06-07 18:14shuehnerNote Added: 0087074
2016-08-18 10:37shivum039Assigned ToRetail => shivum039
2016-08-18 10:37shivum039Statusnew => scheduled
2016-09-02 10:43OrekariaAssigned Toshivum039 => Retail
2016-09-02 13:03SandrahuguetAssigned ToRetail => Sandrahuguet
2016-09-07 16:27SandrahuguetReview Assigned To => marvintm
2016-09-12 13:40hgbotCheckin
2016-09-12 13:40hgbotNote Added: 0089898
2016-09-12 13:40hgbotStatusscheduled => resolved
2016-09-12 13:40hgbotResolutionopen => fixed
2016-09-12 13:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f5a8ef57d836dbb62b412ec746d4279a771dbabf [^]
2016-09-29 13:24marvintmStatusresolved => closed
2017-11-30 09:46shuehnerFixed in Version => RR16Q4

Notes
(0087074)
shuehner   
2016-06-07 18:14   
Also that function + its caller has several todo's + inefficient handling related to multiple invoices present.
That should be reviewed and fixed also.
(0089898)
hgbot   
2016-09-12 13:40   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f5a8ef57d836dbb62b412ec746d4279a771dbabf
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed Sep 07 16:20:57 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f5a8ef57d836dbb62b412ec746d4279a771dbabf [^]

Fixed issue 33179 skip getInvoicesRelatedToOrder if not layaway

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---