Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0033178 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | minor | have not tried | 2016-06-07 18:09 | 2018-03-19 09:43 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | Sandrahuguet | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR18Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 461eb39d1f40 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0033178: Service project related code in OrderLoader re-reads just created orderline | |||||||
| Description | The createLinesForServiceProduct method gets a hash-map of orderline_id's as input and then uses DAL to read those orderlines. However those lines have been just created 1 method before in the OrderLoader process so rereading those from database is most likely not required (could be i.e. passed down into this function). | |||||||
| Steps To Reproduce | if services is used: we get extra OrderLine reads via: createLinesForServicesProduct: OrderLine rol = OBDal.getInstance().get(OrderLine.class, relatedJsonOrderLine.get("orderlineId")); | |||||||
| Tags | Performance | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0103262) hgbot (developer) 2018-03-15 08:23 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 8b8a6e7d57f1a8c180b2d70cc4e4e5e1fc7d6db9 Author: Sandra Huguet <sandra.huguet <at> openbravo.com> Date: Wed Mar 14 13:03:10 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8b8a6e7d57f1a8c180b2d70cc4e4e5e1fc7d6db9 [^] fixed bug 33178 no re-reads related orderline in createLinesForServiceProduct --- M src/org/openbravo/retail/posterminal/OrderLoader.java --- |
|
(0103269) Sandrahuguet (developer) 2018-03-15 09:27 edited on: 2018-03-15 09:28 |
author Sandra Huguet <sandra.huguet@openbravo.com> Thu, 15 Mar 2018 09:21:56 +0100 changeset 9177 637a51e8db5c parent 9176 c7de1fc6b979 Backed out changeset 8b8a6e7d57f1 https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/637a51e8db5c [^] --- src/org/openbravo/retail/posterminal/OrderLoader.java |
|
(0103317) hgbot (developer) 2018-03-16 14:05 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 461eb39d1f40feeac0d2174acdf45571f03cb475 Author: Sandra Huguet <sandra.huguet <at> openbravo.com> Date: Fri Mar 16 09:39:47 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/461eb39d1f40feeac0d2174acdf45571f03cb475 [^] Fixed issue 33178 no re-reads related orderline in createLinesForServiceProduct --- M src/org/openbravo/retail/posterminal/OrderLoader.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-06-07 18:09 | shuehner | New Issue | |
| 2016-06-07 18:09 | shuehner | Assigned To | => Retail |
| 2016-06-07 18:09 | shuehner | Triggers an Emergency Pack | => No |
| 2016-06-07 18:09 | shuehner | Relationship added | related to 0033137 |
| 2016-06-07 18:10 | shuehner | Tag Attached: Performance | |
| 2018-03-14 13:14 | Sandrahuguet | Assigned To | Retail => Sandrahuguet |
| 2018-03-14 15:30 | Sandrahuguet | Review Assigned To | => marvintm |
| 2018-03-15 08:23 | hgbot | Checkin | |
| 2018-03-15 08:23 | hgbot | Note Added: 0103262 | |
| 2018-03-15 08:23 | hgbot | Status | new => resolved |
| 2018-03-15 08:23 | hgbot | Resolution | open => fixed |
| 2018-03-15 08:23 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8b8a6e7d57f1a8c180b2d70cc4e4e5e1fc7d6db9 [^] |
| 2018-03-15 09:27 | Sandrahuguet | Note Added: 0103269 | |
| 2018-03-15 09:28 | Sandrahuguet | Note Edited: 0103269 | View Revisions |
| 2018-03-15 09:28 | Sandrahuguet | Note Edited: 0103269 | View Revisions |
| 2018-03-16 10:01 | Sandrahuguet | Relationship added | depends on 0038156 |
| 2018-03-16 10:01 | Sandrahuguet | Status | resolved => new |
| 2018-03-16 10:01 | Sandrahuguet | Resolution | fixed => open |
| 2018-03-16 10:02 | Sandrahuguet | Status | new => scheduled |
| 2018-03-16 14:05 | hgbot | Checkin | |
| 2018-03-16 14:05 | hgbot | Note Added: 0103317 | |
| 2018-03-16 14:05 | hgbot | Status | scheduled => resolved |
| 2018-03-16 14:05 | hgbot | Resolution | open => fixed |
| 2018-03-16 14:05 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8b8a6e7d57f1a8c180b2d70cc4e4e5e1fc7d6db9 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/461eb39d1f40feeac0d2174acdf45571f03cb475 [^] |
| 2018-03-19 09:43 | marvintm | Status | resolved => closed |
| 2018-03-19 09:43 | marvintm | Fixed in Version | => RR18Q2 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |