Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033178Retail ModulesWeb POSpublic2016-06-07 18:092018-03-19 09:43
Reportershuehner 
Assigned ToSandrahuguet 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033178: Service project related code in OrderLoader re-reads just created orderline
DescriptionThe createLinesForServiceProduct method gets a hash-map of orderline_id's as input and then uses DAL to read those orderlines.

However those lines have been just created 1 method before in the OrderLoader process so rereading those from database is most likely not required (could be i.e. passed down into this function).
Steps To Reproduceif services is used: we get extra OrderLine reads via:

createLinesForServicesProduct:
OrderLine rol = OBDal.getInstance().get(OrderLine.class,
   relatedJsonOrderLine.get("orderlineId"));
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 0033137 closed shuehner Useless m_product read from services product even if services are not used 
depends on defect 0038156 closed Sandrahuguet API Change: Added new parameter to createLinesForServiceProduct 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-07 18:09shuehnerNew Issue
2016-06-07 18:09shuehnerAssigned To => Retail
2016-06-07 18:09shuehnerTriggers an Emergency Pack => No
2016-06-07 18:09shuehnerRelationship addedrelated to 0033137
2016-06-07 18:10shuehnerTag Attached: Performance
2018-03-14 13:14SandrahuguetAssigned ToRetail => Sandrahuguet
2018-03-14 15:30SandrahuguetReview Assigned To => marvintm
2018-03-15 08:23hgbotCheckin
2018-03-15 08:23hgbotNote Added: 0103262
2018-03-15 08:23hgbotStatusnew => resolved
2018-03-15 08:23hgbotResolutionopen => fixed
2018-03-15 08:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8b8a6e7d57f1a8c180b2d70cc4e4e5e1fc7d6db9 [^]
2018-03-15 09:27SandrahuguetNote Added: 0103269
2018-03-15 09:28SandrahuguetNote Edited: 0103269bug_revision_view_page.php?bugnote_id=0103269#r16852
2018-03-15 09:28SandrahuguetNote Edited: 0103269bug_revision_view_page.php?bugnote_id=0103269#r16853
2018-03-16 10:01SandrahuguetRelationship addeddepends on 0038156
2018-03-16 10:01SandrahuguetStatusresolved => new
2018-03-16 10:01SandrahuguetResolutionfixed => open
2018-03-16 10:02SandrahuguetStatusnew => scheduled
2018-03-16 14:05hgbotCheckin
2018-03-16 14:05hgbotNote Added: 0103317
2018-03-16 14:05hgbotStatusscheduled => resolved
2018-03-16 14:05hgbotResolutionopen => fixed
2018-03-16 14:05hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8b8a6e7d57f1a8c180b2d70cc4e4e5e1fc7d6db9 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/461eb39d1f40feeac0d2174acdf45571f03cb475 [^]
2018-03-19 09:43marvintmStatusresolved => closed
2018-03-19 09:43marvintmFixed in Version => RR18Q2

Notes
(0103262)
hgbot   
2018-03-15 08:23   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8b8a6e7d57f1a8c180b2d70cc4e4e5e1fc7d6db9
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed Mar 14 13:03:10 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8b8a6e7d57f1a8c180b2d70cc4e4e5e1fc7d6db9 [^]

fixed bug 33178 no re-reads related orderline in createLinesForServiceProduct

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0103269)
Sandrahuguet   
2018-03-15 09:27   
(edited on: 2018-03-15 09:28)
author Sandra Huguet <sandra.huguet@openbravo.com>
Thu, 15 Mar 2018 09:21:56 +0100
changeset 9177 637a51e8db5c
parent 9176 c7de1fc6b979
Backed out changeset 8b8a6e7d57f1
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/637a51e8db5c [^]

---
src/org/openbravo/retail/posterminal/OrderLoader.java
(0103317)
hgbot   
2018-03-16 14:05   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 461eb39d1f40feeac0d2174acdf45571f03cb475
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Fri Mar 16 09:39:47 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/461eb39d1f40feeac0d2174acdf45571f03cb475 [^]

Fixed issue 33178 no re-reads related orderline in createLinesForServiceProduct

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---