Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0033178 | Retail Modules | Web POS | public | 2016-06-07 18:09 | 2018-03-19 09:43 |
|
| Reporter | shuehner | |
| Assigned To | Sandrahuguet | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR18Q2 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | No |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0033178: Service project related code in OrderLoader re-reads just created orderline |
| Description | The createLinesForServiceProduct method gets a hash-map of orderline_id's as input and then uses DAL to read those orderlines.
However those lines have been just created 1 method before in the OrderLoader process so rereading those from database is most likely not required (could be i.e. passed down into this function).
|
| Steps To Reproduce | if services is used: we get extra OrderLine reads via:
createLinesForServicesProduct:
OrderLine rol = OBDal.getInstance().get(OrderLine.class,
relatedJsonOrderLine.get("orderlineId")); |
| Proposed Solution | |
| Additional Information | |
| Tags | Performance |
| Relationships | | related to | defect | 0033137 | | closed | shuehner | Useless m_product read from services product even if services are not used | | depends on | defect | 0038156 | | closed | Sandrahuguet | API Change: Added new parameter to createLinesForServiceProduct |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2016-06-07 18:09 | shuehner | New Issue | |
| 2016-06-07 18:09 | shuehner | Assigned To | => Retail |
| 2016-06-07 18:09 | shuehner | OBNetwork customer | => No |
| 2016-06-07 18:09 | shuehner | Triggers an Emergency Pack | => No |
| 2016-06-07 18:09 | shuehner | Relationship added | related to 0033137 |
| 2016-06-07 18:10 | shuehner | Tag Attached: Performance | |
| 2018-03-14 13:14 | Sandrahuguet | Assigned To | Retail => Sandrahuguet |
| 2018-03-14 15:30 | Sandrahuguet | Review Assigned To | => marvintm |
| 2018-03-15 08:23 | hgbot | Checkin | |
| 2018-03-15 08:23 | hgbot | Note Added: 0103262 | |
| 2018-03-15 08:23 | hgbot | Status | new => resolved |
| 2018-03-15 08:23 | hgbot | Resolution | open => fixed |
| 2018-03-15 08:23 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8b8a6e7d57f1a8c180b2d70cc4e4e5e1fc7d6db9 [^] |
| 2018-03-15 09:27 | Sandrahuguet | Note Added: 0103269 | |
| 2018-03-15 09:28 | Sandrahuguet | Note Edited: 0103269 | bug_revision_view_page.php?bugnote_id=0103269#r16852 |
| 2018-03-15 09:28 | Sandrahuguet | Note Edited: 0103269 | bug_revision_view_page.php?bugnote_id=0103269#r16853 |
| 2018-03-16 10:01 | Sandrahuguet | Relationship added | depends on 0038156 |
| 2018-03-16 10:01 | Sandrahuguet | Status | resolved => new |
| 2018-03-16 10:01 | Sandrahuguet | Resolution | fixed => open |
| 2018-03-16 10:02 | Sandrahuguet | Status | new => scheduled |
| 2018-03-16 14:05 | hgbot | Checkin | |
| 2018-03-16 14:05 | hgbot | Note Added: 0103317 | |
| 2018-03-16 14:05 | hgbot | Status | scheduled => resolved |
| 2018-03-16 14:05 | hgbot | Resolution | open => fixed |
| 2018-03-16 14:05 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8b8a6e7d57f1a8c180b2d70cc4e4e5e1fc7d6db9 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/461eb39d1f40feeac0d2174acdf45571f03cb475 [^] |
| 2018-03-19 09:43 | marvintm | Status | resolved => closed |
| 2018-03-19 09:43 | marvintm | Fixed in Version | => RR18Q2 |