Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0033167 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2016-06-07 11:52 | 2016-06-17 19:38 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR16Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 47723fdf90f2 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | caristu | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0033167: Apparently useless indirect flush in KernelApplicationInitializer.getDatabaseDateTime | |||||||
| Description | String now = DateTimeData.now(new DalConnectionProvider(), sqlDateTimeFormat); The () constructor for DalConnectionProvider should never be used as it triggers flush and it is often used by accident. The (boolean flush) form should always be used to indicate if a flush is required. If it is -> the reason should be documented with a comment. In this usecase here there seems to be no obvious reason to force a flush. That should be re-checked and fixed (either document or remove flush). | |||||||
| Steps To Reproduce | - | |||||||
| Tags | Performance | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0087326) hgbot (developer) 2016-06-16 09:30 |
Repository: erp/devel/pi Changeset: 47723fdf90f255440b76b8576ad3e267b8e717e6 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Thu Jun 16 09:28:41 2016 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/47723fdf90f255440b76b8576ad3e267b8e717e6 [^] fixed bug 33167: unneded flush in KernelApplicationInitializer.getDatabaseDateTime --- M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelApplicationInitializer.java --- |
|
(0087379) caristu (developer) 2016-06-17 09:18 |
Verified Reviewed in pi@a3288a6ce595 |
|
(0087624) hudsonbot (developer) 2016-06-17 19:38 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-06-07 11:52 | shuehner | New Issue | |
| 2016-06-07 11:52 | shuehner | Assigned To | => platform |
| 2016-06-07 11:52 | shuehner | Modules | => Core |
| 2016-06-07 11:52 | shuehner | Triggers an Emergency Pack | => No |
| 2016-06-16 09:16 | alostale | Tag Attached: Performance | |
| 2016-06-16 09:27 | alostale | Assigned To | platform => alostale |
| 2016-06-16 09:28 | alostale | Review Assigned To | => caristu |
| 2016-06-16 09:30 | hgbot | Checkin | |
| 2016-06-16 09:30 | hgbot | Note Added: 0087326 | |
| 2016-06-16 09:30 | hgbot | Status | new => resolved |
| 2016-06-16 09:30 | hgbot | Resolution | open => fixed |
| 2016-06-16 09:30 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/47723fdf90f255440b76b8576ad3e267b8e717e6 [^] |
| 2016-06-17 09:18 | caristu | Note Added: 0087379 | |
| 2016-06-17 09:18 | caristu | Status | resolved => closed |
| 2016-06-17 09:18 | caristu | Fixed in Version | => 3.0PR16Q3 |
| 2016-06-17 19:38 | hudsonbot | Checkin | |
| 2016-06-17 19:38 | hudsonbot | Note Added: 0087624 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |