Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0033167 | Openbravo ERP | A. Platform | public | 2016-06-07 11:52 | 2016-06-17 19:38 |
|
| Reporter | shuehner | |
| Assigned To | alostale | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0PR16Q3 | |
| Merge Request Status | |
| Review Assigned To | caristu |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0033167: Apparently useless indirect flush in KernelApplicationInitializer.getDatabaseDateTime |
| Description | String now = DateTimeData.now(new DalConnectionProvider(), sqlDateTimeFormat);
The () constructor for DalConnectionProvider should never be used as it triggers flush and it is often used by accident.
The (boolean flush) form should always be used to indicate if a flush is required.
If it is -> the reason should be documented with a comment.
In this usecase here there seems to be no obvious reason to force a flush.
That should be re-checked and fixed (either document or remove flush). |
| Steps To Reproduce | - |
| Proposed Solution | |
| Additional Information | |
| Tags | Performance |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2016-06-07 11:52 | shuehner | New Issue | |
| 2016-06-07 11:52 | shuehner | Assigned To | => platform |
| 2016-06-07 11:52 | shuehner | OBNetwork customer | => No |
| 2016-06-07 11:52 | shuehner | Modules | => Core |
| 2016-06-07 11:52 | shuehner | Triggers an Emergency Pack | => No |
| 2016-06-16 09:16 | alostale | Tag Attached: Performance | |
| 2016-06-16 09:27 | alostale | Assigned To | platform => alostale |
| 2016-06-16 09:28 | alostale | Review Assigned To | => caristu |
| 2016-06-16 09:30 | hgbot | Checkin | |
| 2016-06-16 09:30 | hgbot | Note Added: 0087326 | |
| 2016-06-16 09:30 | hgbot | Status | new => resolved |
| 2016-06-16 09:30 | hgbot | Resolution | open => fixed |
| 2016-06-16 09:30 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/47723fdf90f255440b76b8576ad3e267b8e717e6 [^] |
| 2016-06-17 09:18 | caristu | Note Added: 0087379 | |
| 2016-06-17 09:18 | caristu | Status | resolved => closed |
| 2016-06-17 09:18 | caristu | Fixed in Version | => 3.0PR16Q3 |
| 2016-06-17 19:38 | hudsonbot | Checkin | |
| 2016-06-17 19:38 | hudsonbot | Note Added: 0087624 | |