0033121: OrderLoader does extra update c_order for each c_order created

Description

OrderLoader code has a function called updateAuditInfo which after having inserted a new c_order (it was added in issue 22315)

Does and extra sql update to update the created + updated field with timestamp coming from the client.

However that causes it do need to do that 2nd db updated which is bad for performance:
a.) Double db action, bloat, etc...

If that created + updated modification is needed it should be done directly in the creation of the order.

Note: Issue 22315 adding that updateAuditInfo probably did this workaround because of bug or missing feature in DAL to allow that -> Maybe some change in platform is required for this as well.

Note: updateAuditInfo also does similar modification for invoice created in OrderLoader (optional) same fix should be applied for this as well.

Steps To Reproduce

trace OrderLoader.java code
or check all sql done by OrderLoader to find the extra update c_order statement

Tags

Performance

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

caused by

defect

0022315

RMP17

closed

marvintm

Creation date of the sales orders is not stored correctly if they are created in the Web POS

Notes
(0090043) hgbot (developer) 2016-09-19 08:38	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: b61897bd8ae06b7cb8756fbf7010051ce63ce59e Author: Sandra Huguet <sandra.huguet <at> openbravo.com> Date: Thu Sep 15 13:18:02 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b61897bd8ae06b7cb8756fbf7010051ce63ce59e [^] Fixed issue 33121 OrderLoader does extra update c_order for each c_order created --- M src/org/openbravo/retail/posterminal/OrderLoader.java ---

Issue History
Date Modified	Username	Field	Change
2016-06-02 18:13	shuehner	New Issue
2016-06-02 18:13	shuehner	Assigned To	=> Retail
2016-06-02 18:13	shuehner	Triggers an Emergency Pack	=> No
2016-06-02 18:13	shuehner	Tag Attached: Performance
2016-06-02 18:13	shuehner	Relationship added	caused by 0022315
2016-09-02 10:38	Sandrahuguet	Assigned To	Retail => Sandrahuguet
2016-09-02 13:27	Sandrahuguet	Status	new => scheduled
2016-09-19 08:38	hgbot	Checkin
2016-09-19 08:38	hgbot	Note Added: 0090043
2016-09-19 08:38	hgbot	Status	scheduled => resolved
2016-09-19 08:38	hgbot	Resolution	open => fixed
2016-09-19 08:38	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b61897bd8ae06b7cb8756fbf7010051ce63ce59e [^]
2016-09-19 08:43	Sandrahuguet	Review Assigned To	=> marvintm
2016-09-29 16:15	marvintm	Status	resolved => closed