Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033121Retail ModulesWeb POSpublic2016-06-02 18:132016-09-29 16:15
Reportershuehner 
Assigned ToSandrahuguet 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033121: OrderLoader does extra update c_order for each c_order created
DescriptionOrderLoader code has a function called updateAuditInfo which after having inserted a new c_order (it was added in issue 22315)

Does and extra sql update to update the created + updated field with timestamp coming from the client.

However that causes it do need to do that 2nd db updated which is bad for performance:
a.) Double db action, bloat, etc...

If that created + updated modification is needed it should be done directly in the creation of the order.

Note: Issue 22315 adding that updateAuditInfo probably did this workaround because of bug or missing feature in DAL to allow that -> Maybe some change in platform is required for this as well.

Note: updateAuditInfo also does similar modification for invoice created in OrderLoader (optional) same fix should be applied for this as well.
Steps To Reproducetrace OrderLoader.java code
or check all sql done by OrderLoader to find the extra update c_order statement
Proposed Solution
Additional Information
TagsPerformance
Relationships
caused by defect 0022315RMP17 closed marvintm Creation date of the sales orders is not stored correctly if they are created in the Web POS 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-02 18:13shuehnerNew Issue
2016-06-02 18:13shuehnerAssigned To => Retail
2016-06-02 18:13shuehnerOBNetwork customer => No
2016-06-02 18:13shuehnerTriggers an Emergency Pack => No
2016-06-02 18:13shuehnerTag Attached: Performance
2016-06-02 18:13shuehnerRelationship addedcaused by 0022315
2016-09-02 10:38SandrahuguetAssigned ToRetail => Sandrahuguet
2016-09-02 13:27SandrahuguetStatusnew => scheduled
2016-09-19 08:38hgbotCheckin
2016-09-19 08:38hgbotNote Added: 0090043
2016-09-19 08:38hgbotStatusscheduled => resolved
2016-09-19 08:38hgbotResolutionopen => fixed
2016-09-19 08:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b61897bd8ae06b7cb8756fbf7010051ce63ce59e [^]
2016-09-19 08:43SandrahuguetReview Assigned To => marvintm
2016-09-29 16:15marvintmStatusresolved => closed

Notes
(0090043)
hgbot   
2016-09-19 08:38   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b61897bd8ae06b7cb8756fbf7010051ce63ce59e
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Sep 15 13:18:02 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b61897bd8ae06b7cb8756fbf7010051ce63ce59e [^]

Fixed issue 33121 OrderLoader does extra update c_order for each c_order created

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---