Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0033071 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Discounts and Promotions | trivial | have not tried | 2016-05-27 13:49 | 2016-06-15 19:15 | |||
Reporter | shuehner | View Status | public | |||||
Assigned To | mario_castello | |||||||
Priority | low | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | 5e621ca6ac8e | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | marvintm | |||||||
OBNetwork customer | No | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0033071: Unused variables in pl code | |||||||
Description | This module has 2 pl functions + 1 trigger declaring some variable but never using it. | |||||||
Steps To Reproduce | - | |||||||
Proposed Solution | Delete the unused variables. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() | |||||||
![]() |
|
![]() |
|
(0086786) shuehner (administrator) 2016-05-27 13:49 |
Note: When checking code careful pl is case-insensitive. So when checking for users of the variable search without checking case for its name. |
(0086787) shuehner (administrator) 2016-05-27 13:50 |
The attached patch also deletes some commented code in OBDISC_XY_GIFT function which did reference the unused variable. I |
(0087067) hgbot (developer) 2016-06-07 16:25 |
Repository: erp/pmods/org.openbravo.retail.discounts Changeset: 5e621ca6ac8e63fb8c5426c5873042d01d344705 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Fri Jun 03 14:48:13 2016 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/5e621ca6ac8e63fb8c5426c5873042d01d344705 [^] Fixed issue 33071: Delete unused variables in pl code --- M src-db/database/model/functions/OBDISC_PACK.xml M src-db/database/model/functions/OBDISC_XY_GIFT.xml M src-db/database/model/triggers/OBDISC_OFFER_TRG.xml --- |
![]() |
|||
Date Modified | Username | Field | Change |
2016-05-27 13:49 | shuehner | New Issue | |
2016-05-27 13:49 | shuehner | Assigned To | => Retail |
2016-05-27 13:49 | shuehner | OBNetwork customer | => No |
2016-05-27 13:49 | shuehner | Triggers an Emergency Pack | => No |
2016-05-27 13:49 | shuehner | File Added: 33071.diff | |
2016-05-27 13:49 | shuehner | Note Added: 0086786 | |
2016-05-27 13:50 | shuehner | Note Added: 0086787 | |
2016-06-02 17:49 | Orekaria | Status | new => acknowledged |
2016-06-03 23:06 | mario_castello | Assigned To | Retail => mario_castello |
2016-06-07 16:25 | hgbot | Checkin | |
2016-06-07 16:25 | hgbot | Note Added: 0087067 | |
2016-06-07 16:25 | hgbot | Status | acknowledged => resolved |
2016-06-07 16:25 | hgbot | Resolution | open => fixed |
2016-06-07 16:25 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/5e621ca6ac8e63fb8c5426c5873042d01d344705 [^] |
2016-06-15 19:15 | marvintm | Review Assigned To | => marvintm |
2016-06-15 19:15 | marvintm | Status | resolved => closed |
Copyright © 2000 - 2009 MantisBT Group |