Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033071Retail ModulesDiscounts and Promotionspublic2016-05-27 13:492016-06-15 19:15
Reportershuehner 
Assigned Tomario_castello 
PrioritylowSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033071: Unused variables in pl code
DescriptionThis module has 2 pl functions + 1 trigger declaring some variable but never using it.

Steps To Reproduce-
Proposed SolutionDelete the unused variables.
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 33071.diff (1,882) 2016-05-27 13:49
https://issues.openbravo.com/file_download.php?file_id=9447&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-05-27 13:49shuehnerNew Issue
2016-05-27 13:49shuehnerAssigned To => Retail
2016-05-27 13:49shuehnerOBNetwork customer => No
2016-05-27 13:49shuehnerTriggers an Emergency Pack => No
2016-05-27 13:49shuehnerFile Added: 33071.diff
2016-05-27 13:49shuehnerNote Added: 0086786
2016-05-27 13:50shuehnerNote Added: 0086787
2016-06-02 17:49OrekariaStatusnew => acknowledged
2016-06-03 23:06mario_castelloAssigned ToRetail => mario_castello
2016-06-07 16:25hgbotCheckin
2016-06-07 16:25hgbotNote Added: 0087067
2016-06-07 16:25hgbotStatusacknowledged => resolved
2016-06-07 16:25hgbotResolutionopen => fixed
2016-06-07 16:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/5e621ca6ac8e63fb8c5426c5873042d01d344705 [^]
2016-06-15 19:15marvintmReview Assigned To => marvintm
2016-06-15 19:15marvintmStatusresolved => closed

Notes
(0086786)
shuehner   
2016-05-27 13:49   
Note: When checking code careful pl is case-insensitive. So when checking for users of the variable search without checking case for its name.
(0086787)
shuehner   
2016-05-27 13:50   
The attached patch also deletes some commented code in OBDISC_XY_GIFT function which did reference the unused variable.

I
(0087067)
hgbot   
2016-06-07 16:25   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 5e621ca6ac8e63fb8c5426c5873042d01d344705
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Jun 03 14:48:13 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/5e621ca6ac8e63fb8c5426c5873042d01d344705 [^]

Fixed issue 33071: Delete unused variables in pl code

---
M src-db/database/model/functions/OBDISC_PACK.xml
M src-db/database/model/functions/OBDISC_XY_GIFT.xml
M src-db/database/model/triggers/OBDISC_OFFER_TRG.xml
---