0032981: [SER QA 1115] Using Multiple Line Selection feature appear ugly error js

# HG changeset patch
# User Ranjith S R <ranjith@qualiantech.com>
# Date 1464004078 -19800
#      Mon May 23 17:17:58 2016 +0530
# Node ID d1756187ec7b58f9de5e6f82dce14ba65af7554c
# Parent  991d1a40c7162d27c19049e53af198172b0141fe
Related to issue 32981 : Validating Line Selection hooks for single/multi line selection

diff -r 991d1a40c716 -r d1756187ec7b web/org.openbravo.retail.giftcards/js/components/lineproperties.js
--- a/web/org.openbravo.retail.giftcards/js/components/lineproperties.js	Mon May 09 13:14:19 2016 +0200
+++ b/web/org.openbravo.retail.giftcards/js/components/lineproperties.js	Mon May 23 17:17:58 2016 +0530
@@ -1,6 +1,6 @@
 /*
  ************************************************************************************
- * Copyright (C) 2012-2015 Openbravo S.L.U.
+ * Copyright (C) 2012-2016 Openbravo S.L.U.
  * Licensed under the Openbravo Commercial License version 1.0
  * You may obtain a copy of the License at http://www.openbravo.com/legal/obcl.html
  * or in the legal folder of this module distribution.
@@ -160,8 +160,15 @@
 
   });
   OB.UTIL.HookManager.registerHook('OBPOS_LineSelected', function (args, callbacks) {
-    if (args.product.get('giftCardTransaction')) {
-      // The product is a gift card
+    var hasGiftCard = false;
+    if (args.line && args.line.get('product').get('giftCardTransaction')) {
+      hasGiftCard = true;
+    } else if (args.selectedLines && args.selectedLines.length > 0) {
+      hasGiftCard = _.filter(args.selectedLines, function (line) {
+        return line.get('product').get('giftCardTransaction');
+      }).length > 0;
+    }
+    if (hasGiftCard) {
       args.context.waterfall('onHideReturnLineButton', {
         hide: true
       });
@@ -169,4 +176,4 @@
     OB.UTIL.HookManager.callbackExecutor(args, callbacks);
   });
 
-}());
+}());
\ No newline at end of file

# HG changeset patch
# User Ranjith S R <ranjith@qualiantech.com>
# Date 1464003865 -19800
#      Mon May 23 17:14:25 2016 +0530
# Node ID bb23f4e3193bdcec821b3f87fc7c7e7517f1eee4
# Parent  93a680109b07cdc596ee0e35218be7e84259f8d1
Related to issue 32981 : Replaced product with line in "OBPOS_LineSelected" hook

Added "selectedLines" as arg in "OBPOS_LineSelected" hook

diff -r 93a680109b07 -r bb23f4e3193b web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js	Mon May 23 14:30:02 2016 +0530
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js	Mon May 23 17:14:25 2016 +0530
@@ -796,7 +796,7 @@
       if (lineSelected) {
         me.selectedListener(lineSelected);
         me.doReceiptLineSelected({
-          product: lineSelected.get('product')
+          line: lineSelected
         });
       }
     }, this);
diff -r 93a680109b07 -r bb23f4e3193b web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js	Mon May 23 14:30:02 2016 +0530
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js	Mon May 23 17:14:25 2016 +0530
@@ -1245,7 +1245,8 @@
     }
     this.enableKeyboardButton(enableButton);
     OB.UTIL.HookManager.executeHooks('OBPOS_LineSelected', {
-      product: inEvent.product,
+      line: inEvent.line,
+      selectedLines: selectedLines,
       context: this
     }, function (args) {});
   },

# HG changeset patch
# User Ranjith S R <ranjith@qualiantech.com>
# Date 1464003871 -19800
#      Mon May 23 17:14:31 2016 +0530
# Node ID f51cfbe4c2026ac54e404fe937883ebb057cd043
# Parent  ae583afa8771f52314a3cb7e1e704b90215cf109
Verifies issue 32981 : Added automated test 'I32981_VerifyGiftCardLineSelection'

diff -r ae583afa8771 -r f51cfbe4c202 src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
--- a/src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java	Mon May 23 11:17:45 2016 +0200
+++ b/src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java	Mon May 23 17:14:31 2016 +0530
@@ -1072,6 +1072,7 @@
       EnyoKind.PRODUCT), //
   BUTTON_SEARCHPRODUCT_BACKPACKSANDTRAVEL_BABYCARRIER_SHOWPRODSK("WVG/B0004 - Baby carrier",
       EnyoKind.SEARCHPRODUCT), //
+  BUTTON_PRODUCT_GIFTCARD_INFINITE("WVG/GC0001 - Gift Card Infinite", EnyoKind.PRODUCT), //
 
   // Training mode module
   BUTTON_MENU_TRAININGMODE("menuScroller_switchTMMenu", EnyoKind.BUTTON), //
diff -r ae583afa8771 -r f51cfbe4c202 src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I32981_VerifyGiftCardLineSelection.java
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I32981_VerifyGiftCardLineSelection.java	Mon May 23 17:14:31 2016 +0530
@@ -0,0 +1,69 @@
+/*
+ *************************************************************************
+ * The contents of this file are subject to the Openbravo  Public  License
+ * Version  1.0  (the  "License"),  being   the  Mozilla   Public  License
+ * Version 1.1  with a permitted attribution clause; you may not  use this
+ * file except in compliance with the License. You  may  obtain  a copy of
+ * the License at http://www.openbravo.com/legal/license.html
+ * Software distributed under the License  is  distributed  on  an "AS IS"
+ * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See the
+ * License for the specific  language  governing  rights  and  limitations
+ * under the License.
+ * The Original Code is Openbravo ERP.
+ * The Initial Developer of the Original Code is Openbravo S.L.U.
+ * All portions are Copyright (C) 2016 Openbravo S.L.U.
+ * All Rights Reserved.
+ * Contributor(s):
+ ************************************************************************
+ *
+ * @author RAN
+ *
+ */
+
+package org.openbravo.test.mobile.retail.extmodules.selenium.tests.giftcards;
+
+import org.junit.Test;
+import org.openbravo.test.mobile.common.selenium.javascript.TestId;
+import org.openbravo.test.mobile.common.selenium.terminals.WebPOSExtModulesTerminalHelper;
+
+public class I32981_VerifyGiftCardLineSelection extends WebPOSExtModulesTerminalHelper {
+
+  @Test
+  public void test() {
+    // Add Product
+    write(TestId.FIELD_SEARCH_TEXT, "Adhesive body warmers");
+    tap(TestId.BUTTON_SEARCH_EXECUTE);
+    tap(TestId.BUTTON_SEARCHPRODUCT_FIRSTROW);
+
+    // Add Product
+    tap(TestId.BUTTON_SEARCH);
+    write(TestId.FIELD_SEARCH_TEXT, "baby carrier");
+    tap(TestId.BUTTON_SEARCH_EXECUTE);
+    tap(TestId.BUTTON_SEARCHPRODUCT_FIRSTROW);
+
+    // Pay with Gift Card
+    tap(TestId.BUTTON_PAY);
+    tap(TestId.BUTTON_MORE_PAYMENTS_DIV);
+    isVisible(TestId.POPUP_PAYMENTMETHOD, true);
+    TestId.BUTTON_PAYMENT_GIFTCARD.enyoNode().waitUntilIsReady(100);
+    tap(TestId.BUTTON_PAYMENT_GIFTCARD);
+    tap(TestId.BUTTON_PAY_EXACT);
+    write(TestId.FIELD_GIFTCARDPAYMENT_CARDID, "TestGC0001");
+    tap(TestId.BUTTON_GIFTCARDPAYMENT_APPLY);
+    verify(TestId.LABEL_TOTALTOPAY, "0.00");
+
+    // Select all lines
+    tap(TestId.TABLE_RECEIPTLINES,
+        TestId.BUTTON_PRODUCT_BESTSELLERS_ADHESIVEBODYWARNMERS_BEST.getRowName());
+    tap(TestId.BUTTON_MULTISELECTION_BTN_SINGLESELECTION);
+    tap(TestId.TABLE_RECEIPTLINES,
+        TestId.BUTTON_PRODUCT_BACKPACKSANDTRAVEL_BABYCARRIER_SHOWPRODSK.getRowName());
+    tap(TestId.BUTTON_MULTISELECTION_BTN_SINGLESELECTION);
+    tap(TestId.TABLE_RECEIPTLINES, TestId.BUTTON_PRODUCT_GIFTCARD_INFINITE.getRowName());
+
+    isVisible(TestId.BUTTON_EDIT_RETURNLINE, false);
+
+    tap(TestId.BUTTON_DELETERECEIPT);
+    tap(TestId.BUTTON_DELETERECEIPT_CONFIRM);
+  }
+}
\ No newline at end of file