Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032981Retail ModulesGift cards and gift voucherspublic2016-05-17 19:292016-06-06 11:12
ReporterOsmany 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032981: [SER QA 1115] Using Multiple Line Selection feature appear ugly error js
DescriptionUsing Multiple Line Selection feature appear ugly error js.
This issue happens only with the Gift Card module installed.
Steps To Reproduce1. Login WebPOS
2. Add two products
3. Select both lines using Multiple Line Selection feature.
4. Appear an ugly error js.
Proposed Solution
Additional Information
TagsSER-QA
Relationships
related to defect 0032721 closed shivum039 [MULTISELECTION] Select All button for multiselect lines is not executing receiptLineSelected 
depends on backport 0033146RR16Q2 closed ranjith_qualiantech_com [SER QA 1115] Using Multiple Line Selection feature appear ugly error js 
depends on backport 0033147RR16Q1.3 closed ranjith_qualiantech_com [SER QA 1115] Using Multiple Line Selection feature appear ugly error js 
Attached Filespng MultipleLineSelection.png (197,594) 2016-05-17 19:29
https://issues.openbravo.com/file_download.php?file_id=9419&type=bug
png

png MultipleLineSelection-Error.png (312,594) 2016-05-17 19:38
https://issues.openbravo.com/file_download.php?file_id=9420&type=bug
patch issue 32981 giftcard 170.patch (1,851) 2016-05-23 13:52
https://issues.openbravo.com/file_download.php?file_id=9433&type=bug
patch issue 32981 posterminal 6453.patch (1,549) 2016-05-23 13:52
https://issues.openbravo.com/file_download.php?file_id=9434&type=bug
patch issue 32981 test 5423.patch (4,287) 2016-05-23 13:53
https://issues.openbravo.com/file_download.php?file_id=9435&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-05-17 19:29OsmanyNew Issue
2016-05-17 19:29OsmanyAssigned To => Retail
2016-05-17 19:29OsmanyFile Added: MultipleLineSelection.png
2016-05-17 19:29OsmanyResolution time => 1464040800
2016-05-17 19:29OsmanyTriggers an Emergency Pack => No
2016-05-17 19:33OsmanyTag Attached: SER-QA
2016-05-17 19:38OsmanyFile Added: MultipleLineSelection-Error.png
2016-05-17 23:23OsmanyRelationship addedrelated to 0032721
2016-05-18 12:57ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-05-18 12:58ranjith_qualiantech_comStatusnew => acknowledged
2016-05-18 12:58ranjith_qualiantech_comStatusacknowledged => scheduled
2016-05-19 10:22VictorVillarSummaryUsing Multiple Line Selection feature appear ugly error js => [SER QA 1115] Using Multiple Line Selection feature appear ugly error js
2016-05-23 13:52ranjith_qualiantech_comFile Added: issue 32981 giftcard 170.patch
2016-05-23 13:52ranjith_qualiantech_comFile Added: issue 32981 posterminal 6453.patch
2016-05-23 13:53ranjith_qualiantech_comFile Added: issue 32981 test 5423.patch
2016-06-03 14:27hgbotCheckin
2016-06-03 14:27hgbotNote Added: 0086989
2016-06-04 10:53hgbotCheckin
2016-06-04 10:53hgbotNote Added: 0087000
2016-06-04 10:53hgbotCheckin
2016-06-04 10:53hgbotNote Added: 0087001
2016-06-04 10:53hgbotStatusscheduled => resolved
2016-06-04 10:53hgbotResolutionopen => fixed
2016-06-04 10:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6f74c25ab5e77e1a48d0186a8847694ca00fc460 [^]
2016-06-06 09:51marvintmReview Assigned To => marvintm
2016-06-06 09:51marvintmStatusresolved => closed
2016-06-06 09:51marvintmFixed in Version => RR16Q3
2016-06-06 11:08jorge-garciaStatusclosed => new
2016-06-06 11:08jorge-garciaResolutionfixed => open
2016-06-06 11:08jorge-garciaFixed in VersionRR16Q3 =>
2016-06-06 11:10jorge-garciaStatusnew => scheduled
2016-06-06 11:10jorge-garciaNote Added: 0087020
2016-06-06 11:11jorge-garciaStatusscheduled => resolved
2016-06-06 11:11jorge-garciaFixed in Version => RR16Q3
2016-06-06 11:11jorge-garciaResolutionopen => fixed
2016-06-06 11:12jorge-garciaNote Added: 0087022
2016-06-06 11:12jorge-garciaStatusresolved => closed

Notes
(0086989)
hgbot   
2016-06-03 14:27   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 17a1262c6a1395d82c39b4672bc4720f169dd6de
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jun 03 17:52:45 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/17a1262c6a1395d82c39b4672bc4720f169dd6de [^]

Related to issue 32981 : Validating Line Selection hooks for single/multi line selection

- Arguments for hook "OBPOS_LineSelected" has been changed
- Based on the arguments, return line should be disabled if the line/multiline selection has gift card

---
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
---
(0087000)
hgbot   
2016-06-04 10:53   
Repository: tools/automation/pi-mobile
Changeset: 36ae7090687ff72a9226c19af3961db5409fdcbb
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sat Jun 04 14:18:27 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/36ae7090687ff72a9226c19af3961db5409fdcbb [^]

Verifies issue 32981 : Added automated test 'I32981_VerifyGiftCardLineSelection'

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I32981_VerifyGiftCardLineSelection.java
---
(0087001)
hgbot   
2016-06-04 10:53   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6f74c25ab5e77e1a48d0186a8847694ca00fc460
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sat Jun 04 11:09:45 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6f74c25ab5e77e1a48d0186a8847694ca00fc460 [^]

Fixes issue 32981 : Replaced product with line in "OBPOS_LineSelected" hook

Added "selectedLines" as arg in "OBPOS_LineSelected" hook

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0087020)
jorge-garcia   
2016-06-06 11:10   
Creating backports for 3.0RR16Q1.3 and 3.0RR16Q2
(0087022)
jorge-garcia   
2016-06-06 11:12   
No changes required.