Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0032857
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Retail Modules] Web POSmajorhave not tried2016-05-04 13:542016-09-07 13:43
ReporteradrianromeroView Statuspublic 
Assigned Toadrianromero 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisione158b059dea3
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0032857: The document no separator should be customized

DescriptionCurrently the Document no in the Web POS is build the following way:

<Doc Type Prefix> + "/" + <Sequential number>

For example: VBS1/0000107

Note the separator character is hardcoded and cannot be customized
Steps To Reproducen/a
Proposed SolutionAllow to customize in the code whether to add or not the hardcoded "/" separator. This way if the application is customized as not including the separator, the document no will be:

<Doc Type Prefix> + <Sequential number>

Allowing to customize the document no generation.

See patch attached.
TagsNo tags attached.
Attached Filesdiff file icon fixesissue32857.diff [^] (5,748 bytes) 2016-05-04 14:18 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
depends on feature request 0032405 closedsimbu94 Ability to have a separate prefix and sequence for return documents in the Web POS 
related to defect 0034017 closedranjith_qualiantech_com [SER QA 1730] Function getLastDocumentNumber relies on the separator '/' to process Document numbers 

-  Notes
(0086332)
hgbot (developer)
2016-05-10 09:32

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a0f5f469eef6289aa25ba6f311eacde5f1b329a0
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed May 04 14:17:12 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a0f5f469eef6289aa25ba6f311eacde5f1b329a0 [^]

Fixes issue 0032857: The document no separator should be customized
* Order model property allows to customize whether the document no has a separator or not

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/POSUtils.java
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0086355)
simbu94 (developer)
2016-05-10 15:45

Automated test cases:

https://code.openbravo.com/tools/automation/pi-mobile/rev/a158af65e92a [^]
(0086361)
hgbot (developer)
2016-05-11 09:28

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e158b059dea3f86d108b7ab68108a3af925ad5ce
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue May 10 14:09:27 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e158b059dea3f86d108b7ab68108a3af925ad5ce [^]

Fixes issue 0032857: The document no separator should be customized
* Adding fix for return document numbers

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/POSUtils.java
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0086872)
dmitry_mezentsev (developer)
2016-06-01 10:23

Not closed for 22 days!!!
Please react ASAP.
(0089802)
adrianromero (manager)
2016-09-07 13:43

To remove the separator include the following js code:

OB.Model.Order.prototype.includeDocNoSeperator = false;

- Issue History
Date Modified Username Field Change
2016-05-04 13:54 adrianromero New Issue
2016-05-04 13:54 adrianromero Assigned To => Retail
2016-05-04 13:54 adrianromero Resolution time => 1463263200
2016-05-04 13:54 adrianromero Triggers an Emergency Pack => No
2016-05-04 14:16 adrianromero Description Updated View Revisions
2016-05-04 14:18 adrianromero File Added: fixesissue32857.diff
2016-05-05 09:38 adrianromero Assigned To Retail => adrianromero
2016-05-05 09:38 adrianromero Status new => scheduled
2016-05-09 11:16 adrianromero Relationship added depends on 0032405
2016-05-10 09:32 hgbot Checkin
2016-05-10 09:32 hgbot Note Added: 0086332
2016-05-10 09:32 hgbot Status scheduled => resolved
2016-05-10 09:32 hgbot Resolution open => fixed
2016-05-10 09:32 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a0f5f469eef6289aa25ba6f311eacde5f1b329a0 [^]
2016-05-10 15:45 simbu94 Note Added: 0086355
2016-05-11 09:28 hgbot Checkin
2016-05-11 09:28 hgbot Note Added: 0086361
2016-05-11 09:28 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a0f5f469eef6289aa25ba6f311eacde5f1b329a0 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e158b059dea3f86d108b7ab68108a3af925ad5ce [^]
2016-05-18 09:29 adrianromero Assigned To adrianromero =>
2016-05-18 09:29 adrianromero Assigned To => adrianromero
2016-05-18 09:32 adrianromero Review Assigned To => marvintm
2016-06-01 10:23 dmitry_mezentsev Note Added: 0086872
2016-06-02 16:13 marvintm Status resolved => closed
2016-09-07 13:43 adrianromero Note Added: 0089802
2016-09-19 14:25 adrianromero Relationship added related to 0034017


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker