Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032857Retail ModulesWeb POSpublic2016-05-04 13:542016-09-07 13:43
Reporteradrianromero 
Assigned Toadrianromero 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032857: The document no separator should be customized
DescriptionCurrently the Document no in the Web POS is build the following way:

<Doc Type Prefix> + "/" + <Sequential number>

For example: VBS1/0000107

Note the separator character is hardcoded and cannot be customized
Steps To Reproducen/a
Proposed SolutionAllow to customize in the code whether to add or not the hardcoded "/" separator. This way if the application is customized as not including the separator, the document no will be:

<Doc Type Prefix> + <Sequential number>

Allowing to customize the document no generation.

See patch attached.
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 0032405 closed simbu94 Ability to have a separate prefix and sequence for return documents in the Web POS 
related to defect 0034017 closed ranjith_qualiantech_com [SER QA 1730] Function getLastDocumentNumber relies on the separator '/' to process Document numbers 
Attached Filesdiff fixesissue32857.diff (5,748) 2016-05-04 14:18
https://issues.openbravo.com/file_download.php?file_id=9363&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-05-04 13:54adrianromeroNew Issue
2016-05-04 13:54adrianromeroAssigned To => Retail
2016-05-04 13:54adrianromeroResolution time => 1463263200
2016-05-04 13:54adrianromeroTriggers an Emergency Pack => No
2016-05-04 14:16adrianromeroDescription Updatedbug_revision_view_page.php?rev_id=11968#r11968
2016-05-04 14:18adrianromeroFile Added: fixesissue32857.diff
2016-05-05 09:38adrianromeroAssigned ToRetail => adrianromero
2016-05-05 09:38adrianromeroStatusnew => scheduled
2016-05-09 11:16adrianromeroRelationship addeddepends on 0032405
2016-05-10 09:32hgbotCheckin
2016-05-10 09:32hgbotNote Added: 0086332
2016-05-10 09:32hgbotStatusscheduled => resolved
2016-05-10 09:32hgbotResolutionopen => fixed
2016-05-10 09:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a0f5f469eef6289aa25ba6f311eacde5f1b329a0 [^]
2016-05-10 15:45simbu94Note Added: 0086355
2016-05-11 09:28hgbotCheckin
2016-05-11 09:28hgbotNote Added: 0086361
2016-05-11 09:28hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a0f5f469eef6289aa25ba6f311eacde5f1b329a0 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e158b059dea3f86d108b7ab68108a3af925ad5ce [^]
2016-05-18 09:29adrianromeroAssigned Toadrianromero =>
2016-05-18 09:29adrianromeroAssigned To => adrianromero
2016-05-18 09:32adrianromeroReview Assigned To => marvintm
2016-06-01 10:23dmitry_mezentsevNote Added: 0086872
2016-06-02 16:13marvintmStatusresolved => closed
2016-09-07 13:43adrianromeroNote Added: 0089802
2016-09-19 14:25adrianromeroRelationship addedrelated to 0034017

Notes
(0086332)
hgbot   
2016-05-10 09:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a0f5f469eef6289aa25ba6f311eacde5f1b329a0
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed May 04 14:17:12 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a0f5f469eef6289aa25ba6f311eacde5f1b329a0 [^]

Fixes issue 0032857: The document no separator should be customized
* Order model property allows to customize whether the document no has a separator or not

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/POSUtils.java
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0086355)
simbu94   
2016-05-10 15:45   
Automated test cases:

https://code.openbravo.com/tools/automation/pi-mobile/rev/a158af65e92a [^]
(0086361)
hgbot   
2016-05-11 09:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e158b059dea3f86d108b7ab68108a3af925ad5ce
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue May 10 14:09:27 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e158b059dea3f86d108b7ab68108a3af925ad5ce [^]

Fixes issue 0032857: The document no separator should be customized
* Adding fix for return document numbers

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/POSUtils.java
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0086872)
dmitry_mezentsev   
2016-06-01 10:23   
Not closed for 22 days!!!
Please react ASAP.
(0089802)
adrianromero   
2016-09-07 13:43   
To remove the separator include the following js code:

OB.Model.Order.prototype.includeDocNoSeperator = false;