0032806: Cannot void a goods receipt if the role does not have access to Client window

Notes
(0089556) markmm82 (developer) 2016-08-30 19:23 edited on: 2016-09-01 15:32	Test Plan 1 As F&B Admin: - Go to Role window. - Select F&B Admin role, go to Window Access tab and remove "Client window" - Log out and log in - Go to Goods Receipt window, create a new header with any line. Complete. - Void the receipt. Notice you are able to void it even the role does not have access to the Client window. It is OK. Test Plan 2 (related to issue 30033) As F&B Admin: - Create an Attribute Set. Check only Lot flag. - Create another Attribute Set. Check Lot and Require At Least One Value flags. - Create a product and assign the first attribute set to it. - Create another product and assign the second attribute set to it. - Create a Goods Receipt. Add a line with first product, quantity = 1. Add a line with second product, attribute set value = L0, quantity = 2. Add another line with second product, attribute set value = L0, quantity = 3. Complete. - Create a Goods Shipment and add three lines in order to leave the stock of created products to 0. Complete. - Create a Physical Inventory header and launch the Create Inventory Count Process, leaving Inventory Quantity option empty. Check a line is created for the first product (non mandatory attribute) but not for the second product (mandatory attribute). Increase the quantity count of the line created for the first product to 1 and process the inventory. - Move to the created Goods Receipt and click on Close button. Select Void and click Ok. Realize Create Physical Inventory popup is shown with a grid with two lines (one for each receipt line with a mandatory attribute and without stock) Click on OK. Realize no stock error message is shown. Click on Close button. Select Void and click Ok. Realize a completed succesfully message is shown.

(0089616) psanjuan (manager) 2016-08-31 12:59	Issue verified.

(0089660) psanjuan (manager) 2016-09-01 13:46 edited on: 2016-09-01 14:11	Test Plan 1 As QA Testing Admin role, go to "Client" window. Make sure "Allow Negative Stock" is NOT selected. Go to Role window, select QA Testing Admin role. Go to "Window Access" tab and remove "Client" window. Log out and log in Go to Goods Receipt window, create a new header with any line. Complete. Void the receipt. Notice you are able to void it even the role does not have access to the Client window. That is OK. Test Plan 2 (related to issue 30033) As QA Testing Admin: - Create an Attribute Set for Spain org, named "Only Lot". Check only "Lot" flag. - Create another Attribute Set for Spain org, named "Lot". Check "Lot" and "Require At Least One Value" flags. - Create a product named "Product A" and assign the first attribute set to it. Select a purchase price list "Purchase Spain". - Create another product "Product B" and assign the second attribute set to it. - Create a Goods Receipt. Add a line with first product A, quantity = 1. Add a line with second productB , attribute set value = L0, quantity = 2. Add another line with second product B, attribute set value = L0, quantity = 3. Complete it. - Create a Goods Shipment and add three lines in order to leave the stock of created products to 0. Complete it. - Create a Physical Inventory header and launch the Create Inventory Count Process, leaving Inventory Quantity option empty. - Check a line is created for the first product A with a quantity count = 0 (non mandatory attribute) but not for the second product (mandatory attribute). - Increase the quantity count of the line created for the first product to 1 and process the inventory. - Move to the created Goods Receipt and click on Close button. Select Void and click Ok. - A new window is opened named "Create Physical Inventory". - Check that the grid shows two lines (one for each receipt line of Product B having a mandatory attribute without stock), saying "Therei, s no registered stock for those products and attribute set values....etc". - Click OK. Realize no stock error message is shown and goods receipt has been voided.

(0089679) hgbot (developer) 2016-09-01 18:42	Repository: erp/devel/pi Changeset: 9a7c89992e608c2bd12695b28638d97032255d95 Author: Mark <markmm82 <at> gmail.com> Date: Mon Aug 29 13:14:09 2016 -0400 URL: http://code.openbravo.com/erp/devel/pi/rev/9a7c89992e608c2bd12695b28638d97032255d95 [^] Fixes issue 32806: Can void a receipt if role doesn't have Client window access Allow to void a goods receipt even the role does not have access to Client window. The OB Context is configured as Admin mode to avoid access validations when getClientInformationList() method of ADClient class is invoked. --- M src/org/openbravo/costing/CostingUtils.java M src/org/openbravo/erpCommon/ad_actionButton/ProcessGoods.java M src/org/openbravo/materialmgmt/InventoryCountProcess.java ---

(0089680) aferraz (manager) 2016-09-01 18:55	Code review OK

(0089708) hudsonbot (developer) 2016-09-02 14:28	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f7167eecae1 [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2016-04-28 10:04	ngarcia	New Issue
2016-04-28 10:04	ngarcia	Assigned To	=> Triage Finance
2016-04-28 10:04	ngarcia	Modules	=> Core
2016-04-28 10:04	ngarcia	Triggers an Emergency Pack	=> No
2016-04-28 10:05	ngarcia	Issue Monitored: networkb
2016-08-29 10:04	ngarcia	Relationship added	caused by 0030033
2016-08-29 10:04	ngarcia	Priority	high => immediate
2016-08-29 16:14	aferraz	Assigned To	Triage Finance => markmm82
2016-08-29 16:24	markmm82	Status	new => acknowledged
2016-08-29 19:33	markmm82	Regression level	=> Production - Confirmed Stable
2016-08-29 19:33	markmm82	Regression date	=> 2015-09-11
2016-08-29 19:33	markmm82	Regression introduced in release	=> 3.0PR15Q2.5
2016-08-29 19:33	markmm82	Regression introduced by commit	=> http://code.openbravo.com/erp/devel/pi/rev/17eb51a4c06e4c52758955c846be5a7b91c4edcb [^]
2016-08-29 19:35	markmm82	Status	acknowledged => scheduled
2016-08-30 19:23	markmm82	Note Added: 0089556
2016-08-31 12:59	psanjuan	Note Added: 0089616
2016-09-01 13:44	psanjuan	Note Edited: 0089556	View Revisions
2016-09-01 13:45	psanjuan	Note Edited: 0089556	View Revisions
2016-09-01 13:46	psanjuan	Note Added: 0089660
2016-09-01 13:47	psanjuan	Note Edited: 0089660	View Revisions
2016-09-01 14:03	psanjuan	Note Edited: 0089660	View Revisions
2016-09-01 14:11	psanjuan	Note Edited: 0089660	View Revisions
2016-09-01 14:11	psanjuan	Note Edited: 0089660	View Revisions
2016-09-01 15:32	markmm82	Note Edited: 0089556	View Revisions
2016-09-01 18:40	aferraz	Regression introduced in release	3.0PR15Q2.5 => 3.0PR15Q4
2016-09-01 18:40	aferraz	Regression introduced by commit	http://code.openbravo.com/erp/devel/pi/rev/17eb51a4c06e4c52758955c846be5a7b91c4edcb [^] => https://code.openbravo.com/erp/devel/pi/rev/17eb51a4c06e [^]
2016-09-01 18:42	hgbot	Checkin
2016-09-01 18:42	hgbot	Note Added: 0089679
2016-09-01 18:42	hgbot	Status	scheduled => resolved
2016-09-01 18:42	hgbot	Resolution	open => fixed
2016-09-01 18:42	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/9a7c89992e608c2bd12695b28638d97032255d95 [^]
2016-09-01 18:55	aferraz	Review Assigned To	=> aferraz
2016-09-01 18:55	aferraz	Note Added: 0089680
2016-09-01 18:55	aferraz	Status	resolved => closed
2016-09-01 18:55	aferraz	Fixed in Version	=> 3.0PR16Q4
2016-09-02 14:28	hudsonbot	Checkin
2016-09-02 14:28	hudsonbot	Note Added: 0089708