Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032806Openbravo ERP04. Warehouse managementpublic2016-04-28 10:042016-09-02 14:28
Reporterngarcia 
Assigned Tomarkmm82 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2015-09-11
Regression introduced in release3.0PR15Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/17eb51a4c06e [^]
Triggers an Emergency PackNo
Summary0032806: Cannot void a goods receipt if the role does not have access to Client window
DescriptionCannot void a goods receipt if the role does not have access to Client window
Steps To ReproduceAs group admin role:
   Remove Client window from Role - Window Access tab
   Log out and log in
   Go to Goods Receipt window, try to void a record and check the following error message is shown:
      org.openbravo.base.exception.OBSecurityException: Entity ADClient is not directly readable, only id and identifier properties are readable, property ADClient.clientInformationList is neither of these.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00338443.0PR16Q3.2 closed markmm82 Cannot void a goods receipt if the role does not have access to Client window 
depends on backport 00338453.0PR16Q2.3 closed markmm82 Cannot void a goods receipt if the role does not have access to Client window 
caused by defect 0030033 closed aferraz Create Inventory Count List process does not insert products without stock if product has a mandatory attribute 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-04-28 10:04ngarciaNew Issue
2016-04-28 10:04ngarciaAssigned To => Triage Finance
2016-04-28 10:04ngarciaModules => Core
2016-04-28 10:04ngarciaTriggers an Emergency Pack => No
2016-04-28 10:05ngarciaIssue Monitored: networkb
2016-08-29 10:04ngarciaRelationship addedcaused by 0030033
2016-08-29 10:04ngarciaPriorityhigh => immediate
2016-08-29 16:14aferrazAssigned ToTriage Finance => markmm82
2016-08-29 16:24markmm82Statusnew => acknowledged
2016-08-29 19:33markmm82Regression level => Production - Confirmed Stable
2016-08-29 19:33markmm82Regression date => 2015-09-11
2016-08-29 19:33markmm82Regression introduced in release => 3.0PR15Q2.5
2016-08-29 19:33markmm82Regression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/17eb51a4c06e4c52758955c846be5a7b91c4edcb [^]
2016-08-29 19:35markmm82Statusacknowledged => scheduled
2016-08-30 19:23markmm82Note Added: 0089556
2016-08-31 12:59psanjuanNote Added: 0089616
2016-09-01 13:44psanjuanNote Edited: 0089556bug_revision_view_page.php?bugnote_id=0089556#r13019
2016-09-01 13:45psanjuanNote Edited: 0089556bug_revision_view_page.php?bugnote_id=0089556#r13020
2016-09-01 13:46psanjuanNote Added: 0089660
2016-09-01 13:47psanjuanNote Edited: 0089660bug_revision_view_page.php?bugnote_id=0089660#r13022
2016-09-01 14:03psanjuanNote Edited: 0089660bug_revision_view_page.php?bugnote_id=0089660#r13023
2016-09-01 14:11psanjuanNote Edited: 0089660bug_revision_view_page.php?bugnote_id=0089660#r13024
2016-09-01 14:11psanjuanNote Edited: 0089660bug_revision_view_page.php?bugnote_id=0089660#r13025
2016-09-01 15:32markmm82Note Edited: 0089556bug_revision_view_page.php?bugnote_id=0089556#r13026
2016-09-01 18:40aferrazRegression introduced in release3.0PR15Q2.5 => 3.0PR15Q4
2016-09-01 18:40aferrazRegression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/17eb51a4c06e4c52758955c846be5a7b91c4edcb [^] => https://code.openbravo.com/erp/devel/pi/rev/17eb51a4c06e [^]
2016-09-01 18:42hgbotCheckin
2016-09-01 18:42hgbotNote Added: 0089679
2016-09-01 18:42hgbotStatusscheduled => resolved
2016-09-01 18:42hgbotResolutionopen => fixed
2016-09-01 18:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9a7c89992e608c2bd12695b28638d97032255d95 [^]
2016-09-01 18:55aferrazReview Assigned To => aferraz
2016-09-01 18:55aferrazNote Added: 0089680
2016-09-01 18:55aferrazStatusresolved => closed
2016-09-01 18:55aferrazFixed in Version => 3.0PR16Q4
2016-09-02 14:28hudsonbotCheckin
2016-09-02 14:28hudsonbotNote Added: 0089708

Notes
(0089556)
markmm82   
2016-08-30 19:23   
(edited on: 2016-09-01 15:32)
Test Plan 1

As F&B Admin:
- Go to Role window.
- Select F&B Admin role, go to Window Access tab and remove "Client window"
- Log out and log in
- Go to Goods Receipt window, create a new header with any line. Complete.
- Void the receipt. Notice you are able to void it even the role does not have access to the Client window. It is OK.


Test Plan 2 (related to issue 30033)

As F&B Admin:
- Create an Attribute Set. Check only Lot flag.
- Create another Attribute Set. Check Lot and Require At Least One Value flags.

- Create a product and assign the first attribute set to it.
- Create another product and assign the second attribute set to it.

- Create a Goods Receipt.
  Add a line with first product, quantity = 1.
  Add a line with second product, attribute set value = L0, quantity = 2.
  Add another line with second product, attribute set value = L0, quantity = 3.
  Complete.
  
- Create a Goods Shipment and add three lines in order to leave the stock of created products to 0. Complete.

- Create a Physical Inventory header and launch the Create Inventory Count Process, leaving Inventory Quantity option empty.
  Check a line is created for the first product (non mandatory attribute) but not for the second product (mandatory attribute).
  Increase the quantity count of the line created for the first product to 1 and process the inventory.

- Move to the created Goods Receipt and click on Close button. Select Void and click Ok.
  Realize Create Physical Inventory popup is shown with a grid with two lines (one for each receipt line with a mandatory attribute and without stock)
  Click on OK. Realize no stock error message is shown.
  Click on Close button. Select Void and click Ok.
  Realize a completed succesfully message is shown.
(0089616)
psanjuan   
2016-08-31 12:59   
Issue verified.
(0089660)
psanjuan   
2016-09-01 13:46   
(edited on: 2016-09-01 14:11)
Test Plan 1

As QA Testing Admin role, go to "Client" window.
Make sure "Allow Negative Stock" is NOT selected.

Go to Role window, select QA Testing Admin role. Go to "Window Access" tab and remove "Client" window.
Log out and log in

Go to Goods Receipt window, create a new header with any line. Complete.

Void the receipt. Notice you are able to void it even the role does not have access to the Client window. That is OK.


Test Plan 2 (related to issue 30033)

As QA Testing Admin:

- Create an Attribute Set for Spain org, named "Only Lot". Check only "Lot" flag.
- Create another Attribute Set for Spain org, named "Lot". Check "Lot" and "Require At Least One Value" flags.

- Create a product named "Product A" and assign the first attribute set to it. Select a purchase price list "Purchase Spain".

- Create another product "Product B" and assign the second attribute set to it.

- Create a Goods Receipt.
  Add a line with first product A, quantity = 1.
  Add a line with second productB , attribute set value = L0, quantity = 2.
  Add another line with second product B, attribute set value = L0, quantity = 3.
  Complete it.
  
- Create a Goods Shipment and add three lines in order to leave the stock of created products to 0. Complete it.

- Create a Physical Inventory header and launch the Create Inventory Count Process, leaving Inventory Quantity option empty.

- Check a line is created for the first product A with a quantity count = 0 (non mandatory attribute) but not for the second product (mandatory attribute).

- Increase the quantity count of the line created for the first product to 1 and process the inventory.

- Move to the created Goods Receipt and click on Close button. Select Void and click Ok.

- A new window is opened named "Create Physical Inventory".
- Check that the grid shows two lines (one for each receipt line of Product B having a mandatory attribute without stock), saying "Therei, s no registered stock for those products and attribute set values....etc".

- Click OK. Realize no stock error message is shown and goods receipt has been voided.
(0089679)
hgbot   
2016-09-01 18:42   
Repository: erp/devel/pi
Changeset: 9a7c89992e608c2bd12695b28638d97032255d95
Author: Mark <markmm82 <at> gmail.com>
Date: Mon Aug 29 13:14:09 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/9a7c89992e608c2bd12695b28638d97032255d95 [^]

Fixes issue 32806: Can void a receipt if role doesn't have Client window access

Allow to void a goods receipt even the role does not have access to Client window. The OB Context is configured as Admin mode to avoid access validations when getClientInformationList() method of ADClient class is invoked.

---
M src/org/openbravo/costing/CostingUtils.java
M src/org/openbravo/erpCommon/ad_actionButton/ProcessGoods.java
M src/org/openbravo/materialmgmt/InventoryCountProcess.java
---
(0089680)
aferraz   
2016-09-01 18:55   
Code review OK
(0089708)
hudsonbot   
2016-09-02 14:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f7167eecae1 [^]
Maturity status: Test