Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0032734
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-04-20 15:342016-05-18 08:51
ReporteraaroncaleroView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision91fbb47d4873
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression levelProduction - QA Approved
Regression date2015-11-27
Regression introduced in releaseRR16Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c3305a61a5f7 [^]
Triggers an Emergency PackNo
Summary

0032734: Overall performance loss after clicking on receipt lines several times

DescriptionDuring the normal use of Web POS, after clicking on receipt lines several times, the overall performance of webpos operations slowly decreases.
The problem is that every time a line of the receipt is clicked, an event handler is being attached to the receipt line collection.
The performance problem comes from
Steps To ReproduceVerify on the following file https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/annotate/8f965cacdfb0/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js#l467 [^] that an event handler is being added on every tap() execution.
Add a console.log expression on the receiptLineSelected function on pointofsale.js.
Refresh the webpos, create a new ticket and add a line.
Verify that the first time the line is clicked, the log expression is printed once.
Verify that the second time the line is clicked, the log expression is printed twice.
Every time the line is clicked, the amount of log lines printed increases.
Proposed SolutionThe event handler that is added on toolbar-right.js should be added just once to prevent multiple executions of receiptLineSelected().
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0032822RR16Q2 closedranjith_qualiantech_com Overall performance loss after clicking on receipt lines several times 
depends on backport 0032823RR16Q1.2 closedranjith_qualiantech_com Overall performance loss after clicking on receipt lines several times 
caused by defect 0031509 closedranjith_qualiantech_com [SERQA 398] Opening the EDIT panel always focuses on the last line of the ticket 

-  Notes
(0086017)
hgbot (developer)
2016-04-27 10:57

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 2412512248c5a8def1298f35223af009e26f4be2
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Apr 27 14:24:04 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2412512248c5a8def1298f35223af009e26f4be2 [^]

Related to issue 32734 : Removing Duplicate code in receipt line selection

Receipt line selection event has already added in posterminal editline.js

---
M web/org.openbravo.mobile.core/source/component/ob-keypadbasic.js
---
(0086018)
hgbot (developer)
2016-04-27 10:57

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f4b49e0febce37c6d5ddf4f1f5b00bf84a611306
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Apr 27 14:26:35 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f4b49e0febce37c6d5ddf4f1f5b00bf84a611306 [^]

Fixes issue 32734 : Moving Line selected event to avoid muliple trigger

In toolbar-right.js, line selected event has been moved to init model to avoid multiple trigger.
onReceiptLineSelected event has been removed, since it is triggered from selected event
In renderorderline, receiptLineSection event moved to editline, to avoid duplication

---
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
---
(0086019)
hgbot (developer)
2016-04-27 11:00

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 91fbb47d4873d68a924300e2cde207ebee599211
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Apr 27 14:30:22 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/91fbb47d4873d68a924300e2cde207ebee599211 [^]

Fixes issue 32734 : Moving Line selected event to avoid muliple trigger

In toolbar-right.js, line selected event has been moved to init model to avoid multiple trigger.
onReceiptLineSelected event has been removed, since it is triggered from selected event

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
---
(0086512)
migueldejuana (viewer)
2016-05-18 08:51

 Tested and reviewed in ec98fed2ca51

- Issue History
Date Modified Username Field Change
2016-04-20 15:34 aaroncalero New Issue
2016-04-20 15:34 aaroncalero Assigned To => Retail
2016-04-20 15:34 aaroncalero OBNetwork customer => No
2016-04-20 15:34 aaroncalero Regression level => Production - QA Approved
2016-04-20 15:34 aaroncalero Regression date => 2015-11-27
2016-04-20 15:34 aaroncalero Regression introduced in release => RR16Q1
2016-04-20 15:34 aaroncalero Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c3305a61a5f7 [^]
2016-04-20 15:34 aaroncalero Triggers an Emergency Pack => No
2016-04-20 17:20 Orekaria Relationship added caused by 0031509
2016-04-20 17:20 Orekaria Status new => acknowledged
2016-04-20 17:21 Orekaria Status acknowledged => scheduled
2016-04-20 17:21 Orekaria Assigned To Retail => ranjith_qualiantech_com
2016-04-27 10:57 hgbot Checkin
2016-04-27 10:57 hgbot Note Added: 0086017
2016-04-27 10:57 hgbot Checkin
2016-04-27 10:57 hgbot Note Added: 0086018
2016-04-27 10:57 hgbot Status scheduled => resolved
2016-04-27 10:57 hgbot Resolution open => fixed
2016-04-27 10:57 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f4b49e0febce37c6d5ddf4f1f5b00bf84a611306 [^]
2016-04-27 11:00 hgbot Checkin
2016-04-27 11:00 hgbot Note Added: 0086019
2016-04-27 11:00 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f4b49e0febce37c6d5ddf4f1f5b00bf84a611306 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/91fbb47d4873d68a924300e2cde207ebee599211 [^]
2016-05-02 12:15 marvintm Status resolved => new
2016-05-02 12:15 marvintm Resolution fixed => open
2016-05-02 12:15 marvintm Status new => scheduled
2016-05-02 12:15 marvintm Status scheduled => resolved
2016-05-02 12:15 marvintm Resolution open => fixed
2016-05-18 08:51 migueldejuana Review Assigned To => migueldejuana
2016-05-18 08:51 migueldejuana Note Added: 0086512
2016-05-18 08:51 migueldejuana Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker