Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032734Retail ModulesWeb POSpublic2016-04-20 15:342016-05-18 08:51
Reporteraaroncalero 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2015-11-27
Regression introduced in releaseRR16Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c3305a61a5f7 [^]
Triggers an Emergency PackNo
Summary0032734: Overall performance loss after clicking on receipt lines several times
DescriptionDuring the normal use of Web POS, after clicking on receipt lines several times, the overall performance of webpos operations slowly decreases.
The problem is that every time a line of the receipt is clicked, an event handler is being attached to the receipt line collection.
The performance problem comes from
Steps To ReproduceVerify on the following file https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/annotate/8f965cacdfb0/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js#l467 [^] that an event handler is being added on every tap() execution.
Add a console.log expression on the receiptLineSelected function on pointofsale.js.
Refresh the webpos, create a new ticket and add a line.
Verify that the first time the line is clicked, the log expression is printed once.
Verify that the second time the line is clicked, the log expression is printed twice.
Every time the line is clicked, the amount of log lines printed increases.
Proposed SolutionThe event handler that is added on toolbar-right.js should be added just once to prevent multiple executions of receiptLineSelected().
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0032822RR16Q2 closed ranjith_qualiantech_com Overall performance loss after clicking on receipt lines several times 
depends on backport 0032823RR16Q1.2 closed ranjith_qualiantech_com Overall performance loss after clicking on receipt lines several times 
caused by defect 0031509 closed ranjith_qualiantech_com [SERQA 398] Opening the EDIT panel always focuses on the last line of the ticket 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-04-20 15:34aaroncaleroNew Issue
2016-04-20 15:34aaroncaleroAssigned To => Retail
2016-04-20 15:34aaroncaleroRegression level => Production - QA Approved
2016-04-20 15:34aaroncaleroRegression date => 2015-11-27
2016-04-20 15:34aaroncaleroRegression introduced in release => RR16Q1
2016-04-20 15:34aaroncaleroRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c3305a61a5f7 [^]
2016-04-20 15:34aaroncaleroTriggers an Emergency Pack => No
2016-04-20 17:20OrekariaRelationship addedcaused by 0031509
2016-04-20 17:20OrekariaStatusnew => acknowledged
2016-04-20 17:21OrekariaStatusacknowledged => scheduled
2016-04-20 17:21OrekariaAssigned ToRetail => ranjith_qualiantech_com
2016-04-27 10:57hgbotCheckin
2016-04-27 10:57hgbotNote Added: 0086017
2016-04-27 10:57hgbotCheckin
2016-04-27 10:57hgbotNote Added: 0086018
2016-04-27 10:57hgbotStatusscheduled => resolved
2016-04-27 10:57hgbotResolutionopen => fixed
2016-04-27 10:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f4b49e0febce37c6d5ddf4f1f5b00bf84a611306 [^]
2016-04-27 11:00hgbotCheckin
2016-04-27 11:00hgbotNote Added: 0086019
2016-04-27 11:00hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f4b49e0febce37c6d5ddf4f1f5b00bf84a611306 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/91fbb47d4873d68a924300e2cde207ebee599211 [^]
2016-05-02 12:15marvintmStatusresolved => new
2016-05-02 12:15marvintmResolutionfixed => open
2016-05-02 12:15marvintmStatusnew => scheduled
2016-05-02 12:15marvintmStatusscheduled => resolved
2016-05-02 12:15marvintmResolutionopen => fixed
2016-05-18 08:51migueldejuanaReview Assigned To => migueldejuana
2016-05-18 08:51migueldejuanaNote Added: 0086512
2016-05-18 08:51migueldejuanaStatusresolved => closed

Notes
(0086017)
hgbot   
2016-04-27 10:57   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 2412512248c5a8def1298f35223af009e26f4be2
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Apr 27 14:24:04 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2412512248c5a8def1298f35223af009e26f4be2 [^]

Related to issue 32734 : Removing Duplicate code in receipt line selection

Receipt line selection event has already added in posterminal editline.js

---
M web/org.openbravo.mobile.core/source/component/ob-keypadbasic.js
---
(0086018)
hgbot   
2016-04-27 10:57   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f4b49e0febce37c6d5ddf4f1f5b00bf84a611306
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Apr 27 14:26:35 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f4b49e0febce37c6d5ddf4f1f5b00bf84a611306 [^]

Fixes issue 32734 : Moving Line selected event to avoid muliple trigger

In toolbar-right.js, line selected event has been moved to init model to avoid multiple trigger.
onReceiptLineSelected event has been removed, since it is triggered from selected event
In renderorderline, receiptLineSection event moved to editline, to avoid duplication

---
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
---
(0086019)
hgbot   
2016-04-27 11:00   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 91fbb47d4873d68a924300e2cde207ebee599211
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Apr 27 14:30:22 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/91fbb47d4873d68a924300e2cde207ebee599211 [^]

Fixes issue 32734 : Moving Line selected event to avoid muliple trigger

In toolbar-right.js, line selected event has been moved to init model to avoid multiple trigger.
onReceiptLineSelected event has been removed, since it is triggered from selected event

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
---
(0086512)
migueldejuana   
2016-05-18 08:51   
Tested and reviewed in ec98fed2ca51