Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0032632
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-04-08 12:452016-05-20 09:40
ReporterxabiermerinoView Statuspublic 
Assigned Tojorge-garcia 
PriorityurgentResolutionfixedFixed in VersionRR16Q3
StatusclosedFix in branchFixed in SCM revision9eace9bf1a4b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0032632: [Services] [SER-QA 866] The amount of the ticket is not calculated if there is a service included in a pack

DescriptionThe amount of the ticket is not calculated if there is a service included in a pack
Steps To Reproduce- Log into bacoffice
- Create a new Product:
  * Product category: Backpacks & Travel
  * Product type: Service
  * Linked to product: check
  * Included products: all excluding defined
  * Is price Rule based, checked
  * Proposal type: Mandatory proposal
- Add a price list: The White Valley Group Sale Price List Version
- Go to the assortment White Valley Group Product List and add the product
- Go to Discount and promotions windows and select Camping Pack
- Go to Products tab and add the new product created
- Log into WebPOS
- Select Camping Pack
- Realize that the amount is still 0.00

Proposed SolutionThe attached patch implements the restriction of not allowing to add services configured as linked to product in the pack definition. This configuration does not make sense and it is how it is forced this issue.
TagsSER-QA
Attached Filesdiff file icon 866.diff [^] (5,468 bytes) 2016-04-18 12:07 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0031632 closedaaroncalero It would be nice to implement Services functionality in WebPOS 
depends on backport 0033009RR16Q2 closedjorge-garcia [Services] [SER-QA 866] The amount of the ticket is not calculated if there is a service included in a pack 

-  Notes
(0086306)
hgbot (developer)
2016-05-09 12:45

Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 9eace9bf1a4ba6460c9ffcbce4b5ac32ca62d386
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Apr 21 12:50:13 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/9eace9bf1a4ba6460c9ffcbce4b5ac32ca62d386 [^]

Fixed issue 32632: The amount of the ticket is not calculated if there is a
service included in a pack

The solution is to not to allow the user add a product of type service in the
pack type discounts.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
A src/org/openbravo/retail/discounts/event/MOfferProductEventHandler.java
---
(0086315)
marvintm (manager)
2016-05-09 14:09

As the code is inside a Retail module, the license should be Openbravo Commercial License.
(0086317)
hgbot (developer)
2016-05-09 15:53

Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: bb4fa83224614d86bbd91a18722b67139e3c10e7
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon May 09 15:52:58 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/bb4fa83224614d86bbd91a18722b67139e3c10e7 [^]

Related to issue 32632: The amount of the ticket is not calculated if there is a
service included in a pack

Change license of file MOfferProductEventHandler.

---
M src/org/openbravo/retail/discounts/event/MOfferProductEventHandler.java
---
(0086583)
VictorVillar (manager)
2016-05-19 16:57

The solution deployed is not enough, it should be controlled in client side too, for those configurations that already exist in order to avoid wrong orders
(0086594)
marvintm (manager)
2016-05-20 09:40

After discussing within the team, we have concluded that it's not necessary to change the fix, as there hasn't been any release published with the functionality, and the one which includes the functionality for the first time (16Q2) will contain also this fix.

- Issue History
Date Modified Username Field Change
2016-04-08 12:45 xabiermerino New Issue
2016-04-08 12:45 xabiermerino Assigned To => Retail
2016-04-08 12:45 xabiermerino Resolution time => 1429740000
2016-04-08 12:45 xabiermerino Triggers an Emergency Pack => No
2016-04-08 12:46 xabiermerino Tag Attached: SER-QA
2016-04-11 12:49 maite Resolution time 1429740000 => 1461362400
2016-04-14 12:12 Orekaria Status new => acknowledged
2016-04-18 12:07 adrianromero File Added: 866.diff
2016-04-18 12:09 adrianromero Proposed Solution updated
2016-04-21 11:59 VictorVillar Summary The amount of the ticket is not calculated if there is a service included in a pack => [SER-QA 866] The amount of the ticket is not calculated if there is a service included in a pack
2016-04-25 13:08 jorge-garcia Status acknowledged => scheduled
2016-04-25 13:08 jorge-garcia Assigned To Retail => jorge-garcia
2016-04-25 13:09 Orekaria Summary [SER-QA 866] The amount of the ticket is not calculated if there is a service included in a pack => [Services] [SER-QA 866] The amount of the ticket is not calculated if there is a service included in a pack
2016-05-09 12:45 hgbot Checkin
2016-05-09 12:45 hgbot Note Added: 0086306
2016-05-09 12:45 hgbot Status scheduled => resolved
2016-05-09 12:45 hgbot Resolution open => fixed
2016-05-09 12:45 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/9eace9bf1a4ba6460c9ffcbce4b5ac32ca62d386 [^]
2016-05-09 14:09 marvintm Note Added: 0086315
2016-05-09 14:09 marvintm Status resolved => new
2016-05-09 14:09 marvintm Resolution fixed => open
2016-05-09 14:09 marvintm Status new => scheduled
2016-05-09 15:53 hgbot Checkin
2016-05-09 15:53 hgbot Note Added: 0086317
2016-05-09 15:53 jorge-garcia Status scheduled => resolved
2016-05-09 15:53 jorge-garcia Fixed in Version => RR16Q3
2016-05-09 15:53 jorge-garcia Resolution open => fixed
2016-05-16 12:17 marvintm Review Assigned To => marvintm
2016-05-16 12:17 marvintm Status resolved => closed
2016-05-19 16:57 VictorVillar Note Added: 0086583
2016-05-19 16:57 VictorVillar Status closed => new
2016-05-19 16:57 VictorVillar Resolution fixed => open
2016-05-19 16:57 VictorVillar Fixed in Version RR16Q3 =>
2016-05-20 09:33 marvintm Status new => scheduled
2016-05-20 09:39 marvintm Relationship added related to 0031632
2016-05-20 09:39 marvintm Status scheduled => resolved
2016-05-20 09:39 marvintm Fixed in Version => RR16Q3
2016-05-20 09:39 marvintm Resolution open => fixed
2016-05-20 09:40 marvintm Note Added: 0086594
2016-05-20 09:40 marvintm Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker