Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032632Retail ModulesWeb POSpublic2016-04-08 12:452016-05-20 09:40
Reporterxabiermerino 
Assigned Tojorge-garcia 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032632: [Services] [SER-QA 866] The amount of the ticket is not calculated if there is a service included in a pack
DescriptionThe amount of the ticket is not calculated if there is a service included in a pack
Steps To Reproduce- Log into bacoffice
- Create a new Product:
  * Product category: Backpacks & Travel
  * Product type: Service
  * Linked to product: check
  * Included products: all excluding defined
  * Is price Rule based, checked
  * Proposal type: Mandatory proposal
- Add a price list: The White Valley Group Sale Price List Version
- Go to the assortment White Valley Group Product List and add the product
- Go to Discount and promotions windows and select Camping Pack
- Go to Products tab and add the new product created
- Log into WebPOS
- Select Camping Pack
- Realize that the amount is still 0.00

Proposed SolutionThe attached patch implements the restriction of not allowing to add services configured as linked to product in the pack definition. This configuration does not make sense and it is how it is forced this issue.
Additional Information
TagsSER-QA
Relationships
related to feature request 0031632 closed aaroncalero It would be nice to implement Services functionality in WebPOS 
depends on backport 0033009RR16Q2 closed jorge-garcia [Services] [SER-QA 866] The amount of the ticket is not calculated if there is a service included in a pack 
Attached Filesdiff 866.diff (5,468) 2016-04-18 12:07
https://issues.openbravo.com/file_download.php?file_id=9274&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-04-08 12:45xabiermerinoNew Issue
2016-04-08 12:45xabiermerinoAssigned To => Retail
2016-04-08 12:45xabiermerinoOBNetwork customer => Yes
2016-04-08 12:45xabiermerinoResolution time => 1429740000
2016-04-08 12:45xabiermerinoTriggers an Emergency Pack => No
2016-04-08 12:46xabiermerinoTag Attached: SER-QA
2016-04-11 12:49maiteResolution time1429740000 => 1461362400
2016-04-14 12:12OrekariaStatusnew => acknowledged
2016-04-18 12:07adrianromeroFile Added: 866.diff
2016-04-18 12:09adrianromeroProposed Solution updated
2016-04-21 11:59VictorVillarSummaryThe amount of the ticket is not calculated if there is a service included in a pack => [SER-QA 866] The amount of the ticket is not calculated if there is a service included in a pack
2016-04-25 13:08jorge-garciaStatusacknowledged => scheduled
2016-04-25 13:08jorge-garciaAssigned ToRetail => jorge-garcia
2016-04-25 13:09OrekariaSummary[SER-QA 866] The amount of the ticket is not calculated if there is a service included in a pack => [Services] [SER-QA 866] The amount of the ticket is not calculated if there is a service included in a pack
2016-05-09 12:45hgbotCheckin
2016-05-09 12:45hgbotNote Added: 0086306
2016-05-09 12:45hgbotStatusscheduled => resolved
2016-05-09 12:45hgbotResolutionopen => fixed
2016-05-09 12:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/9eace9bf1a4ba6460c9ffcbce4b5ac32ca62d386 [^]
2016-05-09 14:09marvintmNote Added: 0086315
2016-05-09 14:09marvintmStatusresolved => new
2016-05-09 14:09marvintmResolutionfixed => open
2016-05-09 14:09marvintmStatusnew => scheduled
2016-05-09 15:53hgbotCheckin
2016-05-09 15:53hgbotNote Added: 0086317
2016-05-09 15:53jorge-garciaStatusscheduled => resolved
2016-05-09 15:53jorge-garciaFixed in Version => RR16Q3
2016-05-09 15:53jorge-garciaResolutionopen => fixed
2016-05-16 12:17marvintmReview Assigned To => marvintm
2016-05-16 12:17marvintmStatusresolved => closed
2016-05-19 16:57VictorVillarNote Added: 0086583
2016-05-19 16:57VictorVillarStatusclosed => new
2016-05-19 16:57VictorVillarResolutionfixed => open
2016-05-19 16:57VictorVillarFixed in VersionRR16Q3 =>
2016-05-20 09:33marvintmStatusnew => scheduled
2016-05-20 09:39marvintmRelationship addedrelated to 0031632
2016-05-20 09:39marvintmStatusscheduled => resolved
2016-05-20 09:39marvintmFixed in Version => RR16Q3
2016-05-20 09:39marvintmResolutionopen => fixed
2016-05-20 09:40marvintmNote Added: 0086594
2016-05-20 09:40marvintmStatusresolved => closed

Notes
(0086306)
hgbot   
2016-05-09 12:45   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 9eace9bf1a4ba6460c9ffcbce4b5ac32ca62d386
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Apr 21 12:50:13 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/9eace9bf1a4ba6460c9ffcbce4b5ac32ca62d386 [^]

Fixed issue 32632: The amount of the ticket is not calculated if there is a
service included in a pack

The solution is to not to allow the user add a product of type service in the
pack type discounts.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
A src/org/openbravo/retail/discounts/event/MOfferProductEventHandler.java
---
(0086315)
marvintm   
2016-05-09 14:09   
As the code is inside a Retail module, the license should be Openbravo Commercial License.
(0086317)
hgbot   
2016-05-09 15:53   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: bb4fa83224614d86bbd91a18722b67139e3c10e7
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon May 09 15:52:58 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/bb4fa83224614d86bbd91a18722b67139e3c10e7 [^]

Related to issue 32632: The amount of the ticket is not calculated if there is a
service included in a pack

Change license of file MOfferProductEventHandler.

---
M src/org/openbravo/retail/discounts/event/MOfferProductEventHandler.java
---
(0086583)
VictorVillar   
2016-05-19 16:57   
The solution deployed is not enough, it should be controlled in client side too, for those configurations that already exist in order to avoid wrong orders
(0086594)
marvintm   
2016-05-20 09:40   
After discussing within the team, we have concluded that it's not necessary to change the fix, as there hasn't been any release published with the functionality, and the one which includes the functionality for the first time (16Q2) will contain also this fix.