Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0032532 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | always | 2016-03-22 15:11 | 2016-04-18 08:35 | |||
| Reporter | NaroaIriarte | View Status | public | |||||
| Assigned To | NaroaIriarte | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR16Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | d45e65e8779c | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0032532: The "_where" parameter is used in some retail modules | |||||||
| Description | In the modules/org.openbravo.mobile.warehouse/web/org.openbravo.mobile.warehouse/source/goodsMovement/wh-movement-product.js src/org.openbravo.mobile.warehouse/web/org.openbravo.mobile.warehouse/source/goodsMovement/wh-movement-attribute.js src/org.openbravo.mobile.warehouse/web/org.openbravo.mobile.warehouse/source/goodsMovement/wh-movement-bin.js modules the "_where" parameter is used. This is not correct. It should be avoided sending that parameter. | |||||||
| Steps To Reproduce | 1- Go to [1] url. 2- Log in as demouser 3- Click on "physical inventory" 4- In the chrome console, in the "network" tab, click on "MaterialMgmtInventoryCountLine" datasource. 5- In the "Headers" tab, in the "Form Data" section, realize that the "_where" parameter is sent. This is not correct. [1]http://127.0.1.1:8080/openbravo/web/org.openbravo.mobile.warehouse/#wh [^] | |||||||
| Proposed Solution | Create a criteria instead of putting the where clause in the "_where" parameter. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0085627) hgbot (developer) 2016-04-13 17:25 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: d45e65e8779cd325a0d82d4637f172445c5ee21a Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com> Date: Wed Apr 13 17:12:36 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d45e65e8779cd325a0d82d4637f172445c5ee21a [^] Fixed issue 32532: The way of treating some models has changed For the Locator model, now it exists a new datasource which creates the correct where clause. The OB-Model js has been changed because before, string "Locator" was passed as argument to the OB.Data.Registry.registerModel function. But now an Object is passed, this object has a name and an id. The id is the id of the datasource which is going to be used and that id will be appended to the source. The name will be Locator, because that is the name of the model. --- M web/org.openbravo.mobile.core/source/data/ob-model.js --- |
|
(0085631) hgbot (developer) 2016-04-14 10:59 |
Repository: erp/pmods/org.openbravo.mobile.warehouse Changeset: 794c1b40acb0f21295552bb5dad559ee35f0f4ff Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com> Date: Wed Apr 13 17:02:26 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.warehouse/rev/794c1b40acb0f21295552bb5dad559ee35f0f4ff [^] Related with issue 32532: A datasource has been created The locator model needed a proper datasource, because the where clause needed to be calculated overriding the getWhereAndFilterClause method of BaseDataSourceService class. Before, the _where parameter was sent, now, some criterias have been created. --- M src-db/database/sourcedata/OBMOBC_SERVICES.xml M web/org.openbravo.mobile.warehouse/source/goodsMovement/wh-movement-attribute.js M web/org.openbravo.mobile.warehouse/source/goodsMovement/wh-movement-bin.js M web/org.openbravo.mobile.warehouse/source/goodsMovement/wh-movement-model.js M web/org.openbravo.mobile.warehouse/source/goodsMovement/wh-movement-product.js A src-db/database/sourcedata/OBSERDS_DATASOURCE.xml A src/org/openbravo/mobile/warehouse/datasource/WarehouseMovementBinDatasource.java --- |
|
(0085632) hgbot (developer) 2016-04-14 10:59 |
Repository: erp/pmods/org.openbravo.mobile.warehouse.physicalinventory Changeset: e2a3a2bfee43b886d6767dc52fc80dbecc273194 Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com> Date: Mon Apr 04 11:10:25 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.warehouse.physicalinventory/rev/e2a3a2bfee43b886d6767dc52fc80dbecc273194 [^] Related with issue 32532: Chaged the _where parameter Before, the _where parameter was sent, now, some criterias have been done to handle this. --- M web/org.openbravo.mobile.warehouse.physicalinventory/source/physicalinventory/pi-model.js --- |
|
(0085633) hgbot (developer) 2016-04-14 11:00 |
Repository: erp/pmods/org.openbravo.mobile.warehouse.picking Changeset: 136538784e81386770c9c85bf3781790dcf64c3e Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com> Date: Mon Apr 04 11:25:52 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.warehouse.picking/rev/136538784e81386770c9c85bf3781790dcf64c3e [^] Related with issue 32532: The _where parameter removed Before, a _where parameter was being sent, but now some criterias have been created. --- M web/org.openbravo.mobile.warehouse.picking/source/picking/wh-picking-model.js --- |
|
(0085687) alostale (manager) 2016-04-18 08:35 |
code reviewed and tested https://docs.google.com/spreadsheets/d/1YGuu1jnrD4_L1t0wfLvbogn7Q9-k70jaozJX9w7VUrU/edit#gid=0 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-03-22 15:11 | NaroaIriarte | New Issue | |
| 2016-03-22 15:11 | NaroaIriarte | Assigned To | => NaroaIriarte |
| 2016-03-22 15:11 | NaroaIriarte | Modules | => Core |
| 2016-03-22 15:11 | NaroaIriarte | Triggers an Emergency Pack | => No |
| 2016-04-13 17:25 | hgbot | Checkin | |
| 2016-04-13 17:25 | hgbot | Note Added: 0085627 | |
| 2016-04-13 17:25 | hgbot | Status | new => resolved |
| 2016-04-13 17:25 | hgbot | Resolution | open => fixed |
| 2016-04-13 17:25 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d45e65e8779cd325a0d82d4637f172445c5ee21a [^] |
| 2016-04-14 10:59 | hgbot | Checkin | |
| 2016-04-14 10:59 | hgbot | Note Added: 0085631 | |
| 2016-04-14 10:59 | hgbot | Checkin | |
| 2016-04-14 10:59 | hgbot | Note Added: 0085632 | |
| 2016-04-14 11:00 | hgbot | Checkin | |
| 2016-04-14 11:00 | hgbot | Note Added: 0085633 | |
| 2016-04-18 08:28 | alostale | Relationship added | related to 0032610 |
| 2016-04-18 08:35 | alostale | Review Assigned To | => alostale |
| 2016-04-18 08:35 | alostale | Note Added: 0085687 | |
| 2016-04-18 08:35 | alostale | Status | resolved => closed |
| 2016-04-18 08:35 | alostale | Fixed in Version | => 3.0PR16Q3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |