Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032532Openbravo ERPA. Platformpublic2016-03-22 15:112016-04-18 08:35
ReporterNaroaIriarte 
Assigned ToNaroaIriarte 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032532: The "_where" parameter is used in some retail modules
DescriptionIn the
modules/org.openbravo.mobile.warehouse/web/org.openbravo.mobile.warehouse/source/goodsMovement/wh-movement-product.js
src/org.openbravo.mobile.warehouse/web/org.openbravo.mobile.warehouse/source/goodsMovement/wh-movement-attribute.js
src/org.openbravo.mobile.warehouse/web/org.openbravo.mobile.warehouse/source/goodsMovement/wh-movement-bin.js

modules the "_where" parameter is used. This is not correct. It should be avoided sending that parameter.
Steps To Reproduce1- Go to [1] url.
2- Log in as demouser
3- Click on "physical inventory"
4- In the chrome console, in the "network" tab, click on "MaterialMgmtInventoryCountLine" datasource.
5- In the "Headers" tab, in the "Form Data" section, realize that the "_where" parameter is sent. This is not correct.


[1]http://127.0.1.1:8080/openbravo/web/org.openbravo.mobile.warehouse/#wh [^]
Proposed SolutionCreate a criteria instead of putting the where clause in the "_where" parameter.
Additional Information
TagsNo tags attached.
Relationships
related to feature request 00326103.0PR16Q3 closed NaroaIriarte standard datasources shouldn't accept where parameter by default 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-22 15:11NaroaIriarteNew Issue
2016-03-22 15:11NaroaIriarteAssigned To => NaroaIriarte
2016-03-22 15:11NaroaIriarteModules => Core
2016-03-22 15:11NaroaIriarteTriggers an Emergency Pack => No
2016-04-13 17:25hgbotCheckin
2016-04-13 17:25hgbotNote Added: 0085627
2016-04-13 17:25hgbotStatusnew => resolved
2016-04-13 17:25hgbotResolutionopen => fixed
2016-04-13 17:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d45e65e8779cd325a0d82d4637f172445c5ee21a [^]
2016-04-14 10:59hgbotCheckin
2016-04-14 10:59hgbotNote Added: 0085631
2016-04-14 10:59hgbotCheckin
2016-04-14 10:59hgbotNote Added: 0085632
2016-04-14 11:00hgbotCheckin
2016-04-14 11:00hgbotNote Added: 0085633
2016-04-18 08:28alostaleRelationship addedrelated to 0032610
2016-04-18 08:35alostaleReview Assigned To => alostale
2016-04-18 08:35alostaleNote Added: 0085687
2016-04-18 08:35alostaleStatusresolved => closed
2016-04-18 08:35alostaleFixed in Version => 3.0PR16Q3

Notes
(0085627)
hgbot   
2016-04-13 17:25   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d45e65e8779cd325a0d82d4637f172445c5ee21a
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Wed Apr 13 17:12:36 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d45e65e8779cd325a0d82d4637f172445c5ee21a [^]

Fixed issue 32532: The way of treating some models has changed

For the Locator model, now it exists a new datasource which creates the correct
where clause. The OB-Model js has been changed because before, string "Locator"
was passed as argument to the OB.Data.Registry.registerModel function. But now
an Object is passed, this object has a name and an id. The id is the id of the
datasource which is going to be used and that id will be appended to the source.
The name will be Locator, because that is the name of the model.

---
M web/org.openbravo.mobile.core/source/data/ob-model.js
---
(0085631)
hgbot   
2016-04-14 10:59   
Repository: erp/pmods/org.openbravo.mobile.warehouse
Changeset: 794c1b40acb0f21295552bb5dad559ee35f0f4ff
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Wed Apr 13 17:02:26 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.warehouse/rev/794c1b40acb0f21295552bb5dad559ee35f0f4ff [^]

Related with issue 32532: A datasource has been created

The locator model needed a proper datasource, because the where clause
needed to be calculated overriding the getWhereAndFilterClause method
of BaseDataSourceService class.
Before, the _where parameter was sent, now, some criterias have been
created.

---
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M web/org.openbravo.mobile.warehouse/source/goodsMovement/wh-movement-attribute.js
M web/org.openbravo.mobile.warehouse/source/goodsMovement/wh-movement-bin.js
M web/org.openbravo.mobile.warehouse/source/goodsMovement/wh-movement-model.js
M web/org.openbravo.mobile.warehouse/source/goodsMovement/wh-movement-product.js
A src-db/database/sourcedata/OBSERDS_DATASOURCE.xml
A src/org/openbravo/mobile/warehouse/datasource/WarehouseMovementBinDatasource.java
---
(0085632)
hgbot   
2016-04-14 10:59   
Repository: erp/pmods/org.openbravo.mobile.warehouse.physicalinventory
Changeset: e2a3a2bfee43b886d6767dc52fc80dbecc273194
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Mon Apr 04 11:10:25 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.warehouse.physicalinventory/rev/e2a3a2bfee43b886d6767dc52fc80dbecc273194 [^]

Related with issue 32532: Chaged the _where parameter

Before, the _where parameter was sent, now, some criterias have been done
to handle this.

---
M web/org.openbravo.mobile.warehouse.physicalinventory/source/physicalinventory/pi-model.js
---
(0085633)
hgbot   
2016-04-14 11:00   
Repository: erp/pmods/org.openbravo.mobile.warehouse.picking
Changeset: 136538784e81386770c9c85bf3781790dcf64c3e
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Mon Apr 04 11:25:52 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.warehouse.picking/rev/136538784e81386770c9c85bf3781790dcf64c3e [^]

Related with issue 32532: The _where parameter removed

Before, a _where parameter was being sent, but now some criterias have been created.

---
M web/org.openbravo.mobile.warehouse.picking/source/picking/wh-picking-model.js
---
(0085687)
alostale   
2016-04-18 08:35   
code reviewed and tested

https://docs.google.com/spreadsheets/d/1YGuu1jnrD4_L1t0wfLvbogn7Q9-k70jaozJX9w7VUrU/edit#gid=0 [^]