Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0032528

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2016-03-22 10:04

2016-04-27 13:15

Reporter

aaroncalero

View Status

public

Assigned To

mario_castello

Priority

normal

Resolution

fixed

Fixed in Version

RR16Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

marvintm

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0032528: The split done by combo discounts doesn't propagate changes done to lines

Description

When the combo discount calculation splits a line in two, the changes done to the original line are not propagated to the new line.

Steps To Reproduce

Install the Combo discounts module.
(optional: install also the retail tax exempt module, for extra checking)
Define a combo in backend with two families and products on both families.
Login in web pos (e.g. https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=YS-11, [^] already configured)
Add the Torch and Backpack combo:
* 1 unit of Backpack CB1 25l
* 2 units of Torch CB1
Change the price of the Backpack CB1 to 50
(optional) Go to the EDIT tab and apply Tax Exempt to that line.
With the backpack line still selected, click on the + button of the virtual keyboard.
Instead of increasing the quantity of the line to two, a new line is created (this is somewhat OK).
The problem is that the new line is created with the original price of the backpack, and without the Tax Exempt flag

Proposed Solution

This is the code that duplicates lines:
if (!linesCreated) {
        _.each(linesToCreate, function (line) {
          me.createLine(line.product, line.qty, null, line.attrs);
        });
        linesCreated = true;
      }
on order.js, function fillPromotionsWith().

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

closed

SoftwareFactory

[SERQA 769] Service icon and quantity of service is not working properly when a discount is applied

Notes
(0085578) hgbot (developer) 2016-04-12 17:37 edited on: 2016-04-12 17:42	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: d46f7f3695d8195bd3d3f3fe56a192f67f7d6269 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Mon Apr 11 09:08:49 2016 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d46f7f3695d8195bd3d3f3fe56a192f67f7d6269 [^] Fixed issue 32528: Added line price to new line in fillpromotion function. When creating the new line with the same product will pass the line price as an attribute to the new line --- M web/org.openbravo.retail.posterminal/js/model/order.js ---

Issue History
Date Modified	Username	Field	Change
2016-03-22 10:04	aaroncalero	New Issue
2016-03-22 10:04	aaroncalero	Assigned To	=> Retail
2016-03-22 10:04	aaroncalero	Triggers an Emergency Pack	=> No
2016-03-22 10:20	aaroncalero	Relationship added	related to 0032482
2016-04-06 11:27	aaroncalero	Proposed Solution updated
2016-04-06 11:28	Orekaria	Status	new => acknowledged
2016-04-06 11:29	Orekaria	Relationship replaced	blocks 0032482
2016-04-06 18:49	mario_castello	Assigned To	Retail => mario_castello
2016-04-11 17:23	mario_castello	Status	acknowledged => scheduled
2016-04-12 17:37	hgbot	Checkin
2016-04-12 17:37	hgbot	Note Added: 0085578
2016-04-12 17:37	hgbot	Status	scheduled => resolved
2016-04-12 17:37	hgbot	Resolution	open => fixed
2016-04-12 17:37	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d46f7f3695d8195bd3d3f3fe56a192f67f7d6269 [^]
2016-04-12 17:42	mario_castello	Note Edited: 0085578	View Revisions
2016-04-27 13:15	marvintm	Review Assigned To	=> marvintm
2016-04-27 13:15	marvintm	Status	resolved => closed
2016-04-27 13:15	marvintm	Fixed in Version	=> RR16Q3

Copyright © 2000 - 2009 MantisBT Group