Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032528Retail ModulesWeb POSpublic2016-03-22 10:042016-04-27 13:15
Reporteraaroncalero 
Assigned Tomario_castello 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032528: The split done by combo discounts doesn't propagate changes done to lines
DescriptionWhen the combo discount calculation splits a line in two, the changes done to the original line are not propagated to the new line.
Steps To ReproduceInstall the Combo discounts module.
(optional: install also the retail tax exempt module, for extra checking)
Define a combo in backend with two families and products on both families.
Login in web pos (e.g. https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=YS-11, [^] already configured)
Add the Torch and Backpack combo:
  * 1 unit of Backpack CB1 25l
  * 2 units of Torch CB1
Change the price of the Backpack CB1 to 50
(optional) Go to the EDIT tab and apply Tax Exempt to that line.
With the backpack line still selected, click on the + button of the virtual keyboard.
Instead of increasing the quantity of the line to two, a new line is created (this is somewhat OK).
The problem is that the new line is created with the original price of the backpack, and without the Tax Exempt flag
Proposed SolutionThis is the code that duplicates lines:
 if (!linesCreated) {
        _.each(linesToCreate, function (line) {
          me.createLine(line.product, line.qty, null, line.attrs);
        });
        linesCreated = true;
      }
on order.js, function fillPromotionsWith().
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0032482 closed SoftwareFactory [SERQA 769] Service icon and quantity of service is not working properly when a discount is applied 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-22 10:04aaroncaleroNew Issue
2016-03-22 10:04aaroncaleroAssigned To => Retail
2016-03-22 10:04aaroncaleroTriggers an Emergency Pack => No
2016-03-22 10:20aaroncaleroRelationship addedrelated to 0032482
2016-04-06 11:27aaroncaleroProposed Solution updated
2016-04-06 11:28OrekariaStatusnew => acknowledged
2016-04-06 11:29OrekariaRelationship replacedblocks 0032482
2016-04-06 18:49mario_castelloAssigned ToRetail => mario_castello
2016-04-11 17:23mario_castelloStatusacknowledged => scheduled
2016-04-12 17:37hgbotCheckin
2016-04-12 17:37hgbotNote Added: 0085578
2016-04-12 17:37hgbotStatusscheduled => resolved
2016-04-12 17:37hgbotResolutionopen => fixed
2016-04-12 17:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d46f7f3695d8195bd3d3f3fe56a192f67f7d6269 [^]
2016-04-12 17:42mario_castelloNote Edited: 0085578bug_revision_view_page.php?bugnote_id=0085578#r11756
2016-04-27 13:15marvintmReview Assigned To => marvintm
2016-04-27 13:15marvintmStatusresolved => closed
2016-04-27 13:15marvintmFixed in Version => RR16Q3

Notes
(0085578)
hgbot   
2016-04-12 17:37   
(edited on: 2016-04-12 17:42)
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d46f7f3695d8195bd3d3f3fe56a192f67f7d6269
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Apr 11 09:08:49 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d46f7f3695d8195bd3d3f3fe56a192f67f7d6269 [^]

Fixed issue 32528: Added line price to new line in fillpromotion function.
When creating the new line with the same product will pass the line price as an attribute to the new line

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---