Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0032422
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-03-07 12:152016-03-22 10:26
ReporterOrekariaView Statuspublic 
Assigned Toaaroncalero 
PrioritynormalResolutionfixedFixed in VersionRR16Q2
StatusclosedFix in branchFixed in SCM revisionf09fa5ca165f
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression levelAutomated tests
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0032422: [Services] Critical error messages are being bypassed

DescriptionAutomation: Critical error messages are being bypassed
Steps To ReproduceIn the AllowedErrorsHelper, remove these lines (notice that they are in 2 methods):

    testsAllowedToHaveJavascriptErrors.add("NoDeferrableTests");
    testsAllowedToHaveJavascriptErrors.add("DeferrableTests");
    testsAllowedToHaveJavascriptErrors.add("DeferrableSameDayTests");
    testsAllowedToHaveJavascriptErrors.add("Deferrable5DaysTests");
    testsAllowedToHaveJavascriptErrors.add("DeferrableNegativeDaysTests");

Execute e.g: the 'DeferrableNegativeDaysTests' test

Verify that several javascript errors are shown

    - setting the isCalculateGrossLocked state is mandatory before executing it the first time
    - should only be called by the UI receipt

These errors can lead to data corruption and are considered as critical
Proposed SolutionFix the code so those reported errors are not happening
  or
Discuss with the Retail team in case those checks must be modified
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0084871)
hgbot (developer)
2016-03-10 16:39

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f09fa5ca165f56cf1dfa82594222fd6680ad5cc4
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Wed Mar 09 12:42:23 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f09fa5ca165f56cf1dfa82594222fd6680ad5cc4 [^]

Fixed issue 32422: [Services] Critical error messages are being bypassed

---
M web/org.openbravo.retail.posterminal/js/components/modalselectopenreceipts.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0084872)
hgbot (developer)
2016-03-10 16:39

Repository: tools/automation/pi-mobile
Changeset: 5c673eaea89a81202a6b6b8c2b5604d2eb6790e5
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Wed Mar 09 12:44:11 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5c673eaea89a81202a6b6b8c2b5604d2eb6790e5 [^]

Related to issue 32422: Removed error bypassing tests from the AllowedErrorsHelper

---
M src-test/org/openbravo/test/mobile/common/selenium/utils/AllowedErrorsHelper.java
---
(0084901)
hgbot (developer)
2016-03-11 10:00

Repository: tools/automation/pi-mobile
Changeset: bb8bf9c8201dc1ae4000d3dd8a3fa602abad0382
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Thu Mar 10 17:07:27 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/bb8bf9c8201dc1ae4000d3dd8a3fa602abad0382 [^]

Related to issue 32422: Removed error bypassing tests from the AllowedErrorsHelper (2)

---
M src-test/org/openbravo/test/mobile/common/selenium/utils/AllowedErrorsHelper.java
---
(0085241)
dmitry_mezentsev (developer)
2016-03-21 12:21

Critical and not closed for 11 days.

- Issue History
Date Modified Username Field Change
2016-03-07 12:15 Orekaria New Issue
2016-03-07 12:15 Orekaria Assigned To => Retail
2016-03-07 12:15 Orekaria Triggers an Emergency Pack => No
2016-03-07 12:21 Orekaria Steps to Reproduce Updated View Revisions
2016-03-07 12:21 Orekaria Proposed Solution updated
2016-03-07 12:22 Orekaria Assigned To Retail => aaroncalero
2016-03-07 12:22 Orekaria Status new => scheduled
2016-03-07 16:18 Orekaria Regression level => Automated tests
2016-03-07 16:18 Orekaria Summary Automation: Critical error messages are being bypassed => [Services] Critical error messages are being bypassed
2016-03-10 16:39 hgbot Checkin
2016-03-10 16:39 hgbot Note Added: 0084871
2016-03-10 16:39 hgbot Status scheduled => resolved
2016-03-10 16:39 hgbot Resolution open => fixed
2016-03-10 16:39 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f09fa5ca165f56cf1dfa82594222fd6680ad5cc4 [^]
2016-03-10 16:39 hgbot Checkin
2016-03-10 16:39 hgbot Note Added: 0084872
2016-03-11 10:00 hgbot Checkin
2016-03-11 10:00 hgbot Note Added: 0084901
2016-03-18 08:10 aaroncalero Review Assigned To => Orekaria
2016-03-21 12:21 dmitry_mezentsev Review Assigned To Orekaria => marvintm
2016-03-21 12:21 dmitry_mezentsev Note Added: 0085241
2016-03-22 09:52 marvintm Severity critical => major
2016-03-22 10:26 marvintm Status resolved => closed
2016-03-22 10:26 marvintm Fixed in Version => RR16Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker