Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032422Retail ModulesWeb POSpublic2016-03-07 12:152016-03-22 10:26
ReporterOrekaria 
Assigned Toaaroncalero 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelAutomated tests
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032422: [Services] Critical error messages are being bypassed
DescriptionAutomation: Critical error messages are being bypassed
Steps To ReproduceIn the AllowedErrorsHelper, remove these lines (notice that they are in 2 methods):

    testsAllowedToHaveJavascriptErrors.add("NoDeferrableTests");
    testsAllowedToHaveJavascriptErrors.add("DeferrableTests");
    testsAllowedToHaveJavascriptErrors.add("DeferrableSameDayTests");
    testsAllowedToHaveJavascriptErrors.add("Deferrable5DaysTests");
    testsAllowedToHaveJavascriptErrors.add("DeferrableNegativeDaysTests");

Execute e.g: the 'DeferrableNegativeDaysTests' test

Verify that several javascript errors are shown

    - setting the isCalculateGrossLocked state is mandatory before executing it the first time
    - should only be called by the UI receipt

These errors can lead to data corruption and are considered as critical
Proposed SolutionFix the code so those reported errors are not happening
  or
Discuss with the Retail team in case those checks must be modified
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-07 12:15OrekariaNew Issue
2016-03-07 12:15OrekariaAssigned To => Retail
2016-03-07 12:15OrekariaTriggers an Emergency Pack => No
2016-03-07 12:21OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11377#r11377
2016-03-07 12:21OrekariaProposed Solution updated
2016-03-07 12:22OrekariaAssigned ToRetail => aaroncalero
2016-03-07 12:22OrekariaStatusnew => scheduled
2016-03-07 16:18OrekariaRegression level => Automated tests
2016-03-07 16:18OrekariaSummaryAutomation: Critical error messages are being bypassed => [Services] Critical error messages are being bypassed
2016-03-10 16:39hgbotCheckin
2016-03-10 16:39hgbotNote Added: 0084871
2016-03-10 16:39hgbotStatusscheduled => resolved
2016-03-10 16:39hgbotResolutionopen => fixed
2016-03-10 16:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f09fa5ca165f56cf1dfa82594222fd6680ad5cc4 [^]
2016-03-10 16:39hgbotCheckin
2016-03-10 16:39hgbotNote Added: 0084872
2016-03-11 10:00hgbotCheckin
2016-03-11 10:00hgbotNote Added: 0084901
2016-03-18 08:10aaroncaleroReview Assigned To => Orekaria
2016-03-21 12:21dmitry_mezentsevReview Assigned ToOrekaria => marvintm
2016-03-21 12:21dmitry_mezentsevNote Added: 0085241
2016-03-22 09:52marvintmSeveritycritical => major
2016-03-22 10:26marvintmStatusresolved => closed
2016-03-22 10:26marvintmFixed in Version => RR16Q2

Notes
(0084871)
hgbot   
2016-03-10 16:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f09fa5ca165f56cf1dfa82594222fd6680ad5cc4
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Wed Mar 09 12:42:23 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f09fa5ca165f56cf1dfa82594222fd6680ad5cc4 [^]

Fixed issue 32422: [Services] Critical error messages are being bypassed

---
M web/org.openbravo.retail.posterminal/js/components/modalselectopenreceipts.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0084872)
hgbot   
2016-03-10 16:39   
Repository: tools/automation/pi-mobile
Changeset: 5c673eaea89a81202a6b6b8c2b5604d2eb6790e5
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Wed Mar 09 12:44:11 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5c673eaea89a81202a6b6b8c2b5604d2eb6790e5 [^]

Related to issue 32422: Removed error bypassing tests from the AllowedErrorsHelper

---
M src-test/org/openbravo/test/mobile/common/selenium/utils/AllowedErrorsHelper.java
---
(0084901)
hgbot   
2016-03-11 10:00   
Repository: tools/automation/pi-mobile
Changeset: bb8bf9c8201dc1ae4000d3dd8a3fa602abad0382
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Thu Mar 10 17:07:27 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/bb8bf9c8201dc1ae4000d3dd8a3fa602abad0382 [^]

Related to issue 32422: Removed error bypassing tests from the AllowedErrorsHelper (2)

---
M src-test/org/openbravo/test/mobile/common/selenium/utils/AllowedErrorsHelper.java
---
(0085241)
dmitry_mezentsev   
2016-03-21 12:21   
Critical and not closed for 11 days.