Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0032306 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | always | 2016-02-23 09:21 | 2016-03-18 15:23 | |||
| Reporter | malsasua | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR16Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 43d3094ec070 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Linux 32 bit | Database | PostgreSQL | Java version | 1.6.0_18 | |||
| OS Version | Community Appliance | Database version | 8.3.9 | Ant version | 1.7.1 | |||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0032306: It is possible to mix positive and negative lines although the preference enabled | |||||||
| Description | with the preference 'Do Not Allow Sales on Return' set to Y, it is possible to mix one positive line and one negative line in a receipt | |||||||
| Steps To Reproduce | . create a receipt . add new line P1 . add new line P2 in second line click in number "2" and "-" second line is set to -1 | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0084579) hgbot (developer) 2016-02-29 04:15 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: aaf058e371ffd7067f92c2c315c46ee1967a2730 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Feb 29 08:44:42 2016 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aaf058e371ffd7067f92c2c315c46ee1967a2730 [^] Fixes issue 32306 : Validating Order Line Quantity Change With Preference Order should not allow negative qty lines if preference 'Do not allow Sales with return' was enabled --- M web/org.openbravo.retail.posterminal/js/model/order.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js --- |
|
(0084580) hgbot (developer) 2016-02-29 04:15 |
Repository: tools/automation/pi-mobile Changeset: 040d9fcf41e91cdd2ee8866fc8f61bd865f5fe8c Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Feb 29 08:44:17 2016 +0530 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/040d9fcf41e91cdd2ee8866fc8f61bd865f5fe8c [^] Verifies issue 32306 : Added automated test 'I32306_VerifyOrderLineNegateQtyWithPreference' --- M src-test/org/openbravo/test/mobile/common/selenium/utils/AllowedErrorsHelper.java A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I32306_VerifyOrderLineNegateQtyWithPreference.java --- |
|
(0084636) hgbot (developer) 2016-03-01 17:41 |
Repository: tools/automation/pi-mobile Changeset: fad2a89959fb9e4244ba96b1d212cdcce6c193c3 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Tue Mar 01 14:29:44 2016 +0530 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fad2a89959fb9e4244ba96b1d212cdcce6c193c3 [^] Verifies issue 32306 : Modified automated test 'I32306_VerifyOrderLineNegateQtyWithPreference' --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I32306_VerifyOrderLineNegateQtyWithPreference.java --- |
|
(0085003) marvintm (manager) 2016-03-16 12:18 |
It's good that now we have a single method which does the check, and has all logic centralized on it. However, this method is still using this code to check the preference value: OB.MobileApp.model.get('permissions').OBPOS_NotAllowSalesWithReturn And this is wrong. Instead of doing it this way, the OB.MobileApp.model.hasPermission. It's also important to ensure that this feature is enabled always to automatic roles, which should be handled automatically by the hasPermission method. |
|
(0085215) hgbot (developer) 2016-03-18 05:42 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 43d3094ec070aa876d8ea6b83bef062ef6a45701 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Fri Mar 18 10:11:39 2016 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/43d3094ec070aa876d8ea6b83bef062ef6a45701 [^] Fixes issue 32306 : Validating Order Line Quantity Change With Preference Replaced getPermission with hasPermission --- M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-02-23 09:21 | malsasua | New Issue | |
| 2016-02-23 09:21 | malsasua | Assigned To | => Retail |
| 2016-02-23 09:21 | malsasua | Triggers an Emergency Pack | => No |
| 2016-02-23 09:46 | malsasua | Resolution time | => 1459461600 |
| 2016-02-23 09:46 | malsasua | Severity | minor => major |
| 2016-02-23 09:46 | malsasua | Summary | It is possible to mix positive and negative lines without preference => It is possible to mix positive and negative lines although the preference enabled |
| 2016-02-26 12:10 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2016-02-26 12:10 | ranjith_qualiantech_com | Status | new => scheduled |
| 2016-02-29 04:15 | hgbot | Checkin | |
| 2016-02-29 04:15 | hgbot | Note Added: 0084579 | |
| 2016-02-29 04:15 | hgbot | Status | scheduled => resolved |
| 2016-02-29 04:15 | hgbot | Resolution | open => fixed |
| 2016-02-29 04:15 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aaf058e371ffd7067f92c2c315c46ee1967a2730 [^] |
| 2016-02-29 04:15 | hgbot | Checkin | |
| 2016-02-29 04:15 | hgbot | Note Added: 0084580 | |
| 2016-03-01 17:41 | hgbot | Checkin | |
| 2016-03-01 17:41 | hgbot | Note Added: 0084636 | |
| 2016-03-16 12:18 | marvintm | Note Added: 0085003 | |
| 2016-03-16 12:18 | marvintm | Status | resolved => new |
| 2016-03-16 12:18 | marvintm | Resolution | fixed => open |
| 2016-03-16 12:18 | marvintm | Status | new => scheduled |
| 2016-03-18 05:42 | hgbot | Checkin | |
| 2016-03-18 05:42 | hgbot | Note Added: 0085215 | |
| 2016-03-18 05:42 | hgbot | Status | scheduled => resolved |
| 2016-03-18 05:42 | hgbot | Resolution | open => fixed |
| 2016-03-18 05:42 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aaf058e371ffd7067f92c2c315c46ee1967a2730 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/43d3094ec070aa876d8ea6b83bef062ef6a45701 [^] |
| 2016-03-18 15:23 | marvintm | Review Assigned To | => marvintm |
| 2016-03-18 15:23 | marvintm | Status | resolved => closed |
| 2016-03-18 15:23 | marvintm | Fixed in Version | => RR16Q2 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |