Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032306Retail ModulesWeb POSpublic2016-02-23 09:212016-03-18 15:23
Reportermalsasua 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032306: It is possible to mix positive and negative lines although the preference enabled
Descriptionwith the preference 'Do Not Allow Sales on Return' set to Y, it is possible to mix one positive line and one negative line in a receipt
Steps To Reproduce. create a receipt
. add new line P1
. add new line P2
in second line click in number "2" and "-"

second line is set to -1
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-23 09:21malsasuaNew Issue
2016-02-23 09:21malsasuaAssigned To => Retail
2016-02-23 09:21malsasuaTriggers an Emergency Pack => No
2016-02-23 09:46malsasuaResolution time => 1459461600
2016-02-23 09:46malsasuaSeverityminor => major
2016-02-23 09:46malsasuaSummaryIt is possible to mix positive and negative lines without preference => It is possible to mix positive and negative lines although the preference enabled
2016-02-26 12:10ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-02-26 12:10ranjith_qualiantech_comStatusnew => scheduled
2016-02-29 04:15hgbotCheckin
2016-02-29 04:15hgbotNote Added: 0084579
2016-02-29 04:15hgbotStatusscheduled => resolved
2016-02-29 04:15hgbotResolutionopen => fixed
2016-02-29 04:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aaf058e371ffd7067f92c2c315c46ee1967a2730 [^]
2016-02-29 04:15hgbotCheckin
2016-02-29 04:15hgbotNote Added: 0084580
2016-03-01 17:41hgbotCheckin
2016-03-01 17:41hgbotNote Added: 0084636
2016-03-16 12:18marvintmNote Added: 0085003
2016-03-16 12:18marvintmStatusresolved => new
2016-03-16 12:18marvintmResolutionfixed => open
2016-03-16 12:18marvintmStatusnew => scheduled
2016-03-18 05:42hgbotCheckin
2016-03-18 05:42hgbotNote Added: 0085215
2016-03-18 05:42hgbotStatusscheduled => resolved
2016-03-18 05:42hgbotResolutionopen => fixed
2016-03-18 05:42hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aaf058e371ffd7067f92c2c315c46ee1967a2730 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/43d3094ec070aa876d8ea6b83bef062ef6a45701 [^]
2016-03-18 15:23marvintmReview Assigned To => marvintm
2016-03-18 15:23marvintmStatusresolved => closed
2016-03-18 15:23marvintmFixed in Version => RR16Q2

Notes
(0084579)
hgbot   
2016-02-29 04:15   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: aaf058e371ffd7067f92c2c315c46ee1967a2730
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Feb 29 08:44:42 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aaf058e371ffd7067f92c2c315c46ee1967a2730 [^]

Fixes issue 32306 : Validating Order Line Quantity Change With Preference

Order should not allow negative qty lines if preference 'Do not allow Sales with return' was enabled

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0084580)
hgbot   
2016-02-29 04:15   
Repository: tools/automation/pi-mobile
Changeset: 040d9fcf41e91cdd2ee8866fc8f61bd865f5fe8c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Feb 29 08:44:17 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/040d9fcf41e91cdd2ee8866fc8f61bd865f5fe8c [^]

Verifies issue 32306 : Added automated test 'I32306_VerifyOrderLineNegateQtyWithPreference'

---
M src-test/org/openbravo/test/mobile/common/selenium/utils/AllowedErrorsHelper.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I32306_VerifyOrderLineNegateQtyWithPreference.java
---
(0084636)
hgbot   
2016-03-01 17:41   
Repository: tools/automation/pi-mobile
Changeset: fad2a89959fb9e4244ba96b1d212cdcce6c193c3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Mar 01 14:29:44 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fad2a89959fb9e4244ba96b1d212cdcce6c193c3 [^]

Verifies issue 32306 : Modified automated test 'I32306_VerifyOrderLineNegateQtyWithPreference'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I32306_VerifyOrderLineNegateQtyWithPreference.java
---
(0085003)
marvintm   
2016-03-16 12:18   
It's good that now we have a single method which does the check, and has all logic centralized on it. However, this method is still using this code to check the preference value:

OB.MobileApp.model.get('permissions').OBPOS_NotAllowSalesWithReturn

And this is wrong. Instead of doing it this way, the OB.MobileApp.model.hasPermission. It's also important to ensure that this feature is enabled always to automatic roles, which should be handled automatically by the hasPermission method.
(0085215)
hgbot   
2016-03-18 05:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 43d3094ec070aa876d8ea6b83bef062ef6a45701
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Mar 18 10:11:39 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/43d3094ec070aa876d8ea6b83bef062ef6a45701 [^]

Fixes issue 32306 : Validating Order Line Quantity Change With Preference

Replaced getPermission with hasPermission

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---